Johannes Rieken
be897248a8
don't overwrite revealIfOpen-setting, fixes #74072
2019-05-24 10:34:21 +02:00
isidor
bdd04b1e1e
fixes #73633
2019-05-24 10:27:51 +02:00
Sandeep Somavarapu
ec4b62e975
define extension kind in package.json schema ( #73024 )
...
define extension kind in package.json schema
2019-05-24 10:11:43 +02:00
Johannes Rieken
214707c1fc
enable breadcrumbs by default, fixes #74048
2019-05-24 10:10:40 +02:00
Johannes Rieken
f27d4ab760
support highlights for both - file names, and source matches, #52743
2019-05-24 10:02:20 +02:00
isidor
6bf5a93238
compoiste: do not show progress for show, since show is now sync
2019-05-24 09:38:32 +02:00
Isidor Nikolic
91d17baf10
Merge pull request #73954 from jeanp413/debughover-preserve-whitespace
...
Preserve whitespace in debug hover expresion value
2019-05-24 09:35:32 +02:00
Benjamin Pasero
211fdbc9bc
debt - more async/await adoption
2019-05-24 08:13:24 +02:00
Matt Bierner
0f32f0ef5f
Clean up some usages of IDisposable[]
...
Part of #74250
- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Matt Bierner
5e1f9440d2
Fix compile errors related to toDispose refactoring
...
Not sure why incremental builds missed this
2019-05-23 19:35:15 -07:00
Matt Bierner
3d5ce6be5e
Introduce DisposableStore
...
Fixes #74242
Our current usage of dispoable arrays can leak disposables (see #74242 for details). This change introduces a new class called `DisposableStore` that can be used mostly as a drop in replacement for an array of disposables but will not leak disposbles if it is disposed
`DisposableStore` was extracted from the existing `Dispoable` class, which already implements this pattern. However `Disposable` is intended to be used as a base class while `DispoableStore` is a value class.
In addition, this change hides the `toDispose` / `_toDipose` members of `Disposable` as direct write access to the disposable array also allows for leaks (and breaks encapsulation)
2019-05-23 19:25:16 -07:00
Matt Bierner
ae8da480f0
Use fileService and Blob for resource viewer
...
Fixes #74191
Instead of using a base64 encoded data uri to display images, use the fileService to read Buffer, convert this to a Blob, and display the blob
2019-05-23 18:32:02 -07:00
Matt Bierner
f3b8d15b0d
Add DocumentLink.tooltip api proposal
...
For #72824
2019-05-23 17:57:04 -07:00
Bowden Kelly
5b9869eb02
Merge pull request #74167 from microsoft/wilkelly/pom
...
Add rnpm-plugin-windows and pom.xml check
2019-05-23 17:01:21 -07:00
SteVen Batten
de08876f73
fixes #74091
2019-05-23 16:57:25 -07:00
Peng Lyu
346da6b01a
dispose empty comment thread when collapse.
2019-05-23 16:37:42 -07:00
Matt Bierner
a9e31b19d7
Make sure we don't de-prioritize this. member suggestions
...
Fixes #74164
2019-05-23 16:06:34 -07:00
Matt Bierner
a4532de9af
Make sure we reset editors being iterations of test
2019-05-23 16:06:34 -07:00
Peng Lyu
fa69b4e7d6
Show context for diff view of merge conflict and introduce compareAll.
2019-05-23 14:19:09 -07:00
Daniel Imms
3bcb1fa9d8
Remove comments, polish jsdoc
2019-05-23 12:47:58 -07:00
Daniel Imms
b3ab7bd13e
Disallow runInBackground unless proposed is enabled
2019-05-23 12:42:22 -07:00
Daniel Imms
1f6bf9b92c
Add some runInBackground terminal tests
2019-05-23 12:38:25 -07:00
Daniel Imms
9b3544000e
Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground
2019-05-23 12:08:42 -07:00
Daniel Imms
87b18670bf
Get onData listener working
2019-05-23 12:07:52 -07:00
Johannes Rieken
499a38b1ec
make sure to dispose CancellationToken so that it doesn't steal ESC
2019-05-23 21:04:13 +02:00
Johannes Rieken
b6476d6c09
bring back anyScore but make it more strict (== easer to understand), #74203
2019-05-23 20:36:31 +02:00
Johannes Rieken
741d30409d
show statusbar message, cancel on ESC, active code editor must be on symbol
2019-05-23 20:20:01 +02:00
Johannes Rieken
577a558020
keep cycling via F12 when peek is disabled
2019-05-23 20:20:01 +02:00
Peng Lyu
3f1fb8aa56
focus comments panel command. fix #73920
2019-05-23 11:03:38 -07:00
Matt Bierner
e023b1bed8
Merge pull request #74185 from SimonSiefke/portmapping2
...
fix #74085
2019-05-23 10:48:23 -07:00
Rachel Macfarlane
52ee044787
Show prompt in issue reporter when writing to clipboard, fixes #50659
2019-05-23 10:46:05 -07:00
Rachel Macfarlane
1e54e7f4cb
Decrease issue reporter url length limit, fixes #70343
2019-05-23 10:38:08 -07:00
Peng Lyu
7b078e1165
Merge pull request #74089 from microsoft/rr/comments
...
Comment API
2019-05-23 09:42:56 -07:00
Peng Lyu
48f6cce7e8
change comment/actions to comment/context to keep align
2019-05-23 09:28:05 -07:00
Johannes Rieken
a330f0f57c
freeze FuzzyScore.Default, #74203
2019-05-23 17:35:20 +02:00
Benjamin Pasero
cc115e8325
debt - more async/await adoption
2019-05-23 16:13:50 +02:00
Isidor Nikolic
cd8000e1ab
Merge pull request #74144 from NizamLZ/fix/73975-input-box-escape-newlines
...
Input box escape \n, \r etc in the setter
2019-05-23 07:07:26 -07:00
Khaja Nizamuddin
f4cc2c7ef5
replace whitespace from initial value
2019-05-23 17:53:18 +05:30
Martin Aeschlimann
b331ec3386
code.sh for wsl: avoid cmd.
...
Fixes microsoft/vscode-remote-release#42
Fixes microsoft/vscode-remote-release#170
2019-05-23 12:46:09 +02:00
Benjamin Pasero
f41d863849
debt - more async/await adoption in workbench
2019-05-23 12:43:17 +02:00
Benjamin Pasero
4929acf926
debt - async/await in workbench
2019-05-23 11:49:27 +02:00
Hao Hu
2058f27615
Add git.pullTags setting
2019-05-23 11:28:28 +02:00
Dan McCarthy
11f4127091
Add shortcut to Collapse All Trees in Outline View ( #74026 )
...
* Add universal list collapseAll keybinding
This adds the ability to perform a collapse all on a full tree upon a keyboard shortcut. Upon performing the shortcut, it will collapse every node on the tree.
2019-05-23 11:24:56 +02:00
SteVen Batten
d6052bb34c
fixes #73218
2019-05-23 11:08:26 +02:00
Benjamin Pasero
7c57aaa622
debt - fs.readlink() can return relative paths, so we use fs.realpath() instead to ensure absolute paths for symbolic links when watching.
2019-05-23 10:28:24 +02:00
Simon Siefke
7a1af12064
add note that port mapping does not work for websockets
2019-05-23 09:16:38 +02:00
Simon Siefke
879e7636c2
revert #74085
2019-05-23 09:15:48 +02:00
Simon Siefke
e6415e9cd2
update master ( #3 )
...
update master
2019-05-23 09:02:48 +02:00
Sandeep Somavarapu
b74c612868
fix warning message
2019-05-23 07:39:18 +02:00
Sandeep Somavarapu
934727c6c2
microsoft/vscode-remote-release/issues/2 - ignore machine settings in user settings in remote context
2019-05-23 07:28:22 +02:00
