Commit graph

120274 commits

Author SHA1 Message Date
Matt Bierner 288be7d337
Fix settings keys (#208253)
Fixes #207804
2024-03-20 22:21:55 +01:00
Daniel Imms e85cbbcd22
Fire event 2024-03-20 14:10:29 -07:00
Fizz 06f1c12edb
Update IActionDescriptor.precondition desc (#176124)
* Update standaloneCodeEditor.ts

* Update comment and monaco.d.ts

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-20 21:09:24 +00:00
VLADIMIR VATSURIN 5af7860ca2
Fix file relative path link (#181475)
* Fix for file link with relative path

* Removed redundant comments

* Simplify fix to accomodate Windows paths

---------

Co-authored-by: Sidebail <vova.vatsurin@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-20 21:19:26 +01:00
Rob Lourens abd11f059e
Fix command buttons in 'push' (#208248)
Fix #207885
2024-03-20 21:16:30 +01:00
Ulugbek Abdullaev 92592894f7 rename suggestions: refactor: don't use any & change trace prefix 2024-03-20 20:26:37 +01:00
Ulugbek Abdullaev 52f8862304 rename suggestions: cancel rename suggestion providers if user started typing 2024-03-20 20:26:37 +01:00
Ulugbek Abdullaev fab256d903 rename suggestions: refactor: rename 'rename widget' accordingly 2024-03-20 20:26:37 +01:00
Ulugbek Abdullaev 67a3dd0cc2 rename suggestions: refactor: move selection computation where it belongs 2024-03-20 20:26:37 +01:00
Ulugbek Abdullaev 6efb7ca55b rename suggestions: refactor: formatting 2024-03-20 20:26:37 +01:00
Daniel Imms b07b0ac2ba
Compiling with terminalShellIntegration proposal
Part of #145234
2024-03-20 12:23:25 -07:00
Tyler James Leonhardt d6474a0560
Couple of styling updates to quick pick (#208242)
1. Separator descriptions no longer include opacity so that contrast ratio is satisfied
2. The separators are now a little taller so that they stand out compared to regular items
2024-03-20 20:23:04 +01:00
Daniel Imms 26a111b3a2
Update xterm.js
Fixes #208102
2024-03-20 12:15:08 -07:00
Bhavya U fb14b695a7
Fix accidently showing chat panel welcome (#208237)
* Fix accidently showing chat panel welcome

* Update distro commit ID
2024-03-20 19:52:20 +01:00
Adam Byrd c37edea794
Implement separate colors for primary and secondary cursors when multiple cursors are present (#181991)
* Add support for separate primary cursor color when multiple cursors are present
- Does not change the existing behavior when there's a single cursor. editorCursor.foreground and background are still used.
- Add editorCursor.multiple.primary.foreground and background theme colors for the primary cursor. Only used when multiple cursors exist. Fallback to editorCursor.foreground/background when theme colors aren't set.
- Add editorCursor.multiple.secondary.foreground and `background theme colors for non-primary cursors. Only used when multiple cursors exist. Fallback to editorCursor.foreground/background when theme colors aren't set.
Add cursor-primary and cursor-secondary html classes to target with cursor color styles. No new class is introduced in the single-cursor case.
- Currently does not affect overview ruler colors. editorCursor.foreground is still used, even when multiple cursors are present.

* Update overview ruler to use primary and secondary cursor colors
- This maintains the existing handling for colors being undefined. However, each of these colors have defaults do I'm not sure if it's actually possible for them to be undefined

* Fix formatting

* Fix compilation errors

* Fall back to the existing cursor colors (to avoid breaking existing themes)

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2024-03-20 19:24:59 +01:00
Aiday Marlen Kyzy 763ad71a17
Merge pull request #208228 from microsoft/aiday/addMoreTests
Create more auto-indentation tests
2024-03-20 19:02:52 +01:00
Aiday Marlen Kyzy 5e14e2e569
adding one more test for the incorrect indentation within comments 2024-03-20 18:57:31 +01:00
Aiday Marlen Kyzy 4b4af504a9
adding this potential regex pattern 2024-03-20 18:38:42 +01:00
Aiday Marlen Kyzy fe900ca88f
skipping additional test 2024-03-20 18:32:06 +01:00
Aiday Marlen Kyzy 3d71904882
adding only tests 2024-03-20 18:31:26 +01:00
Aiday Marlen Kyzy 0b391fa2d1
adding todo 2024-03-20 18:27:07 +01:00
Connor Peet 2ffe804c46
cli: allow specifying a server-data-dir and extensions-dir (#208225) 2024-03-20 18:09:51 +01:00
Tyler James Leonhardt cb9524cf4b
Allow separators to have tooltips & descriptions (#208224)
This allows the full-length separators to have tooltips and descriptions.

(They had support for tooltips already, but my refactoring to a tree broke that)

so really this just adds descriptions and fixes tooltips. Because of this, we now adopt the description in favor of the tooltip for QuickSearch
2024-03-20 10:09:14 -07:00
Hylke Bons abb6332a8c chore: Update codicons 2024-03-20 18:08:50 +01:00
Aiday Marlen Kyzy 997fa7f0d3
adding one more test 2024-03-20 17:57:12 +01:00
Aiday Marlen Kyzy 5cc65d29ab
arrow function 2024-03-20 17:41:07 +01:00
Tyler James Leonhardt 342d7a0c0c
Fixes #208207 (#208216)
Fixes https://github.com/microsoft/vscode/issues/208207
2024-03-20 17:25:02 +01:00
Tyler James Leonhardt 4f1d15d9da
Use correct colors for highlights (#208214)
I didn't realize there were 2 colors. This makes sure they're set correctly.

Fixes https://github.com/microsoft/vscode/issues/208213
2024-03-20 17:12:35 +01:00
Johannes bb289d3280
small todo updates 2024-03-20 17:07:46 +01:00
Aiday Marlen Kyzy b329f9c2a5
Merge pull request #207587 from microsoft/aiday/autoIndentTestSuite
Auto-indent test suite
2024-03-20 17:00:33 +01:00
Johannes 694bf0b64e
show input above, tweak "made edits" rendering 2024-03-20 17:00:23 +01:00
Benjamin Christopher Simmonds ab78ff55f4
Implement Display Protocol Detection (#208212)
display protocol
2024-03-20 17:00:23 +01:00
Johannes 57a7fcf1b3
during layout use dom.getTotalHeight(this.inputPart.element) instead of this.inputPart.inputPartHeight 2024-03-20 16:54:41 +01:00
Aiday Marlen Kyzy 72d785f196
skipping the test 2024-03-20 16:29:35 +01:00
Johannes 58f2e217fe
more test/snapshot updates 2024-03-20 16:26:22 +01:00
Aiday Marlen Kyzy 30227752a7
adding changes to tests 2024-03-20 16:20:26 +01:00
Johannes 15441f4251
Merge branch 'main' into joh/chatWidget 2024-03-20 16:06:03 +01:00
Johannes b0cb771744
update snapshots 2024-03-20 16:02:32 +01:00
Johannes 6ae696aa56
- first run of cleanup
- update new required services for tests and adjust them
2024-03-20 15:58:55 +01:00
Sandeep Somavarapu ccdffd394b
do not allow installing workspace extension in untrusted workspace (#208206) 2024-03-20 15:46:28 +01:00
Aiday Marlen Kyzy 8a22be5ddc
skiping the manual test 2024-03-20 15:38:50 +01:00
Alex Ross efb0960009
Fully reveal conversation when opening it (#208203)
Fixes #208202
2024-03-20 15:32:32 +01:00
Sandeep Somavarapu 1a97733c65
check if action exists (#208200) 2024-03-20 15:29:37 +01:00
Aiday Marlen Kyzy ab8fe9d628
Merge branch 'main' into aiday/autoIndentTestSuite 2024-03-20 15:00:19 +01:00
Marshall Roch 0142dbc319
fix "Extension [object Object] is not known" (#207764) 2024-03-20 13:51:18 +00:00
Adam Byrd 7f638be139
Change editor.action.focusNextCursor to reveal the primary cursor instead of all cursors (#182148)
* Split CursorControl.revealPrimary and IViewModel.revealPrimaryCursor into "reveal all" and "reveal primary" variants
- The original name was a lie. It wasn't revealing the primary cursor, it was revealing all cursors.
- Some things actually want to reveal the primary cursor specifically, such as editor.action.focusNextCursor. If the set of cursors do not all fit in the view and the primary cursor is not currently visible the primary cursor should be revealed.
- Other things want to reveal all cursors, such as cursorMove. However, there's likely room for improvement here as well: if the set of cursors do not all fit in the view and none of them are visible the closest cursor should probably be revealed.
- All existing locations have been updated to use "reveal all" which maintains the exact same behavior as before. Locations that want to use the primary variant will be updated in a separate commit.

* Update editor.action.focusPreviousCursor and focusNextCursor to reveal the primary cursor

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-20 13:50:22 +00:00
Alex Ross 95aaea0bb5
Editing end of comment causes text to scroll offscreen (#208197)
Fixes #207333
2024-03-20 14:36:48 +01:00
Aiday Marlen Kyzy c6b9216581
remove the comments 2024-03-20 14:36:33 +01:00
Benjamin Christopher Simmonds 0657184073
Custom Labels Enhancement (#208029)
* Custom Lables

* polish

* dirname(nth)

* fix test?

* cleanup and perf

* 💄

* 💄

* 💄

* expression is parsed when initialized

* readonly

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-03-20 14:33:58 +01:00
Johannes dfd931d40c
fix/re-enable options.autoSend 2024-03-20 14:07:32 +01:00