Commit graph

4824 commits

Author SHA1 Message Date
Connor Peet d5ab02349e rename cli binary to reflect quality 2023-01-17 08:19:36 -08:00
João Moreno e8fa61d2fc
retry terrapin 5 times (#171489)
fixes #170935
2023-01-17 13:48:02 +01:00
Martin Aeschlimann d4237bd8d5
merge ThemeIcon and CSSIcon (#171279) 2023-01-13 20:15:16 +01:00
Tyler James Leonhardt 7c0e51357d
Pull l10n files from build folder for extensions that don't live in source (#171217)
This will allow the l10n build to pick up the bundle.l10n.json inside of js-debug

cc @connor4312
2023-01-13 08:34:14 +01:00
João Moreno 89e427274e
fix darwin universal (#171072) 2023-01-11 17:09:19 +01:00
João Moreno 277e80be94
dynamically find macos signing identity (#171063)
* dynamically find macos signing identity

* debug

* more debug

* argh

* Revert "argh"

This reverts commit 0e0715fb44.

Revert "more debug"

This reverts commit 7632542023.

Revert "debug"

This reverts commit 6f00a3acef.
2023-01-11 23:39:31 +09:00
Robo 2fae780e49
chore: update code signing certificate identity (#171061) 2023-01-11 14:13:50 +01:00
SteVen Batten d11f9ceb6f
better scanning (#170885)
* replace cql task in sdl scan

* fix var format

* switch to 1es-windows image
2023-01-09 20:17:34 +01:00
Connor Peet 314d7b6c47
debug: allow setting breakpoints in plain .js files (#168921)
* debug: allow setting breakpoints in plain .js files

Fixes #159684

* fixup! don't change sourceURLs in build
2023-01-06 09:22:46 +01:00
João Moreno 717d7d62c8
always authenticate to npm (#170437) 2023-01-03 09:27:18 +01:00
dependabot[bot] 6106980525
Bump json5 from 2.2.0 to 2.2.2 in /build (#170244)
Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.2.0...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-30 21:50:46 +01:00
João Moreno 7f65f0213c
fix CI when publishing alpine assets (#169917) 2022-12-23 13:23:26 +01:00
João Moreno 326876fa9e
bump vsce (#168071)
* bump vsce

* remainder

* use latest vsce

* compile build output
2022-12-22 17:00:21 +01:00
Ladislau Szomoru f9333a4a16
Revert "Engineering - do not extract node modules archive in the job that keeps the cache warm (#169736)" (#169739)
This reverts commit 2f582604fb.
2022-12-21 13:33:43 +01:00
Ladislau Szomoru 2f582604fb
Engineering - do not extract node modules archive in the job that keeps the cache warm (#169736) 2022-12-21 12:44:30 +01:00
Ladislau Szomoru 574bc61051
Engineering - Windows job use generic node modules cache when quality is OSS (#169727) 2022-12-21 12:02:27 +01:00
Peng Lyu 687cc4fe97
Fix #168070. Filter ipynb output from hygine (#169691) 2022-12-20 23:33:30 +01:00
Ladislau Szomoru 9d5de75930
Engineering - Create Windows job to maintain cache (#169675)
Create Windows job to maintain cache
2022-12-20 21:18:53 +01:00
Ladislau Szomoru e1b6f8f9a5
Engineering - Add Windows test jobs to PR pipeline (#169627)
* Add Windows test jobs

* Comment out Windows smoke tests
2022-12-20 12:30:58 -07:00
Tyler James Leonhardt 0510da84dd
Use new version of @vscode/l10n-dev that uses tree-sitter (#169668)
Use new version of @vscode/l10n-dev

Required a bit more refactoring because an API had to be made async.
2022-12-20 19:53:50 +01:00
João Moreno 983b06e9bf
polish mangler output to align with build (#169388) 2022-12-16 13:20:07 +01:00
João Moreno 1e1da2aed3
build: refactor alpine out of linux (#169368)
* build: refactor alpine out of linux (#169278)

* fix alpine stage with no jobs

* test

* revert test
2022-12-16 08:51:06 +01:00
Joyce Er e408ce88e0 Revert "build: refactor alpine out of linux (#169278)"
This reverts commit 3567fd1145.
2022-12-15 11:47:27 -08:00
João Moreno 3567fd1145
build: refactor alpine out of linux (#169278) 2022-12-15 16:51:12 +01:00
Johannes 0d5f87e9dd
change source map merge logic to be like applying line edits to the typescript source maps (based on the input source maps) 2022-12-14 15:57:55 +01:00
Johannes 59f0d9c20e
fix ts2ts source map generation 2022-12-14 12:22:56 +01:00
Johannes cf8ae4b515
Merge branch 'main' into joh/sourceMaps-mangleProps 2022-12-13 14:18:00 +01:00
João Moreno 90812ba66f
remove unused pipeline (#168567) 2022-12-09 10:45:01 +01:00
Matt Bierner 6e5b663e99
Make sure lib.d.ts is included in build (#168501)
Fixes #168420
2022-12-08 11:36:42 -08:00
dependabot[bot] 7ca99004a5
Bump qs from 6.10.1 to 6.11.0 in /build (#168174)
Bumps [qs](https://github.com/ljharb/qs) from 6.10.1 to 6.11.0.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.10.1...v6.11.0)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-07 09:26:10 +01:00
Sandeep Somavarapu fac2283bf3
fix string.replace (#168169)
fix string.replace #167239
2022-12-06 14:50:23 +01:00
Johannes f73bb21f27
wip 2022-12-02 13:03:16 +01:00
Matt Bierner ce934ff443
Also run cleanNodeModules on extensions/node_modules (#167476)
Also run cleanNodeModules on extensions/node_modules

Fixes #166652
2022-11-29 12:15:09 -08:00
Matt Bierner afd71d8f10
Be more selective about which typescript d.ts files we include (#167477)
Be more selective about which d.ts files we include
2022-11-28 16:27:03 -08:00
Martin Aeschlimann 86ff830c3a
fix string.replace (for #167239) (#167259) 2022-11-25 14:45:57 +00:00
Benjamin Pasero aa961ec5da
String.replace will substitute special patterns (#167239) (#167250) 2022-11-25 14:03:49 +00:00
Johannes Rieken 1e3d0b5c05
mangle polish (#166604)
* mangle polish

* missing js files (again...)
2022-11-24 14:52:10 +01:00
Connor Peet fb53973c5f
cli: pull documentation url from product.json (#166993)
Fixes https://github.com/microsoft/vscode-cli/issues/560
2022-11-22 11:21:41 -08:00
Connor Peet 94ee5f5861
cli: automatically use distro qualities if available (#166961)
A fully-functioning CLI with tunnel capabilities requires product-specific
configuration that is not included in the OSS. This change has the CLI's build
script automatically look for a peer `vscode-distro` folder and, in a debug
build, set its build variables based on that.

It also works to set correct variables if vscode-distro is not found, based on
the OSS product.json (though this is not sufficient to run a fully fledged
tunnel.)
2022-11-22 06:13:16 -08:00
Martin Aeschlimann 0131be02f4
add editorWebUrl to tunnelApplicationConfig (#166872)
* add editorWebUrl to tunnelApplicationConfig

* bump distro & compile 'build'
2022-11-21 09:37:26 -08:00
Johannes Rieken f08feed6f1
Merge pull request #166686 from microsoft/joh/middle-jellyfish
Remove __$__nodeRequire usages
2022-11-21 11:50:02 +01:00
Johannes 0dac468cc0
mark package.json as external module 2022-11-21 11:26:17 +01:00
Connor Peet 796ee2bf3c
chore: pull more strings from the product.json (#166769)
Fixes the bulk of https://github.com/microsoft/vscode-cli/issues/560
2022-11-18 18:52:52 -08:00
Matt Bierner f98ca02f59
Use moduleignore to try excluding unused ts files (#166654)
Use moduleignore to exclude unused ts files

Fixes #166652
2022-11-17 15:53:52 -08:00
Johannes fdc39b56e4
missing JS files 2022-11-16 13:47:07 +01:00
Johannes Rieken 3ffb834054
Merge branch 'main' into joh/rewrite-privates 2022-11-16 10:20:49 +01:00
Henning Dieterichs 3e19ba91ff
Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor. (#165179)
* Allows to pass in a custom diffing algorithm when instantiating the monaco diff editor.

* Undo launch.json change
2022-11-16 08:48:39 +01:00
Matt Bierner d0d28a6295
Reapply building of web server (#166391)
* Reapply building of web server

Revert 8b4642ab23

* Fix critical dep error
2022-11-15 14:55:40 -08:00
Henning Dieterichs b11207c539 Revert "Copy webServer from Typescript to VS Code (#165771)"
This reverts commit cb43019d6a.
2022-11-15 14:45:32 +01:00
Johannes c281755a1b
more missing JS files 2022-11-15 09:45:01 +01:00
Johannes 5912ad3ff1
Merge branch 'main' into joh/rewrite-privates 2022-11-15 09:44:34 +01:00
Johannes 424a88c0ef
missing JS files 2022-11-15 09:05:07 +01:00
Connor Peet c47751948c
cli: add service integration for systemd (#166328)
systemd, like most 'modern' linux components, has a nice dbus API. This uses
that API to register the tunnel as a service of the calling user.

The dbus dependency is temporarily duplicated, until secret-service 3 is
released, where they update to the latest version (should be a week or two).

For https://github.com/microsoft/vscode-cli/issues/367. Next up, macOS,
then it's done :)
2022-11-14 21:39:05 -08:00
Nathan Shively-Sanders cb43019d6a
Copy webServer from Typescript to VS Code (#165771)
* Initial draft.

Not working.
Also not correctly formatted, I'll do that later.

* Various fixes

It works now

* A bit of cleanup

* Move webServer to its own directory

And prepare for getting rid of dynamicImportCompat.js hack

* Remove dynamicImportCompat.js hack

* Revert unrelated change

* Webpac tsserver.web.js with webServer.ts as entrypoint

Instead of using CopyPlugin.

1. Shipping multiple entrypoints in a single file required fixes to
build code.
2. There are a couple of warnings from `require` calls in
tsserverlibrary.js. Those are not relevant since they're in non-web
code, but I haven't figured how to turn them off; they are fully dynamic
so `externals` didn't work.

* Ignore warnings from dynamic import in tsserver

* Add to .vscodeignore files
2022-11-14 10:56:31 -08:00
Johannes aeb79e48a0
free memory when TS2TS mangling is done 2022-11-14 16:54:13 +01:00
Johannes 85c28e5927
improve printing of implicit public cases 2022-11-14 16:15:11 +01:00
Johannes d481999d09
make TS-mangler part of compile-build 2022-11-14 15:55:02 +01:00
Johannes 201e6a3e11
make mangler a class with mangle call, return vinyl instances 2022-11-14 13:51:21 +01:00
Johannes fb8187c953
source maps for build/lib 2022-11-14 11:57:01 +01:00
Johannes 66198056ea
source maps for build/lib 2022-11-14 11:56:32 +01:00
Johannes 58e979f39e
Merge branch 'main' into joh/rewrite-privates 2022-11-14 11:56:16 +01:00
Tyler James Leonhardt 964dc545ab
Pickup bundle.l10n.json (#166169)
For npm modules that have bundled `@vscode/l10n`, they can export their strings to a bundle.l10n.json file which will get picked up by this change and included in the overall bundle for the extension.
2022-11-12 14:42:39 -08:00
Johannes 15cb324f3f
do it all with the language service 2022-11-11 17:16:29 +01:00
Johannes 17737278ae
rename to typescript manger, (mostly) use language service rename feature 2022-11-11 13:48:21 +01:00
Ramón Corominas c9f32595a6
Update messages.es.isl to add context menu hotkey (#166010)
* Update messages.es.isl

Add a hotkey to allow opening with Code from the context menu also in Spanish

* fix encoding

Co-authored-by: Joao Moreno <joao.moreno@microsoft.com>
2022-11-11 01:34:09 -08:00
João Moreno 59814267dd
Use new Key Vault account (#166049)
use separate keyvault
2022-11-11 09:38:36 +01:00
Johannes 696c1cf199
build utils with source map to enable JS debug console 2022-11-10 15:05:47 +01:00
Matt Bierner d950552131
Allow trailing commas while minifying json resources (#165870)
I noticed a few of our built-in extension's json resources were not being minified. The root cause appears to be trailing commas in the json
2022-11-08 14:38:53 -08:00
易良 59faab44cd
Only use string of the remote/web/package.json browser field (#165163)
fix(build): Close #165162, only use string of the package.json `browser` field
2022-11-08 10:30:02 -05:00
Connor Peet 1d4beede78
Merge pull request #165773 from microsoft/connor4312/cli-pin-rust-version
cli: pin rust (and clippy) version for builds
2022-11-07 20:26:26 -08:00
Tyler James Leonhardt a8ae2cedaf
Include JS files in XLF creation for extensions (#165774)
* Bumps @vscode/l10n-dev to a version that supports JS files
* Pulls in JS files (and TSX & JSX) in addition to TS to account for scenarios like Emmet which pulls in @vscode/emmet-helper as an npm package
2022-11-07 19:50:39 -08:00
Connor Peet 63fbcea804
cli: pin rust (and clippy) version for builds 2022-11-07 17:56:35 -08:00
Connor Peet eb7c77c508
cli: only build common platforms in ci
Fixes #165140
2022-11-07 11:08:57 -08:00
Tyler James Leonhardt 0249ba460f
use the actual extension id as the id in the language pack (#165436)
Past behavior caused 404s to be thrown by the unpkg service because core was trying to load:

`${extensionId}` -> `vscode.markdown`

and not what the build creates in the language packs:
`vscode.${extensionFolder}` -> `vscode.markdown-basics`

this aligns build time and runtime.
2022-11-03 15:50:50 -07:00
Matt Bierner e7e403d83f
Bump target for build scripts (#165287) 2022-11-03 12:19:54 -07:00
Logan Ramos c6210c1c58
Reduce loaded web modules (#165369) 2022-11-03 08:36:45 -07:00
Alexandru Dima 4608b378a8
Align cache key across OSes (#165042) 2022-11-03 14:48:47 +01:00
João Moreno b0da2ea781
fix Alpine builds with npm custom registry (#165137)
fixes #165135
2022-11-01 07:28:06 -07:00
João Moreno be022daa1a
add 🚀 build tag to builds which go through publishing (#165145) 2022-11-01 04:15:50 -07:00
João Moreno 0a19bf0e8f
fix inno setup build for non-insider qualities (#165143)
fixes #165142
2022-11-01 03:53:58 -07:00
Matt Bierner d1c401cbde
Pick up latest TS for building VS Code (#165104)
* Pick up latest TS for building VS Code

* Pick up latest node typings

* Bump node types
2022-11-01 02:43:09 -07:00
Tyler James Leonhardt 0a80e31f6f
Sort the keys in order to be more predictable (#164920)
sort the keys in order to be more predictable
2022-10-28 21:16:05 +02:00
Ladislau Szomoru c7647cd307
Engineering - Add quality in the build name (#164855)
Add quality in the build name
2022-10-28 10:01:45 +02:00
Alexandru Dima ba91a81c16
Always patch the npm registry in yarn.lock files and compute the node modules cache key after having patched them (#164795) 2022-10-27 12:31:15 +02:00
Alexandru Dima c3eebaead9
Fix accidental deletion of vscode.proposed.contribNotebookStaticPreloads.d.ts and make sure to include the check in the compile-build gulp task (#164681) 2022-10-26 10:59:54 +02:00
Matt Bierner 0c6cc3a886
Let markdown strings specify a list of commands that they allow (#163915)
* Let markdown strings specify a list of commands that they allow

Fixes #163913

* Fix name
2022-10-24 14:15:44 -07:00
Connor Peet ed54a91fd0
build: parallelize cli build
Put all win and macOS builds on their own machine, since they take a minute.
Build the two GNU ARM builds together on an x64 machine, since they're
faster and can cross-compile in ~5 minutes.

This makes the CompileCLI step take a little less time than the VS Code
"Compile" step.
2022-10-24 12:01:03 -07:00
Johannes Rieken fec87f38cb
Analyse profiles in worker thread (#164468)
- profile renderer returns profile data
- analyse profiles in separate worker thread
- adjust renderer and extension host profiling
- adjust build scripts to build worker file
2022-10-24 17:42:54 +02:00
Ladislau Szomoru b757c8e3ca
Engineering - Pin macOS build agent (#164455)
Pin macOS build agent
2022-10-24 06:38:26 -07:00
João Moreno 8fe6f3e917
Allow custom npm registries at build time (#163629)
* use azure artifacts as new terrapin solution

* debug

* skip npm auth

* bring back

* also configure yarn

* custom npm registry

* oops

* powershell

* use none instead of empty string

* uff
2022-10-24 09:24:44 +02:00
Robo bece5db818
chore: cleanup inno setup for context menu install (#164411) 2022-10-24 06:45:20 +02:00
Martin Aeschlimann f10e84118b
ci: use tunnelApplicationName (#164257)
fix location of tunnel command in CI and in code
2022-10-23 20:12:23 +03:00
Connor Peet b3a0ecc97f
Merge pull request #164270 from microsoft/connor4312/use-packaged-openssl
build: use packages openssl instead of compiling during builds
2022-10-21 11:35:18 -07:00
Robo ebea50afee
feat: bundle sparse package to integrate with windows context menu (#151186)
* chore: bundle and sign explorer appx

* chore: bump vscode-explorer-command@3.0.1

* chore: explorer install/uninstall stage for appx

* chore: fix format for cmd exec

* chore: cmd file path needs triple quotes

* chore: update vscode-explorer-command@3.0.2

* chore: add reg key for new context menu title

* chore: update vscode-explorer-command@3.0.3

* fix: guard behind insider quality

* chore: fix merge conflict

* fix: type mismatch

* chore: restrict context menu related actions for win11

* refactor appx loading/unloading, revert inno updater

* update powershell

* chore: undo inno_updater changes

* fix: appx install script

* fix: perform install after update step

* fix: mv appx install to files section

* chore: additional fixes

- Remove old context menu entries when updating to newer version
- Remove context menu entry when reinstalling without menu action selected.

* chore: update vscode-explorer-command@3.0.4

- Fixes garbled title for system installation

Co-authored-by: Joao Moreno <joao.moreno@microsoft.com>
2022-10-21 20:17:30 +02:00
Connor Peet fff294400b
Merge remote-tracking branch 'origin/main' into connor4312/use-packaged-openssl 2022-10-21 10:55:13 -07:00
Connor Peet c3692c96f6
build: use npm instead of universal for arm compatibility 2022-10-21 10:21:02 -07:00
Sandeep Somavarapu c1ac223c69
fix node-vsce-sign (#164253)
* update distro

* add vsce-sign to asar

* filter node-vsce-sign

* update distro
2022-10-21 08:25:36 -07:00
Abhishek Singh 9509e6f3ef
increase innosetup minversion to win8 (#163040)
* increase innosetup minversion to win8

* Update build/win32/code.iss

Co-authored-by: João Moreno <mail@joaomoreno.com>
2022-10-21 16:54:05 +02:00
Connor Peet abf905e5dd
build: cleanup old cmakes 2022-10-20 18:33:06 -07:00
Connor Peet ddd4431d14
build: fix git auth with cli 2022-10-20 18:25:19 -07:00
Connor Peet 883bac79c4
build: fix
Local debug stuff got onto main
2022-10-20 17:59:16 -07:00
Connor Peet bf36a10c47
cli: use packaged openssl instead of artisanal builds 2022-10-20 17:14:14 -07:00
Connor Peet 0cc08da37a
cli: build the tunnel cli by default 2022-10-20 16:58:02 -07:00
Connor Peet 8ba5882fb8
Merge pull request #163971 from microsoft/connor4312/cli-vcpkg
cli: use vcpkg for everything
2022-10-20 16:45:18 -07:00
Connor Peet c536595a7f
cli: fallback to system installs in the standalone CLI
The standalone CLI should detect and fall back to using and
system-installed VS Code instance, rather than trying to download zips
and manage its own VS Code instances.

There are three approaches used for discovery:

- On Windows, we can easily and quickly read the register to find
  installed versions based on their app ID.
- On macOS, we initially look in `/Applications` and fall back to the
  slow `system_profiler` command to list app .app's if that fails.
- On Linux, we just look in the PATH. I believe all Linux installers
  (snap, dep, rpm) automatically add VS Code to the user's PATH.

Failing this, the user can also manually specify their installation dir,
using the command `code version use stable --install-dir /path/to/vscode`.

Fixes #164159
2022-10-20 10:54:13 -07:00
Connor Peet 8bfd07de06
update client builds to pull the right artifacts 2022-10-18 15:42:31 -07:00
Connor Peet 691ffd27c2
fix missing sudo 2022-10-18 15:05:49 -07:00
Connor Peet 067db8e75b
set linker for armhf correctly 2022-10-18 14:59:21 -07:00
Connor Peet ed0a21eda6
Merge remote-tracking branch 'origin/main' into connor4312/msrustup 2022-10-18 14:25:51 -07:00
Connor Peet 24a51e506f
try using vcpkg for everything 2022-10-18 10:58:50 -07:00
Connor Peet c625ff80d3
Merge pull request #161658 from microsoft/connor4312/cli-self-update
cli: implement correct self-updating
2022-10-18 08:38:28 -07:00
Martin Aeschlimann c83eff40dd
Remove too many folding regions notification (#163854)
* Remove too many folding regions notification

* remove duplicate folding limit item for JSON/JSONC

* polish

* fix test
2022-10-17 14:42:02 -07:00
Connor Peet b987cb47f4
fix integrated cli check 2022-10-17 13:53:06 -07:00
Connor Peet 4e9bdbd44f
make self-update work on Linux 2022-10-17 13:38:52 -07:00
Connor Peet 7c3740a7e7
update prepare scripts, license, lockfile 2022-10-17 11:50:49 -07:00
Connor Peet 75dfb8993e
Merge branch 'main' into connor4312/cli-self-update 2022-10-17 11:15:23 -07:00
Connor Peet cb1b7ec10b
temporarily disable secret-service pending update 2022-10-17 11:13:51 -07:00
Connor Peet 450f8e65b6
run cli tests on pr 2022-10-17 09:56:15 -07:00
Connor Peet 84439a87f6
wip 2022-10-14 15:46:49 -07:00
Connor Peet 84a929b8b7
Merge remote-tracking branch 'origin/main' into connor4312/cli-self-update 2022-10-14 14:23:41 -07:00
João Moreno ac9aff3521
reenable terrapin (#163622)
* drop npx for terrapin

* enable terrapin by default
2022-10-14 01:35:15 -07:00
Tyler James Leonhardt 4502088b10
fix empty check for json (#163576) 2022-10-13 11:01:05 -07:00
Tyler James Leonhardt 77d14a4711
use size to check if any files were added (#163571)
use size
2022-10-13 09:54:57 -07:00
Martin Aeschlimann 17c7a08962
Add cli & command to run the code server on the desktop (#163546)
Add cli & command to run the code server on the desktop
2022-10-13 15:02:42 +02:00
Tyler James Leonhardt a8108049ab
Allow extensions to use new API and it get included in Language Packs (#163493)
* Allow extensions to use new API and it get included in Language Packs

This leverages the l10n-dev package to analyze ts files for `l10n.t` calls.

* delete console.logs
2022-10-12 17:28:34 -07:00
Connor Peet a5e9b83d65
ci: fix wrong file in cli tests 2022-10-12 17:05:41 -07:00
Tyler James Leonhardt 342aa9c59a
Improvements to i18n (#163372)
* remove dead code from Transifex

* use @vscode/l10n-dev for XLF operations for extensions

* generated files

* more generated files

* remove dead code

* move l10n-dev to where gulp is

* generated
2022-10-12 14:10:57 -07:00
Connor Peet 6353f80f3d
Merge pull request #161640 from microsoft/build-integrated-cli
Update build process to include integrated CLI
2022-10-12 08:59:37 -07:00
Alexandru Dima 72a982d0d3
Fix typo in regex (#163404) 2022-10-12 00:08:09 -07:00
Tyler James Leonhardt 3e4e351816
Enforce ILocalizedString usage with f1 property via types (#162991)
* Enforce ILocalizedString usage with f1 property via types

* complete comment

* Visit all symbols when encountering a union type

* use ILocalizedString

* fix tests

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-10-11 21:24:43 -07:00
Connor Peet b42f25b50b
address pr comments 2022-10-11 08:30:43 -07:00
Connor Peet ebd59363f0
Merge branch 'build-integrated-cli-dev' into build-integrated-cli 2022-10-10 19:13:08 -07:00
Connor Peet dc69e22984
fix build 2022-10-10 15:59:55 -07:00
Connor Peet 191dc770d1
address pr comments 2022-10-10 10:40:01 -07:00
Connor Peet 1b11bc6724
address pr comments 2022-10-10 10:39:51 -07:00
João Moreno 8ea1dee83c
Revert "Revert "update inno_updater to 0.9.0 (#162933)" (#163156)" (#163178)
This reverts commit 8e1235ee25.
2022-10-10 06:54:07 -07:00
João Moreno 8e1235ee25
Revert "update inno_updater to 0.9.0 (#162933)" (#163156)
This reverts commit f4fb3f3e58.
2022-10-10 02:30:14 -07:00
João Moreno f4fb3f3e58
update inno_updater to 0.9.0 (#162933) 2022-10-07 14:00:58 +02:00
Matt Bierner 99e126b0b2
Pick up latest TS version for building VS Code (#162786)
Pick up latest TS for building VS Code
2022-10-06 12:08:45 -07:00
Connor Peet 18f743d534
address pr comments 2022-10-05 12:56:07 -07:00
Connor Peet b401701d87
address pr comments 2022-10-05 11:46:24 -07:00
Connor Peet cbc174dcad
Merge remote-tracking branch 'origin/main' into build-integrated-cli 2022-10-05 10:00:18 -07:00
Michael Rienstra 625fec97f2
Enforce yarn version (#162610)
* Enforce yarn version

Actually require >=1.10.1 and <2

* error when yarn >= 2
2022-10-05 05:22:33 -07:00
Tyler James Leonhardt d19445483e
use timeoutsec and log between irm and ea (#162695) 2022-10-04 14:12:53 -07:00
João Moreno 8da400cf70
make sure VSCODE_RELEASE works even if quality is frozen (#162556) 2022-10-03 03:06:08 -07:00
Tyler James Leonhardt 9cad027389
check artifact size after download and extraction (#162407)
* just log it for now

* add size check
2022-09-30 09:31:29 +02:00
João Moreno 9ec34a5b60
Revert "stop shipping build-only dependencies (#162172)" (#162254)
This reverts commit 582aa29f85.
2022-09-28 13:50:35 -07:00
João Moreno 582aa29f85
stop shipping build-only dependencies (#162172) 2022-09-28 06:20:58 -07:00
Ladislau Szomoru 7ff04babc6
Revert "Engineering - use specific image version (#160878)" (#162052)
This reverts commit 924d7622fa.
2022-09-28 09:49:59 +02:00
Matt Bierner c2a2ad4f63
Rename image-preview extension to media-preview (#162093)
Fixes #162092

Also removes `aac` from the list of supported audio formats
2022-09-27 21:01:14 -07:00
João Moreno 70a7ce4d1a
Auto releasing a build needs peer approval (#161981)
* make sure VSCODE_RELEASE has peer approval

* boom
2022-09-27 16:55:34 +02:00
João Moreno 43894c6ea0
add Cargo.toml for inno-updater (#161976) 2022-09-27 07:29:29 -07:00
Connor Peet 889fbd2f1b
add detection for integrated cli, verify 2022-09-26 07:22:58 +02:00
Connor Peet 07453efc00
cli: implement better self-updating
- Start separating a "standalone" CLI. This is a little awkward with clap-
  derive, but I got it working. Detection of whether the CLI _is_
  standalone is still todo.
- Remove the old ad-hoc update code for code-server, and use the update
  service instead.
- Fix some of the "permission denied" errors people got while updating
  before. We need to rename the old running binary, not just overwrite it.
2022-09-23 17:47:39 -07:00
Connor Peet a9bcb15b75
cli: run ci on pr 2022-09-23 14:31:37 -07:00
Connor Peet 665eb030a6
Merge remote-tracking branch 'origin/main' into build-integrated-cli 2022-09-23 13:33:35 -07:00
Connor Peet 9bcc88eafe
cli: get builds in order 2022-09-23 13:28:26 -07:00
Connor Peet c3ae579592
Merge pull request #161268 from microsoft/connor4312/import-cli
Initial import of code-tunnel code
2022-09-22 18:28:04 -07:00
Robo 0d5fbcc577
chore: use plugin executable for utility process on macOS (#161102)
chore: update app entitlements
2022-09-21 08:18:39 -07:00
Alexandru Dima 869fd7bbfb
Only do the /build/ folder check on OSS, where we don't mixin (#161381) 2022-09-21 01:59:57 -07:00
Alexandru Dima 7041b71cd6
Retire basic checks GH action (#161376)
* Add /build/ folder checks (just like GH action)

* Add more checks that were only present in the GH action

* Disable basic checks GH action
2022-09-21 00:58:06 -07:00
Benjamin Pasero 9db57e76e9
Build: bundle / concat entry points (#161161)
* perf - concatenate windows main files

* Revert "Revert "Use `esbuild` to bundle some CommonJS main files (#160957)" (#161118)"

This reverts commit 84c46b71a5.

* build - exclude server main files

* build - make concat a task that runs like the others

* some renames

* Avoid overwriting the nodejs closure require

* Revert "build - exclude server main files"

This reverts commit 736516624e.

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-09-21 00:38:44 -07:00
Alexandru Dima 0bc9f9b606
Add missing build file (#161373) 2022-09-21 09:10:35 +02:00
Benjamin Pasero 772289fd6a
tests - update playwright (#161367) 2022-09-20 22:07:05 -07:00
Connor Peet 5e2ce13287
Merge branch 'connor4312/import-cli' into build-integrated-cli 2022-09-20 09:12:03 -07:00
Connor Peet a9e38fe925
ignore rust code when doing hygenie check 2022-09-20 08:49:29 -07:00
Connor Peet 3762635fe1
move cli to top level 2022-09-20 08:42:44 -07:00
Benjamin Pasero ca745eea7c
tests - do not retryCountOnTaskFailure playwright (#161299)
* tests - do not `retryCountOnTaskFailure` playwright

* compile
2022-09-20 09:55:06 +02:00
Connor Peet e02895941d
build: include the integrated CLI in product builds 2022-09-19 23:16:19 -07:00
Connor Peet 3ca6d73169
exclude rust cli from linting/hygenie 2022-09-19 13:29:24 -07:00
Matt Bierner 687712b871
Pick up latest TS nightly for building VS Code (#161127) 2022-09-16 10:37:58 -07:00
Benjamin Pasero 84c46b71a5
Revert "Use esbuild to bundle some CommonJS main files (#160957)" (#161118)
This reverts commit 2179e52fb9.
2022-09-16 09:31:44 -07:00
Benjamin Pasero 42cbf7dde0
build - debug playwright install (#161099) 2022-09-16 06:52:48 -07:00
Tyler James Leonhardt 869733274b
Have createAsset not short circuit (#161030) 2022-09-16 06:34:58 -07:00
Benjamin Pasero 2179e52fb9
Use esbuild to bundle some CommonJS main files (#160957)
* ensure node.js `require` is captured

* optimize `main.js` and `cli.js`

* cleanup

* leave out bundled files

* drop package.json from userdata paths

* fix web task

* fix editor distro

* inline version into `product.json`

* also bundle server

* t

* actually do server too

* Keep bundling nls in editor worker

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-09-16 05:24:23 -07:00
Robo 22cbb8e958
chore: update electron@19.0.17 (#161027)
* chore: update electron@19.0.17

* chore: update API typings

* fix: compilation errors

* build: add libcups dependency
2022-09-16 12:41:52 +02:00
Matt Bierner 3c37a5a8d7
Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Benjamin Pasero cfc0119755
Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
2022-09-15 08:26:22 +02:00
Rob Lourens c717237d7c
Reenable a couple notebook smoketests (#159521)
* Remove vscode-notebook-tests in favor of an .ipynb in vscode-smoketest-express

* Update build folder

* Add build task to correct platform

* Build for smoke tests on other platforms

* Fix repo url and remove comment

* Just -media?

* Update darwin/win32 as well
2022-09-14 13:22:16 -07:00
Daniel Rosenwasser 0cbcb1b1ab
JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
Ladislau Szomoru 924d7622fa
Engineering - use specific image version (#160878) 2022-09-14 09:14:46 +02:00
Ladislau Szomoru 95caaea452
Engineering - Add timeout and retries to the task to download Electron and Playwright (#160490)
Add timeout and retries to the task to download Electron and Playwright
2022-09-09 10:47:29 +02:00
Johannes d6f5727021
also use SWC for extensions transpile 2022-09-07 11:18:53 +02:00
Johannes 87e54a0759
consume swc as libaray and wire up into the existing transpiler logic 2022-09-07 10:46:27 +02:00
Johannes d7fafc7ada
remove swc as executable task 2022-09-07 10:40:45 +02:00
João Moreno d868c444a8
Build: Properly verify signed macOS application bundle (#160056)
* properly test signed macos application

fixes #159873

* more checks

* hm
2022-09-05 07:54:37 +02:00
Johannes 2f390ceb5d
add missing JS file 2022-08-31 16:59:37 +02:00
Johannes 872e9dfc81
comments, todos 2022-08-31 14:56:23 +02:00
Johannes 52193cfc09
make to run buildWebNodePaths when using transpile-swc 2022-08-30 14:27:20 +02:00
Johannes a252938303
Merge branch 'main' into joh/swc 2022-08-30 14:14:22 +02:00
Benjamin Pasero 2ba046482d
bump esbuild@1.15.5 (#159533)
bump esbuild
2022-08-30 12:52:31 +02:00
Matt Bierner 5e92794be6
Re-enable running our eslint rules using ts-node (#159495)
Resubmission of #157532 with the following changes:

- Use `eslint-plugin-local` instead of `yarn` link to run our plugins
- Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`)
- Update all names to `local/`
2022-08-30 08:40:04 +02:00
Matt Bierner 71c216d91f
Fix lint errors in our npm scripts (#159501) 2022-08-29 15:35:23 -07:00
Matt Bierner 9e5248072a
Fix ts-node for eslint (#159483)
Bumps the cachesalt to make sure ts-node is installed
2022-08-29 20:51:12 +02:00
Matt Bierner 5b21c7f28b
Run our custom eslint rules using ts-node (#157532)
* Run our custom eslint rules using ts-node

Use `ts-node` to run our custom eslint rules.  This lets us delete the pre-compiled js. It also means you can don't have to compile the rules while editing them

As part of this change, I've also switched us to using an eslint plugin instead of a rulesDir. This is now the preferred way to ship custom rules

* Fix two more disables

* Move ts-node to project root

* Enable transpileOnly
2022-08-29 09:39:09 -07:00
Ladislau Szomoru 31acf4253d
Engineering - Disable Terrapin (#159441)
Disable Terrapin
2022-08-29 02:39:00 -07:00
Matt Bierner b5a1bb34e9
Pick up latest TS for building VS Code (#158420) 2022-08-26 23:00:38 +02:00
Johannes 46bab7505c
let builds use transpile-client-swc 2022-08-26 15:03:31 +02:00
Johannes 7ec1ebdd5f
* tweak createSwcClientStream to have async exec
* add `transpileClientSWC` and corresponding gulp task
2022-08-26 15:02:01 +02:00
Johannes 18e45ac6cd
don't use --copy-files options has it seems to break BOM 2022-08-26 11:58:36 +02:00