Commit graph

12896 commits

Author SHA1 Message Date
Joyce Er 65abd2b037
Add icon for Open on vscode.dev command (#158519) 2022-08-18 20:11:41 +02:00
Logan Ramos 67e628e18a
The quest to debug vscode.open continues (#158483) 2022-08-18 15:13:18 +02:00
Benjamin Pasero 032662071c
openIntegration test failure: openTextDocument, untitled closes on save (#157897) (#158482) 2022-08-18 14:56:50 +02:00
Johannes Rieken c592ef8e18
use "Incoming" and "Current" everywhere (#158478)
fixes https://github.com/microsoft/vscode/issues/156229
2022-08-18 14:21:06 +02:00
Johannes Rieken c0ade8bc81
joh/unknown lemming (#158460)
* make git's `openMergeEditor` user-facing command and show it for editors that have conflicts

also includes a workaround for an issue with untyped editor inputs... fyi @lramos15

* Patch matches

* Remove TODO

* set nowrap for white-space

fixes https://github.com/microsoft/vscode/issues/156402

Co-authored-by: Logan Ramos <lramos15@gmail.com>
2022-08-18 06:58:30 -04:00
Michael Lively 880fda6ed9 fix pasting image into newly created cell bug 2022-08-17 12:17:39 -07:00
Matt Bierner 129f5bc976
Use own calls to localize (#158372)
Fixes #156684
2022-08-17 10:27:29 -04:00
Daniel Imms 95d21cbc37
Merge pull request #157654 from microsoft/tyriar/fish_lang
Add .fish to shell script language
2022-08-17 07:06:08 -07:00
Johannes Rieken 9759525167
push workaround for https://github.com/microsoft/vscode/issues/157904 (#158368) 2022-08-17 14:40:36 +01:00
Joyce Er e1628628a8
Provide context on which repository is being cloned (#158324) 2022-08-17 00:11:28 +01:00
Matt Bierner 3393b785de
Bump server version (#158297) 2022-08-16 14:38:41 -04:00
Matt Bierner 720a61fc28
Fix markdown link diagnostics not updated when directories are renamed / deleted (#157956)
Fix markdown link diagnostics not updated when directories are renamed/deleted

Turns our that `createFileSystemWatcher` will not fire if a parent dir is renamed / deleted. See #60813

To fix this, I believe we have to create watchers for all parent directories too (or watch everything in the entire workspace)
2022-08-12 13:48:40 -04:00
Rob Lourens 8c2fd550a3
Notebook cell execute in Interactive Window Test Fails on MacOS (#157963)
* Notebook cell execute in Interactive Window Test Fails on MacOS
Fixes #157826

* Remove .only
2022-08-12 09:31:11 -07:00
Henning Dieterichs 7dd5f05b6e
Enable conflict marker decorators even if merge editor is enabled. (#157982) 2022-08-12 15:21:38 +02:00
Matt Bierner dfe145441a
Pick up TS 4.8 RC (#157960)
For #157527
2022-08-11 16:58:48 -07:00
Matt Bierner b731beeef4
Use notebook document uri for drop / copy paste (#157939)
Fixes #157938
2022-08-11 19:52:55 +01:00
Aaron Munger 74f8a781d0
Merge pull request #157923 from amunger/interactiveExecute
add parameter to Interactive Execute to specify resource
2022-08-11 11:20:12 -07:00
aamunger 694324e3ac
add parameter to Interactive Execute to specify resource 2022-08-11 10:45:24 -07:00
Benjamin Pasero c6bcc3fcbf
API command test fail on MacOS (for #157824) (#157885)
API command test fail on MacOS (fix #157824)
2022-08-11 09:57:19 -04:00
Benjamin Pasero a3067cbbc6
assert that closed is defined (for #157897) (#157901) 2022-08-11 06:46:19 -07:00
Matt Bierner 38ea5c22a6
Pick up new markdown LS version (#157843) 2022-08-10 18:16:24 -07:00
Ladislau Szomoru b2212a1090
Git - Fix more scenarios where the post commit command setting is not honoured. (#157804)
* Revert "Commit keyboard shortcut to honor the post commit command setting (#157617)"

This reverts commit fe946068ba.

* Fix more scenarios where the post commit command setting is not honoured.
2022-08-10 16:12:26 -07:00
Alex Ross f146031624
Update grammars (#157773) 2022-08-10 06:40:17 -07:00
Matt Bierner 460768a452
Update TS versions (#157550)
* Update TS versions

Update the bundled TS and build TS version

* Add explicit annotations

* Recompile JS
2022-08-09 11:26:24 -07:00
Michael Lively 38477bf5f5
change dir of cellAttachmentRenderer (#157671)
* change dir of cellAttachmentRenderer

* add new directories to `.vscodeignore`

* add the .js directories back in...

* hopefully now understanding `.vscodeignore`
2022-08-09 20:00:24 +02:00
Tyler James Leonhardt bcb31b9cfb
disable nls on the web for now (#157665) 2022-08-09 18:30:23 +02:00
Matt Bierner 8bf82819fc
Add experimental support for update markdown links on file moves/renames (#157209)
* Add experimental support for update markdown links on file moves/renames

Fixes #148146

This adds a new experimental setting that automatically updates markdown

Note that this needs a new version of the vscode-markdown-languageservice so the build is expected to break for now

* Pick up new LS version
2022-08-09 08:31:40 -07:00
Ladislau Szomoru 81e6a02c18
Git - Upgrade file-type package (#156411) 2022-08-09 11:30:49 -04:00
Daniel Imms 5c2cbe2b7d
Add .fish to shell script language 2022-08-09 08:19:27 -07:00
Ladislau Szomoru fe946068ba
Commit keyboard shortcut to honor the post commit command setting (#157617) 2022-08-09 11:14:56 +02:00
Matt Bierner 389938998f
Show error when markdown preview restore fails (#157566)
Fixes #155493
2022-08-09 09:55:40 +02:00
ChaseKnowlden 19d0675506
Add offline_access to list of default scopes (#157453)
Add a new scope to default scopes
2022-08-08 14:55:13 -07:00
Michael Lively 9225503c85
Support for pasting images into markdown notebook cells (#156847)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* document paste additions

* update condition to re-render cells, now includes metadata changes

* paste API working, debugging command added

* paste working with metadata. needs numbering, and cleaning upon delete

* paste screenshot works fully

* remove debugging command. Cleaning.

* notebook cells now re-render upon metadata changes

* changed name validity checking, remove unneeded function

* use _document for cell data, use snippet choice, dto fix

* return subscription, for loop, uri fix, alter metadata in-place, better snippet

* metadata fix, object.equals, fix cellAttRenderer metadata call

* added comment with source of encodeBase64

* gate mkdn image paste behind experimental setting
2022-08-08 13:57:49 -07:00
Matt Bierner 0103536a60
Apply editor-font-family to all code in notebooks (#157554)
Apply editor-font-family to all `code` in notebook

Fixes #146696

This matches what we do in the markdown preview
2022-08-08 20:59:16 +02:00
Tyler James Leonhardt d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 (#157530)
* rev version of vscode-nls to 5.1.0

* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt 49394cc44d
Enable translations for extension code for the web (#155355)
* Initial attempt

* alex feedback
2022-08-08 09:11:16 -07:00
Rob Lourens 8671778f8d
Fix notebook execution test failures (#157290)
* Fix notebook execution test failures
An error thrown in an event handler did not cause the test to fail, using DeferredPromise. Adjusting the api event to account for Unconfirmed vs Pending states. And accounting for onDidChangeNotebookDocument being fired multiple times during a test, causing the test to complete early while execution was still happening.
Fixes #157067

* Remove log
2022-08-05 11:07:20 -07:00
Benjamin Pasero 73fd3f1103
fix build (#157217)
* fix build

* fix compile

* flaky

* .
2022-08-05 09:16:20 +02:00
Matt Bierner 07e45c5a71
Fix package version (#157202)
Not sure why this was not caught by earlier builds
2022-08-04 21:40:06 -07:00
Matt Bierner b012216211
Fix markdown images having duplicate ids (#157177)
Fixes #153144
2022-08-05 06:31:42 +02:00
Tyler James Leonhardt d859b334cb
We only need to wait on the input box for un-supported environments (#157157)
we only need to wait on the input box for un-supported environments
2022-08-04 23:55:51 +02:00
Matt Bierner c5f857f0cf
Remove skipped webview tests (#157155)
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
2022-08-04 23:49:05 +02:00
Matt Bierner 68912bd844
Use 'import type' for '@jupyterlab/nbformat' (#157153)
This is a type only dev dep so we should prevent referencing it as a value
2022-08-04 23:46:53 +02:00
Matt Bierner 0c78644c6e
Use tabs to figure out when to report JS/TS diagnostics (#157117)
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
2022-08-04 10:46:56 -07:00
Raymond Zhao 9f80085795
Fix language-specific tab expansion and polish (#157035)
* Fix language-specific tab expansion and polish

Fixes #156075

* Add back check
2022-08-03 16:31:19 -07:00
Peng Lyu 5d4730dbec
Merge pull request #157029 from microsoft/rebornix/notebook-no-test-skip
No skip tests in notebook api/kernel
2022-08-03 14:48:09 -07:00
rebornix 336373dfc5
bring back kernel execute test 2022-08-03 10:14:45 -07:00
rebornix 82314b9ed5
remove outdated test 2022-08-03 10:08:02 -07:00
Michael Lively 61e8687fa3
Notebook Cells re-render upon changes to metadata (#156917)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* update condition to re-render cells, now includes metadata changes

* notebook cells now re-render upon metadata changes

* fix missing metadata update

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2022-08-03 09:46:12 -07:00
Matt Bierner 784de60319
Add activeWebviewPanelId context key (#156944)
Fixes #156942

This context tracks the id of the active webviewPanel
2022-08-03 07:03:33 +02:00
Peng Lyu 7833aade5a
Separate notebook kernel and api test (#156946)
* Separate notebook kernel and api test.

* no need to test reopen dirty document
2022-08-03 07:03:10 +02:00
Peng Lyu 418b944396
debt: move insert command towards unit tests. (#156929) 2022-08-03 01:42:53 +02:00
Matt Bierner 8b27dcb1f8
Pick up latest markdown language service (#156933) 2022-08-02 23:31:58 +02:00
Peng Lyu 4b551dab35
Turn on notebook document test. (#156932) 2022-08-02 23:20:00 +02:00
John Murray 7e400c7137
Provide valid markdown-specific default for editor.quickSuggestions setting (#156686) (#156689)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-08-02 13:51:41 -07:00
Matt Bierner e3267b75c6
Fix onDidDeleteMarkdownDocument not hooked up (#156913) 2022-08-02 22:18:08 +02:00
Matt Bierner 1097f3e440
Use finalized vscode-languageserver version (#156910)
Use finalized vscode-languageserver build
2022-08-02 15:51:07 -04:00
Matt Bierner 3a5a458643
Clear markdown diagnostics when file is closed (#156912) 2022-08-02 20:32:02 +02:00
Matt Bierner 424fe151f1
Add patch for enabling new TS plugins on web approach (#149186)
* Add patch for enabling new TS plugins on web approach

https://github.com/microsoft/TypeScript/pull/47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR

* Update for new files names
2022-08-02 20:00:22 +02:00
Peng Lyu fded572606
Re #155587. Move undo/redo to unit tests. (#156849) 2022-08-02 09:28:37 +02:00
Tyler James Leonhardt 13066d79e3
up timeout to 5min (#156846) 2022-08-01 17:15:52 -07:00
Matt Bierner cf43717e18
Pick up new md grammar (#156844)
Also updates themes to better handle https://github.com/microsoft/vscode-markdown-tm-grammar/issues/4
2022-08-01 17:13:55 -07:00
Matt Bierner f0434c0960
Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Peng Lyu f31a88e161
Remove move cell integration test (#156825)
* Remove move cell integration test

* 💄

* test didn't really run locally
2022-08-01 16:54:49 -04:00
Peng Lyu f4433141c7
Move off asPromise (#155920)
* Troubleshoot asPromise

* Update batch edit api

* Update workspace edit

* fix #156663

* 💄
2022-08-01 21:09:41 +02:00
Matt Bierner 97c8a97261
Include globally enabled TS Server plugins when reporting issues (#156510)
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
2022-08-01 10:44:46 -07:00
Matt Bierner 4eef7a94e1
Tell users about enabled TS plugins on crash (#156514)
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
2022-08-01 10:44:33 -07:00
Babak K. Shandiz 2150470804
🎁 Add option to disable script hovers in package.json files (#156752)
* ⚙️ Define `npm.scriptHover` configuration parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🌐 Add localized description for `npm.scriptHover` config parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🎁 Respect `npm.scriptHover` config parameter in `NpmScriptHoverProvider`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-08-01 09:43:31 -07:00
Alex Ross 12b08be500
Only use the commit in share link when upstream (#156658)
Fixes #156627
2022-07-29 12:30:05 +02:00
Michael Lively 6fbee10cc1 more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash 2022-07-28 11:53:51 -07:00
Tyler James Leonhardt 4017fd126f
Show quick pick when redirect fails to complete redirect to be more robust (#156515)
* show quick pick when redirect fails to complete redirect to be more robust

* matt feedback
2022-07-28 10:26:18 -07:00
Matt Bierner 06f8d52e37
Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Matt Bierner 00bb9bdefc
Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
Martin Aeschlimann 857412ab10
devcontainer schema: handle deprecated properties (#156425) 2022-07-27 20:27:47 +02:00
Alex Ross a3b712e04e
Create a insiders.vscode.dev link when I use insiders for sharing (#156436)
Fixes #156255
2022-07-27 10:55:08 -04:00
Matt Bierner 241c770203
Exclude esbuild files from build (#156362) 2022-07-27 09:32:07 -04:00
Ladislau Szomoru d01945923c
Git - Fix regression with Commit action button icon (#156417)
Fix regression with Commit action button icon
2022-07-27 13:11:07 +02:00
Ladislau Szomoru e210bbfea4
Git - fix edge case during rebase (#156410)
Fix blocking issue while resolving conflicts during rebase
2022-07-27 12:03:47 +03:00
Matt Bierner 9cf2fabdd6
Rename editor.dropIntoEditor.enabled setting (#156381)
Fixes #156344
2022-07-27 06:44:44 +02:00
Michael Lively 53c3028c47 add notebook-out to .gitignore 2022-07-26 12:29:23 -07:00
Michael Lively 2077ae5120 fix package.json/esbuild.js for files in publish 2022-07-26 12:19:27 -07:00
Matt Bierner cf145a83ac
Enable safe inline svg tags in trusted html (#156216)
Enable safe svg tags in trusted html

From cce00ac40d/src/tags.js (L124)
2022-07-25 16:32:10 -07:00
易良 fbdc848c29
fix: typos (#155310)
* fix: typos

* chore: revert formatting changes

* fix: Remove redundant blank lines
2022-07-25 15:41:30 -07:00
Martin Aeschlimann 0b7a99104d
theme-seti icon Laravel .blade.php lose php icon when installing blade related extension (#156204)
theme-seti icon Laravel .blade.php lose php icon when installing blade related extension. Fixes #153410
2022-07-25 16:35:30 -04:00
Raymond Zhao 52a71a1843
Make some Emmet settings language-overridable (#156184)
Fixes #156075
2022-07-25 20:00:36 +02:00
Martin Aeschlimann 361215a168
seperate out devContainer schemas for vscode & codespaces (#156170)
* seperateout devContainer schemas for vscode & codespaces

* fix for vscode schema
2022-07-25 18:17:23 +02:00
Matt Bierner 68cbaa708e
Pick up new version of markdown-language-server (#156010)
This fixes md diagnostics and links for multiroot workspaces
2022-07-24 22:22:03 -07:00
Matt Bierner a9b387204b
Add some additional logging to md server (#156007)
Logs watcher operations
2022-07-23 00:32:10 +02:00
Peng Lyu e6ad5f0a6f
Update ipynb yarn lock (#156004) 2022-07-22 23:26:14 +02:00
Michael Lively 9428c6650b
Merge pull request #155777 from Yoyokrazy/temp
Added support for jupyter attachment field, embedded image rendering in markdown notebook cells
2022-07-22 12:04:44 -07:00
ryuurock 42e79ca270
Update typescriptServiceClient.ts, fix naming errors (#155946)
Update typescriptServiceClient.ts

fix naming errors
2022-07-22 17:46:48 +00:00
Johannes Rieken b8876a2d60
enable merge editor by default (#155937) 2022-07-22 11:28:49 +02:00
Matt Bierner e2006a52da
Add npmignore to markdown server (#155898)
* Add npmignore to markdown server

* Update version
2022-07-21 16:21:57 -07:00
Matt Bierner b2daf1af82
Add MD server tracing and update diagnostics on files changes (#155797) 2022-07-21 10:07:06 -07:00
Johannes Rieken bbbae594da
show "Accept Merge" only for files currently under conflict. (#155822)
While the merge editor shows users can handle merge conflicts outside of it, e.g on the console via `git add <FILE>`. The merge editor should have this graceful and step one is to hide the "Accept Merge" command when the file isn't conflicting anymore

* Adds a git-context key that contains all resource-uri-strings under conflict
* Enable/placement of the Accept Merge command is driven by that
* some merge editor context key sugar
2022-07-21 13:25:23 +02:00
Angelo cef02dae8d
Contribute to html language server with a custom language. (#146731)
* Contribute to html language server with a custom language.

Fixes #146730

Signed-off-by: azerr <azerr@redhat.com>

* refactor out LanguageParticipants

* restart client on language selector change

* htmlLanguage -> htmlLanguageParticipants

* tune autoInsert wording

* tune autoInsert description

Co-authored-by: azerr <azerr@redhat.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-07-21 13:19:01 +02:00
Benjamin Pasero 6cad4b9494
skip test & 💄 (#155826) 2022-07-21 12:47:23 +02:00
Ladislau Szomoru ace330ba2c
SCM - Fixed a regression due to which post-commit commands were not being executed (#155824)
Fixed a regression due to which post-commit commands were not being executed
2022-07-21 12:25:15 +02:00
Matt Bierner 924dde5c1e
Documenting markdown LS (#155789) 2022-07-21 11:48:30 +02:00
Benjamin Pasero 477af8c842
skip flaky test (#152145) (#155809) 2022-07-21 11:46:51 +02:00
Ladislau Szomoru cd90b2b5ad
Git - Add telemetry comments (#155811)
Add telemetry comments
2022-07-21 09:34:19 +02:00
Ladislau Szomoru e0e7ad368e
Git - Enable action button while rebasing (#155744)
Enable action button while rebasing
2022-07-20 23:35:05 -07:00
Michael Lively eaf321d50d formatting 2022-07-20 16:12:32 -07:00
Michael Lively 63142212a1 remove md-it dependency, added undefined check to attachments 2022-07-20 16:10:54 -07:00
Michael Lively ff31f6b577
Update package.json 2022-07-20 15:01:40 -07:00
Michael Lively 3a23dda32c
removed commented code 2022-07-20 13:47:26 -07:00
Michael Lively d7b6596808 yarn.lock with yarnpkg instead of npm 2022-07-20 12:35:42 -07:00
Michael Lively 6a73a0d22d rm package-lock.json 2022-07-20 12:25:57 -07:00
Michael Lively 1b59f566bb rendering of attachment images complete via tokens 2022-07-20 12:23:37 -07:00
Michael Lively 735ead82f5 added attachment and metadata support back in... rebasing is scary 2022-07-20 12:23:37 -07:00
Michael Lively 3981a5804c added build stuff 2022-07-20 12:23:37 -07:00
Michael Lively 0fa857c9a1 okay now things are actually fresh and working 2022-07-20 12:23:24 -07:00
Ladislau Szomoru f19251a4ca
Git - Use GIT_EDITOR environment variable to suppress the git commit editor during rebase (#155748)
Use GIT_EDITOR environment variable to suppress the git commit editor during rebase
2022-07-20 17:52:56 +02:00
Ping 0b2c56eb7b
Fix #114461 (#151824)
suppress the editor during git rebase, fix #114461

Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
2022-07-20 15:03:43 +02:00
Martin Aeschlimann d0769c7e7f
[html] update service and fix url resolving (#155725) 2022-07-20 14:38:10 +02:00
Martin Aeschlimann 28be5d9906
Configurations ${WorkSpace} autocomplete broken after update (#155713)
Configurations ${WorkSpace} autocomplete broken after update. Fixes #155638
2022-07-20 08:01:52 -04:00
Johannes Rieken ce5d92e998
use commit-icon for description, tweak codicon font-size (#155714)
https://github.com/microsoft/vscode/issues/150863
2022-07-20 13:49:24 +02:00
Johannes Rieken 7cdaa57928
also default to opening merge editor when conflict is about adding (#155711)
fixes https://github.com/microsoft/vscode/issues/153737#issuecomment-1189357241
2022-07-20 12:36:08 +02:00
Matt Bierner 32f5e49082
Move MD diagnostics to language server (#155653)
* Move MD diagnostics to language server

This switches us to using the LSP pull diagnostic model with a new version of the language service

* Bump package version

* Delete unused file
2022-07-19 16:34:09 -07:00
Ladislau Szomoru 03c16c9c00
Git - The git.sync command should use the git.rebaseWhenSync setting (#155511)
The git.sync command should use the git.rebaseWhenSync setting
2022-07-18 18:38:58 +02:00
Ladislau Szomoru b3218963c4
Git - Do not show SmartCommit dialog when using "Commit All" (#155486)
Do not show SmartCommit dialog when using "Commit All"
2022-07-18 16:55:41 +02:00
Johannes Rieken 8bada27fdd
Merge pull request #155148 from microsoft/joh/double-barnacle
joh/double barnacle
2022-07-18 16:45:00 +02:00
Joyce Er 73b34320c1
Add ability to continue desktop edit session in vscode.dev 2022-07-15 15:51:51 -07:00
Martin Aeschlimann e225afee30
Add syntax highlighting for .env files without extensions (#155298)
Add syntax highlighting for .env files without extensions. Fixes #154111
2022-07-15 12:24:40 +00:00
Matt Bierner 394eaa9fa3
Fix md document links for untitled files (#155248) 2022-07-14 18:15:13 -07:00
Joyce Er a0c9ebe6b4
Disable chunking to prevent importScripts calls in web (#155226) 2022-07-14 18:55:38 +00:00
Johannes Rieken 1878583319
read REBASE_HEAD when rebasing, swap yours/theirs (label, sides) as well (#155208)
https://github.com/microsoft/vscode/issues/153737
2022-07-14 09:23:44 -07:00
Ladislau Szomoru ee18db8144
Sync Changes button - only show when local branch is ahead/behind the remote branch (#155192)
Only show Sync Changes button when local branch is ahead/behind the remote branch
2022-07-14 13:51:47 +00:00
Ladislau Szomoru 70a1ebd595
Git - Add events to IPostCommitCommandsProviderRegistry (#155051)
* Add events to IPostCommitCommandsProviderRegistry

* Pull request feedback
2022-07-14 10:46:57 +02:00
Johannes 0f0101be5f
use TabInputTextMerge in git extensions
For now only when checking for tabs, not yet for opening tabs
2022-07-14 09:41:54 +02:00
Ladislau Szomoru f6332bd86d
Git - Use cloud icon for remote branches (#155140)
Use cloud icon for remote branches
2022-07-14 08:55:29 +02:00
Matt Bierner 9ee8961347
Move MD references, rename, and definition support to md LS (#155127) 2022-07-14 08:32:27 +02:00
Matt Bierner 867acc336f
Remove references to finalized drop api (#155128) 2022-07-14 08:27:25 +02:00
Matt Bierner 50056f3e78
Finalize drop into editor api (#155102)
Fixes #142990
Fixes #149779
2022-07-13 12:54:52 -07:00
Matt Bierner bec36ce756
Move md path completions and document links to language server (#155100) 2022-07-13 12:49:37 -07:00
Ladislau Szomoru bc51adde6f
git - Add localization comment for Publish Branch action button (#155053)
* Add localization comment for Publish Branch action button

* Pull request feedback
2022-07-13 14:39:18 +00:00
Rich Chiodo 052d5b0027
Fix issue with kernel preselection being overridden by view state (#154968)
* Fix view state overriding selected kernel

* Add test to verify correct kernel is used
2022-07-12 18:03:49 -07:00
Matt Bierner 75e231ad82
Clean up document link resolve (#154959)
- Move vscode scheme normalization to the DocumentLinkProvider
- Remove extra function since we already recognize uri-like links
2022-07-12 15:55:21 -07:00
Matt Bierner 8f4d1a97f3
Clean up HtmlRenderingHook (#154961)
- Pass `HtmlRenderingHook` to hook
-  Rename register function to make it clear it is experimental
- Add docs
2022-07-12 11:27:47 -07:00
Raymond Zhao d627aa4606
Emmet: Add back trigger character arguments (#154940)
Fixes #154375
2022-07-12 09:15:01 -07:00
Ladislau Szomoru c7c0acd2ce
Git - Commit action button extension api (#154555) 2022-07-12 17:06:16 +02:00
Matt Bierner eeb8d49317
Move md workspace symbol search to language service (#154874)
* Move md workspace symbol search to language service

Also implements more of IWorkspace for the server

* Revert extra change
2022-07-12 10:04:25 -04:00
Alexander Fadeev 491a83446e
Add Makefile tests for upgraded grammar: comma, comment, shebang (#154625)
Add Makefile tests for upgraded grammar: comma, comment, shebang.

1. Add comma separator for function calls and conditions.
2. Escaping a comment with an odd count of backslashes (\#, \\\#).
3. Match debian/rules files based on shebang.

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-07-12 13:11:36 +02:00
Ladislau Szomoru acd1db24f2
Git - fix edge case with Windows mapped drives (#154342)
* Fix an edge case with computing relative path on Windows

* Refactor the fix
2022-07-12 12:20:41 +02:00
Johannes Rieken c46640d635
remove obsolete API proposal name from api-tests, fyi @Tyriar (#154902) 2022-07-12 11:35:56 +02:00
Matt Bierner c9bf4393d5
Rename drop API interface (#154876)
Makes the names more consistent
2022-07-12 11:33:13 +02:00
Matt Bierner 3a9292f23f
Remove extra files from build (#154875)
These server files should not be included
2022-07-12 11:31:43 +02:00
Aiday Marlen Kyzy 47a1f80c65
Adding keepLines feature to the settings (#154790)
* Adding the keepLines feature into the settings so the user can format while keeping the original line positions in json documents

* update service

* update dependencies

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-07-12 09:59:33 +02:00
Matt Bierner e02c71e3c6
Fix range of reference links (#154819)
Fixes #150921
2022-07-11 17:46:15 +02:00
Matt Bierner 82687c84ee
Add hook for extending built-in html renderer (#154316)
Fixes #153836

Lets extension register a hook that is invoked after the html element is renderered
2022-07-11 08:21:02 -07:00
Daniel Imms ded49a19ef
Merge branch 'main' into proposal-130231 2022-07-11 07:06:18 -07:00
Alex Ross 473c57e261
Update make grammar (#154789) 2022-07-11 12:14:40 +02:00
Ladislau Szomoru 5d18f94bb0
Git - Maintain spaces in the arguments (#154685)
Maintain spaces in the arguments
2022-07-11 02:28:57 -07:00
Ladislau Szomoru f2a475346f
Fix compilation error (#154699) 2022-07-10 07:50:17 -07:00
Daniel Imms 741b3cace8
Merge branch 'main' into proposal-130231 2022-07-10 07:40:11 -07:00
Matt Bierner 2b3912fa29
Fix markdown extension path (#154656)
Fixes #154645
Fixes #154653
2022-07-10 14:25:45 +02:00
jeanp413 318bdcc4cc Fix tests 2022-07-08 00:16:11 -05:00
Ladislau Szomoru eb2e5d8558
Git - Commit action button should use smart commit settings (#154169)
Consider smart commit settings when rendering the commit action button
2022-07-07 21:31:10 +02:00
Matt Bierner 2fb56e9d62
Move smart select and folding to md language server (#154334)
* Move smart select and folding to md language server

Also fixes a few minor issues:

- Don't log to web console
- Remove convert code since it is no longer needed
- Use correct extension id

* bump cache

* Bump package version

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-07-07 07:30:03 -07:00
Johannes Rieken e5f5a16b74
joh/issue145374 (#154360)
* enroll more places into `snippetWorkspaceEdit` proposal,

https://github.com/microsoft/vscode/issues/145374

* tweak API proposal for snippet edits, make this `WorkspaceEdit` only, remove old proposal bit

https://github.com/microsoft/vscode/issues/145374
2022-07-07 12:55:51 +00:00
João Moreno b4525a77fb
update yarn.lock (#154336) 2022-07-07 09:26:12 +02:00
Logan Ramos a20329d291
Switch extensions to 1DS (#154299)
* Move extensions to 1DS

* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Matt Bierner ad9675f099
Scaffold out basic markdown language server (#154293)
* Scaffold out basic markdown lsp

This scaffolds out a new markdown language server and then uses it to implement document symbols. After the change, the markdown extension will have the following structure:

- languageService — Where all the LSP language stuff will eventually land
- server — The actual language server. Consumes ` languageService`
- src — The current extension that launches the server and implements VS Code specific functions

* Adding build scripts

* a

* Use language service from github

* Remove ls build scripts

* Bump versions

* Only build ext

* Enable for web

* Fixing for browser
2022-07-06 16:03:24 -07:00
Connor Peet d88ab38f1b npm: remove icon from localization
For #153743
2022-07-06 10:57:16 -07:00
Peng Lyu f9f353c90b
support vscode.dev link generation in notebook editor (#154183)
* support vscode.dev link generation in notebook editor

* Update comments.
2022-07-06 17:53:12 +02:00
Ladislau Szomoru 6624aea0d0
GitHub - Add translation comment not to translate the $(github) codicon (#154269)
* Add translation comment not to translate the $(github) codicon

* Add an additional comment
2022-07-06 08:11:44 -07:00
Martin Aeschlimann ac74e9d093
[html] unresolved import error in embedded JavaScript (#154261)
[html] unresolved import error in embedded JavaScript #154002
2022-07-06 15:09:06 +02:00
Johannes Rieken 71c221c532
joh/theoretical quokka (#154157)
* add `SnippetController#apply(ISnippetEdit[])`

This replaces the initial ugly trick with a more sound implementation of arbitrary snippet edits. A snippet edit can cover disconnected regions, each will be applied as separate text edit but everything will become a single `OneSnippet` instance

* add integration test for SnippetString-text edit inside workspace edit
2022-07-05 12:30:01 -07:00
Matt Bierner f6271dd82e
Fix angle bracket path completions for link defs (#154182)
Fixes #153866
2022-07-05 11:55:20 -07:00
Matt Bierner fc0bd9d377
Remove reliance on document.lineAt (#154191)
* Remove reliance on document.lineAt

This helps aligning more with the LSP types: https://github.com/microsoft/vscode-languageserver-node/issues/146

* Strip newline
2022-07-05 11:52:47 -07:00
Alex Ross 7b69a3c4e1
Update grammars (#154099) 2022-07-05 09:53:51 +02:00
Ladislau Szomoru 57609a19da
Git - Update commit button icon and tooltip based on branch protection (#154101)
Update commit button icon and tooltip based on branch protection
2022-07-04 20:18:16 +02:00
Henning Dieterichs 451ae1ffa3
Merge branch 'main' into feature/support-angle-bracket-matching-in-typescript 2022-07-04 17:17:14 +02:00
Ladislau Szomoru 32406a7157
Debt - Prevent icon translations (#154094)
Prevent icon translations
2022-07-04 14:37:52 +00:00
Henning Dieterichs 8c72572c79
Merge pull request #153917 from microsoft/joh/issue153288 2022-07-04 10:57:29 +02:00
João Moreno 2fcd34a41b
Fixes #148568 (#154008)
fixes #148568
2022-07-04 07:41:54 +02:00
Raymond Zhao 623cde6b38
Disable inline completions by default for Emmet (#153926)
Ref #139247
2022-07-01 16:20:19 +00:00
Johannes fb97ffc160
be tolerant to other events happing but still enforce that the expected events are there
fixes https://github.com/microsoft/vscode/issues/153288
2022-07-01 15:39:51 +02:00
Alex Ross 48fef0c1da
Share link from File Menu shouldn't include active file (#153911)
Fixes #153537
2022-07-01 15:04:12 +02:00
Ladislau Szomoru 53c752ac8a
Git - Disable commit button while merge is in progress (#153890)
Disable commit button while merge is in progress
2022-07-01 02:56:29 -07:00
Matt Bierner 0b3574dcef
Update id of markdown-it renderer (#153876)
Fixes #153873
2022-06-30 23:19:49 +00:00
Matt Bierner e44361365e
Don't include reference links that are inside other links (#153864)
Fixes #150921
2022-06-30 15:43:31 -07:00
Matt Bierner bbce24d8bb
Handle fs error in markdown path completions (#153869)
Fixes #153867
2022-06-30 22:32:32 +00:00
Ladislau Szomoru b18f9e0630
Git - Do not show Sync Changes and Publish Branch action button when commit is in progress (#153821)
Do not show Sync Changes and Publish Branch action button when commit is in progress
2022-06-30 07:27:42 -07:00
Ladislau Szomoru cf532ac7db
Git - Tweak the git.useEditorAsCommitInput setting description (#153794)
* Tweak the setting description

* Update extensions/git/package.nls.json

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-06-30 06:42:23 -07:00
Ladislau Szomoru 1230b7c300
Git - "Commit & Push" command now publishes the branch if there is no tracking remote (#153749)
"Commit & Push" command now publishes the branch if there is no tracking remote
2022-06-30 02:12:31 -07:00
Martin Aeschlimann 257bb1ae83
Update seti for the gitcommit language (#153711) 2022-06-29 21:40:21 +02:00
Ladislau Szomoru 6ca8db83e7
Git - Disable undo last commit command while commit is in progress (#153739)
Disable undo last commit command while commit is in progress
2022-06-29 18:45:21 +00:00
Rob Lourens 50e1886048
Fix slow integration test (#153735)
Fixes #152886
2022-06-29 18:22:29 +00:00
Ladislau Szomoru 8045df1b94
Git - Add commands to the editor title to accept/discard commit message (#153692)
Add commands to the editor title to accept/discard commit message
2022-06-29 14:00:09 +00:00
Johannes Rieken 7aec222831
joh/issue150862 (#153677)
* execute `workbench.view.scm` to reval SCM view after accepting merge

fixes https://github.com/microsoft/vscode/issues/150862

* only reveal viewlet when stage/accept was done
2022-06-29 12:20:49 +00:00
Johannes Rieken bd24f72d42
fix 153492 (#153667)
* enable "accept merge" for merge editor only
* close merge editor before staging file, only stage file when editor has been closed

fixes https://github.com/microsoft/vscode/issues/153492
2022-06-29 14:08:09 +02:00
Alex Ross 1634eaec83
Share link shows with untitled document (#153671)
Fixes #153544
2022-06-29 14:02:34 +02:00
Ladislau Szomoru a424998dfd
Git - Action button precedence (#153662) 2022-06-29 12:48:22 +02:00
Harald Kirschner 56cade24a3
Make the guided git.missing welcome view default (#149668) 2022-06-29 01:14:39 -07:00
Andrew Branch 1d16e313d6
[typescript-language-features] Add setting for autoImportFileExcludePatterns (#153160)
* Add setting for autoImportFileExcludePatterns

* Add TS 4.8 to message
2022-06-28 16:43:24 -07:00
Ladislau Szomoru e773c97507
Git - commit action button does not appear on the initial commit (#153605)
Fix #153507
2022-06-28 14:07:16 -07:00
Ladislau Szomoru adecb6b529
Git - fix secondary action localization (#153604)
Fix #153503
2022-06-28 20:46:03 +00:00
Bryan Lee fac840f22c Add support for angle bracket matching and colorization in Typescript 2022-06-29 01:59:31 +08:00
Ladislau Szomoru 75b3fd5253
Git - Remove icons from branch picker to address regression (#153433)
* Remove icons from branch picker to address regression

* Fix create branch from issue

* Pull request feedback
2022-06-28 14:12:08 +02:00