Commit graph

240 commits

Author SHA1 Message Date
Matt Bierner 87c24f2b26 Fix markdown preview csp failure. Fix #27156 2017-05-23 11:57:07 -07:00
Matt Bierner 7403245d3d Show Warning When a markdown.styles fails to load (#27105)
Fixes #8488

**Bug**
Currently there is no indication in the markdown preview when a `markdown.styles` element fails to load

**Fix**
Show an alert then a stylesheet does not load
2017-05-22 18:30:24 -07:00
MaruyamaTomoki 3e65e255ab Markdown preview support the UNC path files. (#26710) 2017-05-22 15:29:25 -07:00
Jan Niklas Hasse 146c76df36 Use pre-#25570 fonts as a fallback for system-ui (#26912)
Workaround for:
https://bugs.chromium.org/p/chromium/issues/detail?id=724393
2017-05-22 11:57:54 +02:00
Kaide Mu 09c97bca0f Markdown: Capture right parenthesis as part of url (#26449)
* Capture right parenthesis as part of url

* Update markdown link pattern

* Fix link highlighting when there is nested img and link href
2017-05-18 22:06:27 -07:00
Matt Bierner 799fa528db Load script async in markdown preview 2017-05-17 17:39:00 -07:00
Matt Bierner 405271c17d Move getting active line out of inner openTextDocument 2017-05-16 16:57:26 -07:00
Matt Bierner 087a2d2f24 Default to not updating scroll position if no valid editor is found. Part of #25910 2017-05-16 14:05:10 -07:00
Daniel Imms f8bd850747 Merge pull request #25570 from jhasse/system-ui
Use Chromium's new system-ui font alias
2017-05-15 13:20:56 -07:00
Jan Niklas Hasse 45d93e9325 Use Chromium's new system-ui font alias
https://bugs.chromium.org/p/chromium/issues/detail?id=654679

Fixes #10144.
2017-05-10 13:44:12 +02:00
Matt Bierner 4f4a663a60 update highlight js version 2017-05-10 00:03:42 -07:00
Matt Bierner 7d2dea4e45 Add "Include" to extension TSConfig Files (#25860)
**Bug**
Most VSCode extensions currently specify `"exclude"` in their `tsconfig.json` but not `"include"`. This may result in extra files being included in each project

**Fix**
Add  `"include": ["src/**/*"]` to all extension tsconfig files
2017-05-05 11:37:59 -07:00
Bradley Meck d6c61a0e12 Add .mjs to known JavaScript file extensions (#25747)
Also add .es6 in missing places
2017-05-04 16:21:08 -07:00
Matt Bierner d13f3e79c8 Fix markdown preview no longer marking selection Fixs #25802 2017-05-04 09:14:34 -07:00
Matt Bierner 36ce3d156f Show header level in markdown Fixes #25574 2017-05-02 13:38:01 -07:00
Matt Bierner 891bb7680f Update markdown wordwrap for new wordwrap settings. Fixes #25357 2017-04-26 22:27:28 -07:00
Benjamin Pasero b34f17350f Un-allowed double quoted imports (for #25451) 2017-04-26 19:13:12 +02:00
Martin Aeschlimann 2c70320d48 [html] update html grammar 2017-04-25 23:40:28 +02:00
Matt Bierner e105d5cc99 Fixes #20470 2017-04-21 15:59:52 -07:00
Matt Bierner 740f662023 Allow markdown security setting for single file opens Fixes #24749 2017-04-19 22:31:50 -07:00
Matt Bierner efd3efcb62 Added markdown trace option for debugging user issues Fixes #24983 (#24985) 2017-04-18 18:57:01 -07:00
Ramya Achutha Rao 84af63a933 Increment version of vscode extension telemetry module 2017-04-18 14:46:35 -07:00
Matt Bierner 200c4d1057 Fix Markdown Preview Updating on Zoom / Unrelated Config Changes (#24809)
Fixes #24808

**bug**
Markdown preview updates when you zoom. The root cause is that previews are updated whenever the config is changed.

**Fix**
Extract preview config to its own well defined object. Only update the preview when the keys we care about in the config change
2017-04-14 15:43:32 -07:00
Alex Dima aca01f2daa Fix build hygiene issues 2017-04-14 14:08:52 +03:00
Matt Bierner c7c350a68a Small formatting cleanup in markdown 2017-04-13 15:26:32 -07:00
Dominic Valenciana e60ea34adc Nested code lines now no longer display the hover border left. (#24686)
* Nested code lines now no longer display the hover border left.

* Added fix for both light and hc themes.
2017-04-13 11:05:35 -07:00
Matt Bierner 0656b2b090 Update markdown grammar to allow better injection into unknown fenced code blocks 2017-04-11 17:35:28 -07:00
Matt Bierner e4b5586557 Ensure we use an encoded URI for the markdown styles 2017-04-11 15:18:16 -07:00
Matt Bierner f93afc56ce Fix Markdown style paths possibly being handled incorrectly on windows Fixes #3613 2017-04-11 15:16:40 -07:00
Matt Bierner e392265ce1 Switch md button to open to side by default
Fixes #21511
Fixes #23922

Changes the default markdown toolbar item to open the preview to the side of the current file as requested by #21511

Also updates the single file preview icon slightly to better differentiate it from the diff icon
2017-04-10 17:43:02 -07:00
Matt Bierner 11aba2dc61 Document enableExperimentalExtensionApi for insiders 2017-04-10 17:14:42 -07:00
Matt Bierner 736e09ab7c Use load event listener instead of onload in markdown preview 2017-04-10 17:14:42 -07:00
Matt Bierner 96b49f6f7d Tweak HTML Preview Styling (#24280)
Two changes:

* Changes the logic from 41467b74b7 to make the padding customizable. The default 20px padding is preserved, but now preview can customize if they want to use it or not. This allows html preview page background colors to correctly fill the entire frame.

* Remove Writing the `_defaultStyles` to the root of the webview elment. These are only needed inside of the iFrame itself
2017-04-10 11:03:43 -07:00
Matt Bierner 8fbad6ed40 Update some Markdown Snippets to Surround Selected Text
Fixes #1307

Updates a few markdown snippets, such as bold or italic, to surround the selected text instead or replacing it entirely
2017-04-06 18:17:39 -07:00
Matt Bierner 97a77a0eb3 Add marker class to markdown preview body to allow better css styling overrides 2017-04-06 17:34:04 -07:00
Matt Bierner 81f06c8605 Split markdown security selector into own file 2017-04-04 19:32:36 -07:00
Matt Bierner 6a34076761 Update default fonts used in markdown preview Fixes #15545 2017-04-04 16:24:53 -07:00
Matt Bierner 16876b257d Revert to using full uri for markdown scroll sync 2017-04-04 16:08:57 -07:00
Matt Bierner 8254b313f1 Further tweaks to markdown scroll sync paths 2017-04-04 15:02:35 -07:00
Matt Bierner 1d876bbc67 Fix a few potential file path casing issues for markdown preview 2017-04-04 14:51:02 -07:00
Richard Min 9875ae1077 Support ... terminating Yaml FrontMatter (#23195)
* FrontMatter rendered properly on markdownEngine

* FrontMatter terminates for 3 - or .

* Regex applied on both files for markdown
2017-03-24 19:56:53 -07:00
Matt Bierner 0185e327ab Extract markdown preview strings to constant 2017-03-23 22:31:43 -07:00
Matt Bierner 7bc40aace8 Prototype allowing scripts to be contributed to markdown preview 2017-03-23 22:29:34 -07:00
Matt Bierner 105e5f2ea8 Allow data font sources in markdown preview 2017-03-23 20:06:10 -07:00
Matt Bierner 00187b0065 Add font-src csp rule for default markdown content to allow custom fonts 2017-03-22 12:59:04 -07:00
Matt Bierner 4f8e68b814 Second prototype of markdown extensions (#22836) 2017-03-20 11:16:18 -07:00
Matt Bierner eb0a05f7b5 Fix return 2017-03-16 17:49:22 -07:00
Matt Bierner 09ec3557c8 Prototype Allowing Extensions to Extend the Builtin Markdown Extension (#22421)
* Prototype Allowing Extensions to Extend the Builtin Markdown Extension

**Problem**
There have been requests for adding new functionality to the markdown extension preview, such as supporting rendering of math or other syntax in the preview. The only current solution to this is create an extension that provides its own markdown preview. This results in inconsitent behavior with our markdown preview and is not a very scalable approach. We would like to find a way to allow users to add these extensions to our markdown preview without bundling the extensions in the preview itself.

**Fix**
Prototypes a new contribution point that extensions can use to extend the vscode markdown extension. Three types of extensions are possible: adding stypes to the preview, adding scripts to the preview, and extending the markdown it renderer.

My current approach defines the contributed markdown extensions in the package.json using a structure like this:

```
  "contributesTo": {
    "vscode.markdown": {
      "plugins": [
        "./out/math"
      ],
      "scripts": [],
      "styles": [
        "./media/math.css"
      ]
    }
  }
```

We could change the structure here. This design uses a pull model where markdown extensions are looked up by the vscode.markdown extension itself.

The other approach for extension registration would be to use a push model. This would have the vscode.markdown extension export an api that each markdown extension would invoke to register new scripts/styles/plugins. I may switch over to this model but was interested in seeing what a more declarative approach would look like. Let me know if you have any thoughts one way or the other.

The downside of allowing extensions like this is that they can completely change how the markdown preview looks and works. There is no well defined API for restricting what extensions can do like we have with VScode.

* Use extensionDependencies

* Remove example extension

* Added gating and activation event
2017-03-16 17:27:39 -07:00
Matt Bierner 31d0799fd8 Fix Markdown TOC Provider for Invalid References (#22553)
Fixes #22494

**Bug**
References without a definition can cause the markdown table of contents provider to break

**Fix**
Pass in an empty environment to markdown-it `parse` to prevent the null dereference on invalid links.
2017-03-13 10:49:59 -07:00
Matt Bierner 3b7329eab8 Fix markdown document link highlighter for empty links 2017-03-10 16:37:59 -08:00