Commit graph

102118 commits

Author SHA1 Message Date
David Dossett 77381abe36
Swap list/tree icons to reflect current state instead of target state (#164835)
* Swap search result tree/list view icons

* Swap SCM list/tree view icons
2022-10-28 11:46:04 -07:00
Matt Bierner 220efdc347
Defer creation of monaco-icon-description-container (#164659)
We don't need to create the `monaco-icon-description-container` container until the description is actually needed. In many cases it is never filled in, so we can skip creating this empty node
2022-10-28 10:13:15 -07:00
Matt Bierner 3007d54230
Use IAction instead of Action for search item action (#164844)
For actions that are static, it is better to use `IAction` instead of `Action`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar). It also means you don't have to dispose of the action

This small optimization is useful here because we create one of these actions for every search item in the list as you scroll
2022-10-28 10:10:28 -07:00
Johannes Rieken cedf7a212c
avoid object-spread in perf-critical code, use Object.assign-instead (#164892) 2022-10-28 18:43:51 +02:00
Johannes Rieken 837b4525ec
💄 use event naming conventions for EmitterOptions (#164890) 2022-10-28 17:22:48 +02:00
Ladislau Szomoru 227f912450
💄 Diff decorators - remove registerThemingParticipant (#164889) 2022-10-28 17:02:32 +02:00
Robo f56598fc18
chore: update electron@19.1.3 (#164882)
* chore: update electron@19.1.3

* fix: update api name
2022-10-28 23:08:21 +09:00
Johannes Rieken cf223e2201
debt - extract outline actions and outline interfaces into separate files (#164887) 2022-10-28 10:07:33 -04:00
Johannes Rieken 8a3870e442
perf - ignore new listeners when leakage threshold is exceeded by far (#164885) 2022-10-28 10:06:15 -04:00
Johannes Rieken e077624c97
* force the use of InstantiationType * mark all standalone editor services as eager * mark remaining extension host services as eager (#164883)
* force the use of `InstantiationType`
* mark all standalone editor services as eager
* mark remaining extension host services as eager
2022-10-28 10:05:48 -04:00
Ladislau Szomoru 67b8c25157
Commit Action button polish (#164746) 2022-10-28 15:23:19 +02:00
Ladislau Szomoru c21a6a0ecd
💄 Banner - remove registerThemingParticipant (#164879) 2022-10-28 14:20:11 +02:00
Ladislau Szomoru f09c4124a2
Engineering - adopt l10n for git-base/git/github extesions (#164566)
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
2022-10-28 11:27:08 +02:00
Matt Bierner 8cc0246a78
Use simple IAction instead of Actionin quick input (#164842)
For actions that are static, it is better to use `IAction`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar)

This is helpful in the quick input list as we need to render elements rapidly while scrolling
2022-10-28 11:26:36 +02:00
Robo 4236d5c19d
chore: update electron@19.1.3 (#164864) 2022-10-28 11:04:35 +02:00
Ladislau Szomoru c7647cd307
Engineering - Add quality in the build name (#164855)
Add quality in the build name
2022-10-28 10:01:45 +02:00
Ladislau Szomoru 824fac7e18
Engineering - Empty commit (#164850)
Empty commit
2022-10-28 08:39:10 +02:00
Matt Bierner 6a10de5508
Skip clear if there is nothing in the actionbar list (#164839) 2022-10-27 20:18:28 -07:00
Matt Bierner 12ada73bf9
Disable markdown insert link commands in readonly editors (#164820)
Disable insert link commands in readonly editors
2022-10-27 23:52:05 +02:00
Matt Bierner 3544aabd5a
Fix markdown document deleting (#164829)
Fixes #164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not
2022-10-27 21:49:05 +02:00
Matt Bierner 0570a7678d
Use posix path for markdown links (#164822)
Fixes #164782
2022-10-27 19:21:03 +02:00
Matt Bierner 122c13d31a
Bump distro (#164821) 2022-10-27 19:09:27 +02:00
Rob Lourens 98f401e8b9
Fix .ipynb extension name capitalization (#164817)
Towards microsoft/vscode-jupyter#11773
2022-10-27 18:05:28 +02:00
Logan Ramos 2ada565d06
Quick check to circumvent regex in many cases (#164815)
* Quick check to circumvent regex in many cases

* Fix logic
2022-10-27 17:41:59 +02:00
Johannes Rieken b7bbdc424f
make sure startup.resource.perf doesn't contain paths (#164812)
* make sure `startup.resource.perf` doesn't contain paths

https://github.com/microsoft/vscode/issues/164810

* use posix.basename...
2022-10-27 17:18:12 +02:00
Johannes Rieken 2f88e15874
fix name of profile tmp-file (#164805) 2022-10-27 15:24:07 +02:00
Henning Dieterichs 37f16a84a1
Fixes #163931 (#164802) 2022-10-27 14:53:23 +02:00
Alexandru Dima ba91a81c16
Always patch the npm registry in yarn.lock files and compute the node modules cache key after having patched them (#164795) 2022-10-27 12:31:15 +02:00
Alexandru Dima 0f2285c3e9
Don't ship yarn.lock file with the markdown extension (#164794) 2022-10-27 12:09:38 +02:00
Joyce Er 9ad069358e
Store edit session before prompting to select edit session destination (#164780) 2022-10-27 06:23:31 +02:00
Matt Bierner 1316bf789f
Rework markdown update link glob (#164766)
* Rework markdown update link glob

Fixes #164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes
2022-10-27 01:45:45 +02:00
Matt Bierner d2f8ae6cce
Clean up a few markdown setting descriptions (#164765)
Clean up wording and make sure we use `Markdown` uppercase
2022-10-26 16:29:06 -07:00
Matt Bierner d1af68711d
Pick up latest markdown LS (#164763)
Includes a few more fixes for link update on rename
2022-10-27 00:39:58 +02:00
Matt Bierner 7060fb81dd
Shorten markdown link button titles (#164764)
Fixes #164556
2022-10-27 00:39:30 +02:00
Raymond Zhao 54bd3cca95
Add min-height to work around clipping (#164759)
Fixes #164602
2022-10-27 00:25:02 +02:00
Peng Lyu 153f5c62c0
Fix #164715. Turn cell into editing mode when there is a selection. (#164758) 2022-10-27 00:16:26 +02:00
Matt Bierner 5f87632829
Fix markdown server not updating documents properly on folder rename (#164752)
Fixes #164562
2022-10-26 14:48:20 -07:00
Martin Aeschlimann 70998c096d
tunnel --name should rename previous tunnel (#164753)
* tunnel --name should rename old tunnel

* fix clippy warning
2022-10-26 14:44:57 -07:00
Alexandru Dima 83a4466305
Do not adjust y offset when the mouse is below the last line (#164750)
Fixes #164131: Do not adjust y offset when the mouse is below the last line
2022-10-26 23:07:58 +02:00
Alexandru Dima 9e0b95f081
Use border-radius: 2px (#164747)
Fixes #164555: Use `border-radius: 2px`
2022-10-26 22:34:46 +02:00
Peng Lyu 851a0dad5d
Merge pull request #164667 from microsoft/issue163133
Do not interrupt if there are no affected cells
2022-10-26 11:58:45 -07:00
Peng Lyu 09e3248f40
Fix #164704. comment thread memory leak. (#164734)
* Fix #164704. comment thread memory leak.

* Dispose first.

* spell check
2022-10-26 20:42:39 +02:00
Peng Lyu b39fd56213
Re #164715. Better error handling of notebook opening (#164737) 2022-10-26 20:30:49 +02:00
Rob Lourens f45dffcd1f
Move log message outside of 'if' block so I have confirmation that smoething happened 2022-10-26 11:29:35 -07:00
Sandeep Somavarapu 942cc4b3a7
Fix #162439 (#164719)
* Fix #162439

* better fix and also add tests
2022-10-26 10:45:08 -07:00
Sandeep Somavarapu 002db8f362
Fix #162240 (#164723) 2022-10-26 18:48:44 +02:00
Sandeep Somavarapu e145a12888
Fix #163163 (#164721) 2022-10-26 09:37:06 -07:00
Alex Ross 55ebe5e93d
Allow action labels to be long in comment header (#164614)
* Allow action labels to be long in comment header
Part of #164288

* Better fix
2022-10-26 16:55:06 +02:00
Logan Ramos f6a08e816d
Transform ext host log URI on remote side (#164712)
* Transform ext host log URI on remote side

* Fix mistype
2022-10-26 10:37:42 -04:00
Sandeep Somavarapu f7a53c85c7
Fix #164617 (#164717) 2022-10-26 16:14:39 +02:00