* draft trusted workspace service / model
* renaming
* add request model and action
* err fix
* add request handlers with mock actions
* some quick fixes
* adding badge icon to activity bar gear
* Add Statusbar item to indicate trust
* Cleanup code
* Add background color
* Use theme color for the status background color
* adding basic editing experience
* observe trust with startup tasks
* Extension enablement
* Add capability to provide a custom message
* Remove old actions
* explorer: if you can not undo, pass undo to editor
fixes#111630
* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689
* Fixed compilation error
* Handle extension uninstall
* Handle extension install
* Ability to prompt when state is untrusted
* Do not change state is the modal dialog is dismissed or the Cancel button is pressed
* Refactored enablement code
* Prompt when installing from VSIX
* Prompt when installing from the Gallery
* Move file into the browser folder
* fixes and polish
* restructure workspace contributions
* restructure actions and use confirmations
* Initial draft of the proposed APIs
* Added stubs for the proposed api
* Trusted Workspace proposed API
* Fix a regression introduced by merge
* status bar indicator improvements
* remove helper command as we now have hooks
* verbose messaging for the immediate request
* add indication to global activity icon of pending request
* try personal title
* Add configuration setting
* Add additional extension actions
* Fix contributions
* Removed context key that is not needed
* Fixed issue with the dialog
* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016
* Fixes#115221: update emoji tests
* Give a higher priority to language configuration set via API call (#114684)
* debug console menu action polish
* Avoid the CSS general sibling combinator ~ for perf reasons
* more notebook todos
* Use label as tooltip fallback properly
Part of #115337
* Fixesmicrosoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`
* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364
* simplify map creation, fyi @bpasero
* Fix#114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)
* fix multiple save dialogs appearing on Windows when spamming Ctrl+S
* remove old fix and instead keep track of windows with open dialogs in the dialogMainService
* keep initialisation of activeWindowDialogs in constructor
* remove unused variable
* some changes
* queue dialogs based on hash of options
* simplify structure, fix comment typo
* Apply suggestions from code review
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* remove unnecessary async/await for aquireFileDialogLock method
* don't acquire file dialog lock for message boxes
* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue
* Apply suggestions from code review
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* 💄 dialog main service locks
* debt - adopt some ? operator
* Better hiding of custom hover in icon label
* Limit to 8ms (120fps)
* more API todos for notebooks
* 💄
* Update grammars
* chore - group notebook specific api proposals together
* added unreleased fixes to endgame notebook
* Add changes back to the modal dialog
* Add back the workspace trust proposed APIs
* Adjust dialog buttons
* Standardize on WorkspaceTrust name across interfaces, classes, variables
* Renamed some of the missing keys
* Add TestWorkspaceTrust stub and fix failing tests
* Add requiresWorkspaceTrust property to fix test failure
* remove notebook change
Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
This workbench service handles opening external uris. Unlike the core OpenerService, it also has logic for configuring a default opener and prompting if multiple openers are availble for a given uri
* WIP -Getting Started Registry
* Initial idea of how registry/service will work
* Getting started with Getting Started
* Add telemetry and touch up enablement flag
* Add contrib as startup editor
* Move to allowing static Getting Start blob
* No newline
* Remove unused enum
* chore: bump electron@9.0.5
* remove exploration config
* fix compile error
* fix compile error
* crashReporter has to be called only once before app ready
* chore: bump electron@9.1.0
* enable LayoutNG
* fix cron schedule
* allow disabling appcenter crash reporting
* set additional crash reporting parameters
* start crashreporter for child process on linux
* setup crash parameters only once
* remove unused crashReporter.guid
* address review feedback
* reuse argv.json for storing crash reporter id
* remove trailing commas
* update localized name
* update argv based on telemetry optout
* update initial config based on setting
* fix conditional errors
* remove telemetry.enableCrashReporter
* move default crash reporter config to electron-main
* update comment for ext host crash reporting
* set default value for configuration
* some 💄 changes
* address review feedback
* do not use ES7 features in JS yet
* add app.focus({ steal: true }) usage
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
For #82718Fixes#52846
This adds a newly proposed codeActions contribution point. For details, see #82718
This change also makes the intellisense for the `editor.codeActionsOnSave` property dynamic by using the new contribution point
* Custom Editor exploration
For #77131
Adds a prototype of custom editors contributed by extensions. This change does the following:
- Introduces a new contribution point for the declarative parts of a custom editor
- Adds API for registering a webview editor provider. This lets VS Code decided when to create a webview editor
- Adds an `openWith` command that lets you select which editor to use to open a resource from the file explorer
- Adds a setting that lets you say that you always want to use a custom editor for a given file extension
- Hooks up auto opening of a custom editor when opening a file from quick open or explorer
- Adds a new extension that contributes a custom image preview for png and jpg files
Still needs a lot of UX work and testing. We are also going to explore a more generic "open handler" based approach for supporting custom editors
Revert
* Re-use existing custom editor if one is already open
* Don't re-create custom editor webview when clicking on already visible custom editor
* Move customEditorInput to own file
* First draft of serializing custom editor inputs
* Use glob patterns instead of simple file extensions for matching custom resoruces for custom editors
* Add descriptions
* Try opening standard editor while prompting for custom editor
* Make sure we hide image status on dispose
* Make sure we restore editor group too
* Use glob patterns for workbench.editor.custom
* Allow users to configure custom editors for additional file types
* Use filename glob instead of glob on full resource path
* Adding placeholder for prompt open with
* Add enableByDefault setting for editor contributions
* Enable custom editors by default and add `discretion` enum
Changes `enableByDefault` boolean to a `discretion` enum. This should give more flexibility if we want other options (such as forcing a given custom editor to always be used even if there are other default ones)
* Allow custom editors to specify both a scheme and filenamePattern they are active for
* Rework custom editor setting
* Don't allow custom editors to be enabled for all resources by a config mistake
* Replace built-in image editor with one from extension
* Adding reopen with command
* Improve comment
* Remove commented code
* Localize package.json and remove image
* Remove extra lib setting from tsconfig
* Support never show again option in notification service
* in notify put never show again as secondary
* Allow customization of whether never show again is shown as secondary or primary
* put never show again inside notification object
* feedback
* feedback
