Commit graph

6622 commits

Author SHA1 Message Date
Matt Bierner f264e8f33b Make sure our temp ts directory really exists
Fixes possible cause of #64132

Some system operations or users may clear out this folder. This should not prevent TS from launching
2018-12-03 16:24:27 -08:00
Matt Bierner 64117e8fb5 Rename TriggerReason -> TriggerKind
Fixes #64216
2018-12-03 13:53:53 -08:00
Alex Ross 8ffc91c042
Merge pull request #64007 from DustinCampbell/update-csharp-grammar
Update C# TextMate grammar with latest fixes
2018-12-03 14:18:15 +01:00
Alex Ross bc916bb6af Added commit hash to cgmanifest.json 2018-12-03 11:29:00 +01:00
Alex Ross 92894195d0
Merge pull request #63759 from donaldpipowitch/patch-1
added .hintrc and moved .babelrc to jsonc grammar
2018-12-03 11:04:47 +01:00
Matt Bierner e42d74ce9a Fix completions for intellicode
IntelliCode uses `insertText`  on all of its suggestions. When completing properties, we were incorrectly assuming that only bracket suggestions would use `insertText`
2018-12-02 11:53:15 -08:00
Matt Bierner e39a97deb7 Fix snippet function call completions for intellicode 2018-12-02 11:53:15 -08:00
Erich Gamma cee0951b13 Enable Collapse All action in the npm script explorer 2018-11-30 10:25:41 +01:00
laphets 2e339afec3 Fix last merge conflict warnings 2018-11-30 09:16:19 +01:00
Matt Bierner 9878edb2a7 Pick up TS 3.2.1 final
Fixes #63179
2018-11-29 17:09:48 -08:00
Matt Bierner a3378e4342 Add pinning test for bracket completions 2018-11-29 17:09:48 -08:00
Matt Bierner c5afb50a5b Added test for #63100 2018-11-29 17:09:48 -08:00
Matt Bierner 06a64b097f Extract joinLines 2018-11-29 17:09:48 -08:00
Matt Bierner beb5998ea3 Correctly sort bracket accessor completions in js/ts completion list
Fixes #63100

As suggested in  #63100, always set the range for member completions and overwrite the dot
2018-11-29 15:09:44 -08:00
Matt Bierner e42051996b Don't trigger parameter hints when completing empty method
Fixes #64023
2018-11-29 12:03:36 -08:00
Matt Bierner f2348199e0 Update js/ts grammar 2018-11-29 11:42:42 -08:00
Matt Bierner 3f33ef2593 Support whitespace after dot for bracket completions
Fixes #64002
2018-11-29 10:44:27 -08:00
Matt Bierner 1feed6a23c Delete unused typings file 2018-11-29 10:44:27 -08:00
Dustin Campbell d27d752b6b Update C# TextMate grammar with latest fixes 2018-11-29 10:10:25 -08:00
Prabhanjan S Koushik e05aa178d6 Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..." (#63936)
* fix-63749 - Added UNICODE_NEWLINE_REGEX

* fix-63749 - Removed .skip for the test method

* fix-63749 Moved Replace to parse
2018-11-29 09:09:36 -08:00
Matt Bierner cd5b4d1bb3 Use insertText as filterText for js/ts completions by default
For some completions—such as those provided
 by IntelliCode—the label results in the incorrect sort order. IntelliCode prefixes completion labels with a unicode star, which means they appear after the normal completions

This fix make sure we use the actual text to be inserted for filtering by default instead of the label
2018-11-28 19:05:40 -08:00
Matt Bierner 364824a864 use simpler typeof check 2018-11-28 19:01:22 -08:00
Matt Bierner 3c95fb7b9f Update js/ts grammars 2018-11-28 18:28:48 -08:00
Pine 2f51c4e17c
Merge pull request #63958 from Microsoft/octref/web-component
html.experimental.custom.tags/attributes for Microsoft/vscode#62976
2018-11-28 16:42:09 -08:00
Pine Wu d198091b68 html.experimental.custom.tags/attributes for Microsoft/vscode#62976 2018-11-28 16:34:12 -08:00
Matt Bierner 5df76d3535 Highlight some basic markdown elements in js/ts fenced code blocks
Fixes #63942
2018-11-28 15:52:57 -08:00
Matt Bierner 247667c5bd Pick up updated markdown grammar 2018-11-28 13:47:35 -08:00
Peng Lyu 63710859e6
Merge pull request #63792 from vim88/fix_typo_in_comments
Fixes typo and occurrences of double words in comments.
2018-11-28 10:54:52 -08:00
Matt Bierner 9d2251469f Do not display errors in editor for cancelled js/ts code lenses
Fixes #63884

Resolving a code lenses may be cancelled if the document changes. This is normal and should not be displayed as an error in the editor
2018-11-27 17:11:07 -08:00
Matt Bierner 42145f1f0c Interupt TS references and implementations requests
Fixes #60213

These are low priority UI elements and should not block user ui requests that come in, such as completions
2018-11-27 16:48:11 -08:00
Matt Bierner 1a1987dee6 Revert "Delegate js/ts code lenses back to vs code"
This reverts commit dc47417f54.

We need finer control over how code lenses are resolved. This is required for #60213. Showing all references in the references code lense now requires using ts plugin instead
2018-11-27 16:48:11 -08:00
Matt Bierner 9e17c2c92c Pick up new TS insiders 2018-11-27 16:11:30 -08:00
Matt Bierner 9461f661f0 Interupt geterror requests for signature help requests
See 7eed623657 for more details
2018-11-27 15:12:10 -08:00
Matt Bierner 7eed623657 Interupt geterror requests for getting completion entry details
UI actions like this should interup potentially long running getError requests on the server. This is because the getErr request must be fully processed before the completion entries can be returned. Explicit user actions in the UI are more important and should be computed as soon as possible
2018-11-27 14:56:07 -08:00
Matt Bierner 2f9f0c35cc Added failing test for #63749
Add skipped test for #63749 so someone can pick this up
2018-11-27 12:02:39 -08:00
Matt Bierner f685215dd4 Adding version info for ts non-code dependencies
Fixes  #63577
2018-11-27 11:40:27 -08:00
Matt Bierner 336db91acb Use switch case 2018-11-27 11:40:27 -08:00
Matt Bierner 9531a7c380 💄 2018-11-27 11:40:27 -08:00
Matt Bierner 0c126b0608 Extract display part kinds to constants files 2018-11-27 11:40:27 -08:00
Matt Bierner bab1ea6c27 💄 2018-11-27 11:40:27 -08:00
Matt Bierner ca7f6c2cf2 Move snippetForFunctionCall to own file 2018-11-27 11:40:27 -08:00
Matt Bierner 77454b24bc Extract append joined placeholders 2018-11-27 11:40:27 -08:00
Matt Bierner 0aef227bbf Try splitting up parameter list extraction from snippet building 2018-11-27 11:40:27 -08:00
Matt Bierner 61ad185759 Make it clearer that insert text snippets override the rest snippet generation 2018-11-27 11:40:27 -08:00
Matt Bierner d5843e550f Fix bug for generating snippet if the object type contained a method signature 2018-11-27 11:40:27 -08:00
Matt Bierner 1755715a13 Fix bug where return type containing function type could be merged with normal parameters 2018-11-27 11:40:26 -08:00
Matt Bierner 86d7fd923a Adding pinning test for inline types 2018-11-27 11:40:26 -08:00
Matt Bierner af05b65331 Adding plnning test for rest paramters 2018-11-27 11:40:26 -08:00
Matt Bierner e8f00e763a Adding pinning test for getting parameters 2018-11-27 11:40:26 -08:00
Matt Bierner ece1bad312 Adding basic pinning tests for insert text 2018-11-27 11:40:26 -08:00
Matt Bierner ec3cba2661 Add test for using insert text 2018-11-27 11:40:26 -08:00
Matt Bierner ecce9249cb Extract snippetForFunctionCall so that it can be tested 2018-11-27 11:40:26 -08:00
vim88 510d90d11e Fixes typo and occurrences of double words in comments. 2018-11-26 19:57:48 +02:00
Donald Pipowitch ee5153ffde
added .hintrc and moved .babelrc to jsonc grammar 2018-11-26 07:57:55 +01:00
isidor 1e3efda93c polish cgmanifest.json 2018-11-20 17:02:09 +01:00
isidor 085f4656ed add some commit hashes and versions to cgmanifest.json 2018-11-20 16:31:08 +01:00
Isidor Nikolic ec98c79d44
Merge pull request #63497 from Microsoft/isidorn/cgmanifest
Start using component governance for oss tracking
2018-11-20 12:54:47 +01:00
isidor 9edd984da8 delete OSSREADME.json 2018-11-20 12:54:22 +01:00
João Moreno 66f717cfa6
Merge pull request #60104 from mathiasvr/fix-60002
Fix #60002 Undo last commit: keep staged files
2018-11-20 09:59:42 +01:00
Joao Moreno 3af878c2d5 💄 2018-11-20 09:58:01 +01:00
Joao Moreno 6052fcf07f Merge commit 'refs/pull/59735/head' of github.com:Microsoft/vscode into pr/59735 2018-11-20 09:43:16 +01:00
Matt Bierner 02a59c3015 Make CachedResponse generic 2018-11-19 18:48:36 -08:00
Matt Bierner fabc627634 Move getSymbolRange out of class 2018-11-19 18:46:09 -08:00
Matt Bierner 1f1618d280 Remove extra conditional
This should always be true
2018-11-19 18:41:26 -08:00
Matt Bierner f953906c74 Remove un-needed any cast 2018-11-19 18:24:59 -08:00
Matt Bierner 26cd646618 Remove unnessisary conditional
The body of these specific events are always non-null
2018-11-19 16:34:15 -08:00
Matt Bierner 277b96327f Enable loading indicator for subsequent js/ts project loads
Fixes #62978
2018-11-19 16:34:15 -08:00
Matt Bierner b115d8860c Extract loadingIndicator to class 2018-11-19 16:34:15 -08:00
Matt Bierner 300f1b8d98 Extract lazy activation logic 2018-11-19 16:34:15 -08:00
Matt Bierner 575e1630d5 Add API so that extensions can configure TS Server plugins
Fixes #63181

This is a replacement for the `_typescript.configurePlugin` command. Using a command, it is easy to forget to check if the js-ts extension is active before executing it. Using an actual api prevents this  and also allows better typing
2018-11-19 14:59:19 -08:00
Matt Bierner 0bfb7fcb54 Add metadata on completions accepted api 2018-11-19 11:04:03 -08:00
Joao Moreno e5406b523e introduce git.openDiffOnClick
fixes #63005
2018-11-19 11:54:51 +01:00
Joao Moreno eb6025ec9b git.postCommitCommand
fixes #62058
2018-11-19 11:54:51 +01:00
Ramya Achutha Rao dcc243c992 Better readability for util.ts 2018-11-18 19:42:02 -08:00
Alex Dima 66f4c5be3a Adopt OSS tool 2018-11-16 23:21:02 +01:00
Alex Dima 976cfe3aa7 Merge branch 'master' into isidorn/cgmanifest 2018-11-16 17:52:27 +01:00
Johannes Rieken c507f6347b set outline label for TypeScript and launch.json, #62839 2018-11-16 16:08:55 +01:00
isidor 040ee51d72 cgmanifest: some commit hashes 2018-11-16 11:46:58 +01:00
João Moreno 850bbb275e
Merge pull request #63069 from Microsoft/rmacfarlane/gitapi
Expose 'apply' and 'diff --cached' from git extension API
2018-11-16 09:40:04 +01:00
Matt Bierner a6b8074a19 Remove is 2018-11-15 18:10:35 -08:00
Matt Bierner 8244f81b65 Simplify data2String 2018-11-15 18:07:57 -08:00
Matt Bierner 78de541d49 Delete unused log level and type levels 2018-11-15 18:07:20 -08:00
Matt Bierner 07a5118d23 Make sure we dispose of pluginManager 2018-11-15 17:59:35 -08:00
Matt Bierner 0dd2f7487f Don't eagerly construct surveys 2018-11-15 17:56:40 -08:00
Matt Bierner a0f0ee42e9 Move survey ready logic into Surveyor 2018-11-15 17:54:46 -08:00
Matt Bierner 106cbdec2c Extract api to own file 2018-11-15 17:50:28 -08:00
Matt Bierner ca68cfd75d Split commands into own files 2018-11-15 17:44:56 -08:00
Matt Bierner dc03204cc2 Improve names 2018-11-15 17:44:56 -08:00
Matt Bierner 71f86e584d Merge plugin config provider into plugin manager 2018-11-15 17:44:56 -08:00
Matt Bierner 5da4d1188e Encapsulate plugins in plugins manager 2018-11-15 17:44:56 -08:00
Matt Bierner 01511eeb28 Make plugin.languages readonly 2018-11-15 17:44:56 -08:00
Matt Bierner 49fd31af84 Move plugin config provider to plugins file 2018-11-15 17:44:56 -08:00
Matt Bierner 3c78e312c6 Remove extra tslint file 2018-11-15 17:44:56 -08:00
Matt Bierner ac95482f6d Pick up TS 3.2 rc 2018-11-15 17:44:56 -08:00
Matt Bierner 0aafeac4a8 Update md grammar 2018-11-15 13:49:40 -08:00
isidor 2ba92aa3e8 add commitHash to cgmanifest 2018-11-15 17:43:46 +01:00
Matt Bierner f31bc50d1c Use correct position for requesting closing jsx tags
Fixes #63178

Make sure we compute the correct line and offset for multi-line changes
2018-11-14 18:37:00 -08:00
Matt Bierner 80aeb774f6 Fix possible undefined access exception when using apply "first" for a code action and no code actions are returned
Fixes #63101
2018-11-14 15:39:34 -08:00
Matt Bierner 813d3aa393 Fixing some more restrictive tslint errors 2018-11-14 14:45:13 -08:00
Matt Bierner bd314b04a8 Remove extra await 2018-11-14 14:26:46 -08:00
Matt Bierner 3aa49aa583 Improve method names 2018-11-14 14:16:46 -08:00
Matt Bierner d6b6c51b6e Make sure we dispose of reader properly 2018-11-14 14:15:31 -08:00
isidor 347fb6347b add all cgmanifests. Still no commitHash 2018-11-14 18:18:25 +01:00
Joao Moreno 237b77bac9 prepare for ts 3.2 2018-11-14 09:29:01 +01:00
Matt Bierner 4737e3efd1 Fixing TS 3.2 compile errors 2018-11-13 17:13:15 -08:00
Matt Bierner 4f227dd88c Use 'references' instead of 'occurrence' to power document highlights
`occurrence` is marked as deprecated
2018-11-13 17:13:15 -08:00
Rachel Macfarlane ad5f5ea365 Expose 'apply' and 'diff --cached' from git extension API 2018-11-13 16:18:37 -08:00
jokurz 21f8789726 Autodetect ksh scripts as shellscript (#62838)
Identify ksh scripts (file extenstion `.ksh` or `#!/usr/bin/ksh` in first line) as shellscript. Fixes #39096
2018-11-13 11:27:47 +01:00
Matt Bierner fd824ee58e Don't explicitly add folder name to task labels
Fixes #60315

Don't add workspace folder name to task labels as this messes up build task detection.

This change currently causes a regression when you have two folders with the same folder name (but different paths) in a workspace
2018-11-12 15:00:13 -08:00
Matt Bierner 30fb7804c9 Auto close <> in js/ts
Fixes #62864
2018-11-12 11:23:59 -08:00
Joao Moreno d4b84e645f fix #62344 2018-11-12 11:18:58 +01:00
Matt Bierner a3fa56b477 Observe isIncomplete metadata passed by from a plugin
Supports cases like https://github.com/Microsoft/typescript-styled-plugin/issues/41

Requires TS 3.2
2018-11-09 16:30:49 -08:00
Christof Marti c9cf18e109 Wait some more 2018-11-09 15:06:48 +01:00
Christof Marti f9307094ba Try fix timing issues 2018-11-09 07:49:34 +01:00
Matt Bierner d5c11916a1 Support rendering color completions from a ts plugin as colors in the suggest list
https://github.com/Microsoft/typescript-styled-plugin/issues/80
2018-11-08 17:21:17 -08:00
Miguel Solorio 4533aa0c0a
Merge pull request #62739 from RDIL/master
Optimize images
2018-11-08 08:42:57 -08:00
Rachel Macfarlane 40a6a2db9a Expose force flag for deleting branch on git extension API 2018-11-07 10:48:40 -08:00
Alex Ross cfd2ea16e8 Update NPM script explorer tree view when package.json changes
Fixes #62415
2018-11-07 11:58:51 +01:00
ImgBotApp d412f89baf
[ImgBot] Optimize images
*Total -- 201.93kb -> 142.81kb (29.28%)

/extensions/npm/images/npm_icon.png -- 3.21kb -> 0.51kb (84.1%)
/src/vs/workbench/parts/debug/electron-browser/media/stepout-tb.png -- 2.89kb -> 0.47kb (83.83%)
/src/vs/workbench/parts/debug/electron-browser/media/stop-tb.png -- 1.50kb -> 0.35kb (76.43%)
/src/vs/workbench/parts/debug/electron-browser/media/pause-tb.png -- 1.55kb -> 0.37kb (76.34%)
/src/vs/workbench/browser/parts/editor/media/forward-tb.png -- 1.57kb -> 0.37kb (76.25%)
/src/vs/workbench/browser/parts/editor/media/back-tb.png -- 1.52kb -> 0.37kb (75.53%)
/src/vs/workbench/parts/debug/electron-browser/media/continue-tb.png -- 1.60kb -> 0.42kb (73.48%)
/src/vs/workbench/parts/debug/electron-browser/media/stepinto-tb.png -- 1.66kb -> 0.47kb (71.51%)
/src/vs/workbench/parts/debug/electron-browser/media/restart-tb.png -- 1.91kb -> 0.59kb (68.84%)
/src/vs/workbench/parts/debug/electron-browser/media/stepover-tb.png -- 1.93kb -> 0.62kb (67.75%)
/resources/linux/code.png -- 5.76kb -> 2.66kb (53.86%)
/extensions/html-language-features/icons/html.png -- 4.40kb -> 2.28kb (48.15%)
/extensions/theme-seti/icons/seti-circular-128x128.png -- 8.73kb -> 4.70kb (46.12%)
/extensions/typescript-language-features/icon.png -- 1.60kb -> 0.97kb (39.15%)
/src/vs/platform/extensionManagement/node/media/defaultIcon.png -- 1.65kb -> 1.03kb (37.49%)
/src/vs/workbench/parts/extensions/electron-browser/media/defaultIcon.png -- 1.65kb -> 1.03kb (37.49%)
/extensions/vscode-api-tests/testWorkspace/sub/image.png -- 35.87kb -> 24.99kb (30.33%)
/extensions/vscode-api-tests/testWorkspace/image.png -- 35.87kb -> 24.99kb (30.33%)
/resources/win32/code_150x150.png -- 0.55kb -> 0.39kb (29.96%)
/extensions/css-language-features/icons/css.png -- 5.07kb -> 3.63kb (28.37%)
/extensions/json-language-features/icons/json.png -- 5.84kb -> 4.33kb (25.89%)
/extensions/markdown-language-features/icon.png -- 1.19kb -> 0.88kb (25.86%)
/src/vs/workbench/parts/extensions/electron-browser/media/theme-icon.png -- 9.90kb -> 7.42kb (25.1%)
/extensions/php-language-features/icons/logo.png -- 10.85kb -> 8.99kb (17.13%)
/extensions/gulp/images/gulp.png -- 7.36kb -> 6.20kb (15.8%)
/extensions/merge-conflict/resources/icons/merge-conflict.png -- 2.47kb -> 2.10kb (14.96%)
/extensions/jake/images/cowboy_hat.png -- 43.85kb -> 41.67kb (4.98%)
2018-11-06 20:46:03 +00:00
Alexandr Fadeev e99942ccc3 Update makefile colorize tests according to the latest grammar. (#61961)
1. Handling the '!=' variable assignment operator.
2. Handling the "#" (hashtag) in the quotes inside the recipe.
3. Restore the recipe handling.

Issue: #60030, #61475
2018-11-06 12:55:25 +01:00
Alex Ross c71f524777 Updated grammars 2018-11-06 11:39:33 +01:00
Alex Ross d119e01a8f Reload grunt and jake tasks after npm install 2018-11-06 11:18:26 +01:00
Alex Ross c686a15384
After npm install gulp extension should find tasks (#62129)
Fixes #61499
2018-11-06 11:04:53 +01:00
Ramya Achutha Rao 6f139c79ad Test for multiline selection for wrap 2018-11-05 17:45:40 -08:00
Matt Bierner d8cce48edd Update markdown grammar 2018-11-05 17:25:47 -08:00
Matt Bierner 812a35fc39 Update js/ts grammar 2018-11-05 16:20:13 -08:00
Matt Bierner 6e5b0be369 Use set instead instead of regexp for kind modifiers 2018-11-05 16:16:34 -08:00
Matt Bierner 92fc1f1f74 Enable file icons for js/ts path intellisense
Fixes #61625

Requires TS 3.2+. Uses the kind modifier to determine the type of the file being imported
2018-11-05 16:08:44 -08:00
Matt Bierner edce7e2b8d Version js/ts Api 2018-11-05 15:11:50 -08:00
Matt Bierner b929dc93d3 Use api for onCompletionAccepted instead of command 2018-11-05 14:29:50 -08:00
Miguel Solorio b4b3f75deb Fix #62446, increase opacity of selection highlight bg 2018-11-05 14:23:38 -08:00
Matt Bierner 170077d533 Adding command that is fired when a js/ts completion is accepted 2018-11-05 14:17:17 -08:00
Joao Moreno fb9e1da186 update git iconv-lite dependency
fixes #62272
2018-11-05 13:39:47 +00:00
Pine Wu 649f448ef9 Fix #62146, Fix #62149 2018-11-02 12:15:34 -07:00
Pine Wu 1820a98e91 Fix css dependency 2018-11-02 10:28:11 -07:00
Pine Wu ee4a0717f9 Update css service for #62159 2018-11-02 10:06:04 -07:00
Pine Wu b7eb0f4040 Update css/less/scss config to make validProperty an string[] 2018-11-01 08:50:21 -07:00
Joao Moreno 2b1d06feb9 fixes #18673 2018-11-01 16:06:38 +01:00
Joao Moreno 50a4525420 fixes #60986 2018-11-01 15:59:42 +01:00
Joao Moreno 349e31fee9 fixes #58918 2018-11-01 15:00:53 +01:00
Joao Moreno 66a49b23da cleaner git push api 2018-11-01 11:11:47 +01:00
Joao Moreno 0aa28f556e Merge commit 'refs/pull/61448/head' of github.com:Microsoft/vscode into pr/61448 2018-11-01 11:09:51 +01:00
Matt Bierner 1faae7e83f Make sure we activate js/ts extension when someone sends the _typescript.configurePlugin command 2018-10-31 23:30:24 -07:00
Pine Wu 261e2776eb Update css service to fix Selector Specificity issues 2018-10-31 15:40:31 -07:00
Pine Wu 14331632b2 Update css service for #62163 2018-10-31 12:50:24 -07:00
Pine Wu 988c2fa767 Update validProperties description. Fix #62162 2018-10-31 12:49:41 -07:00
Matt Bierner 36790dd767 Fixing a few errors in plugin TS config command
- Make sure we update config after server start
- Fix argument order and add type to ensure it's not as easy to confuse argument order
2018-10-31 10:58:27 -07:00
Konrad Borowski 21b3651b24 Add a semicolon at end of non-built-in languages list 2018-10-31 10:53:16 -07:00
Matt Bierner 97ad72a02c Dont enable commit characters in case where cursor is at dot preceeded by whitespace
Fixes #59934

Proper fix is upstream https://github.com/Microsoft/TypeScript/issues/27742
2018-10-30 17:19:44 -07:00
Matt Bierner e21df781db Treat data: as a known markdown link scheme
Fixes #62142
2018-10-30 11:34:33 -07:00