Ulugbek Abdullaev
95722d2256
add ensureNoDisposablesAreLeakedInTestSuite() to tests
2024-01-31 12:23:19 +01:00
Benjamin Pasero
f90b72a136
perf - more workbench contrib work ( #203880 )
...
* perf - more workbench contributions work
* .
* add to perf editor
2024-01-31 12:12:48 +01:00
Drew Pirrone-Brusse
3f7e44287c
Extend TextEditorLineNumbersStyle with Interval ( #198787 )
2024-01-31 12:05:59 +01:00
Hylke Bons
e0277c1fee
a11y theme fixes ( #203870 )
...
actionbar: Replace opacity with color for disabled state
2024-01-31 12:03:08 +01:00
Benjamin Pasero
3b5ae15f95
perf - registerWorkbenchContribution2 and some adoptions ( #203802 )
...
* perf - first cut workbench contributions 2
* log warning
* add tests
* tests
* fix tests
* .
* adopt a bit and add access to times
* adopt for some
* adopt for some
* .
* fix tests
* .
2024-01-31 11:04:30 +01:00
Matt Bierner
777ea450a1
Adopt localize2 in more places ( #203842 )
...
Switches many callers to use `localize2` instead of duplicating strings
2024-01-31 02:16:25 +01:00
Michael Lively
8c39690fc4
Fix broken highlights when clicking a previously selected symbol ( #203853 )
...
streamline request logic + kill worker req on decoration removal
2024-01-31 02:12:29 +01:00
Matt Bierner
0404d17da6
Fix nls build script on line such as localize2(...) ... localize(...) ( #203851 )
...
For #203842
I believe we need to apply the patches in character order. Otherwise the line ends up corrupted after the patching
2024-01-31 01:40:20 +01:00
Matt Bierner
31fbc3dc94
Remove extra not null assertions ( #202201 )
...
* Remove extra not null assertions
With https://github.com/microsoft/TypeScript/pull/56908 , TS should better preserve type refinements. To help test this out, I made a quick pass through our code to remove type assertions that are no longer needed
Most of these are not impacted by https://github.com/microsoft/TypeScript/pull/56908 but removing them helps TS test changes like this
Not adding an eslint rule for now as it requires whole program intellisense, which is too slow for commit hooks
* Fix merge
2024-01-30 15:43:09 -08:00
Matt Bierner
adaf974eb2
Pick up latest TS for building ( #203840 )
2024-01-30 23:19:07 +01:00
Michael Lively
8cf2750bb6
Fix persistent syntax highlighting in split windows ( #203837 )
...
fix splitview highlighting #198866
2024-01-30 14:05:44 -08:00
Daniel Imms
fdfd19216f
Merge pull request #203831 from microsoft/tyriar/xterm_240130
...
Update xterm
2024-01-30 14:04:40 -08:00
Bhavya U
32150ac72e
Announce checkbox status in walkthrough step ( #203835 )
2024-01-30 12:55:39 -08:00
Ladislau Szomoru
dd2038279d
Git - fix repository deduplication logic ( #203836 )
2024-01-30 21:54:36 +01:00
Matt Bierner
531cc0ee62
Don't accidentally create InlineChatFileCreatePreviewWidget when hiding it ( #203830 )
2024-01-30 12:31:38 -08:00
Daniel Imms
e13013289e
Update xterm
...
Fixes #200428
2024-01-30 12:02:53 -08:00
Joyce Er
c9f0aa5b73
fix: rerender welcome view when chat provider is disposed ( #203740 )
2024-01-30 11:37:56 -08:00
Daniel Imms
7fd1edb31b
Merge pull request #202730 from wy-luke/main
...
docs: update comment for hideFromUser
2024-01-30 11:05:07 -08:00
Matt Bierner
ab5dd705b0
Add promiseWithResolvers shim ( #203826 )
...
Adds a shim for `Promise.withResolvers`. This is slightly reduces lines of code. More importantly it plays more nicely with TypeScript's type checking and lets us mark more vars const and properties readonly
2024-01-30 11:58:55 -07:00
Daniel Imms
1802552fc5
Add change to missed file
2024-01-30 10:44:53 -08:00
Daniel Imms
55e64beda6
Tweak wording
2024-01-30 10:03:58 -08:00
Daniel Imms
9fe979b30e
Merge pull request #203820 from microsoft/tyriar/203708
...
Ensure MutableDisposable is not disposed
2024-01-30 10:03:24 -08:00
Daniel Imms
8fad0a0236
Merge branch 'main' into main
2024-01-30 10:00:46 -08:00
Connor Peet
6291fb21ec
cli: fix adveristing file extension on windows ( #203818 )
...
Fixes #202919
2024-01-30 09:52:18 -08:00
Daniel Imms
0d1811a62a
Ensure MutableDisposable is not disposed
...
Fixes #203708
2024-01-30 09:35:17 -08:00
Andrea Mah
83d2f0673f
"editor.find.seedSearchStringFromSelection" is ignored ( #203759 )
...
Fixes #142864
2024-01-30 09:32:09 -08:00
Rob Lourens
f40051b610
Port candidates to main ( #203815 )
...
* Port candidate to main
Bringing in #203574
* Enable #file for stable (#203549 )
Fix #203548
2024-01-30 17:54:19 +01:00
Rob Lourens
06a8ed6e0e
Fix incorrectly disposing some disposables ( #203809 )
...
Fix #203794
2024-01-30 17:29:00 +01:00
Aaron Munger
9116c8c9d9
notebook variable data source tests ( #203753 )
...
* indexed children tests
* one more assert
2024-01-30 08:05:02 -08:00
Johannes Rieken
1f80d8b8e4
fix https://github.com/microsoft/vscode/issues/203510 ( #203798 )
2024-01-30 15:54:13 +01:00
BeniBenj
e76b1ff761
💄
2024-01-30 15:13:46 +01:00
BeniBenj
2cfe4ca61e
Removed unused CSS classes from tab elements in MultiEditorTabsControl
2024-01-30 14:51:12 +01:00
Robo
e2ce367fc8
fix: update server requirements check for alpine distro ( #203790 )
2024-01-30 14:22:03 +01:00
Sandeep Somavarapu
c481f95364
Fix extension installation from location - check for valid manifest ( #203785 )
2024-01-30 12:50:47 +01:00
BeniBenj
a78b270441
💄
2024-01-30 12:49:32 +01:00
Megan Rogge
4dcce9b45c
Merge pull request #203749 from microsoft/merogge/alert-cues
...
use checkboxes for audio cue/alert quickpicks
2024-01-30 03:45:47 -08:00
RedCMD
eee4b5fc50
Contribute to json language server with a custom language. ( #198583 )
...
* Contribute to json language server with a custom language.
* Add `snippets` to `"activationEvents"`
* Remove hardcoded `snippets` from `documentSettings`
* Fix wrong variable in `!isEqualSet()`
* Use `extensions.allAcrossExtensionHosts` instead of `extensions.all`
* enable `"enabledApiProposals"` for `extensions.allAcrossExtensionHosts`
* Fix error: `Property 'allAcrossExtensionHosts' does not exist on type 'typeof extensions'`
* Remove `snippets`
2024-01-30 11:10:23 +00:00
Johannes Rieken
6215ccd0e7
send telemetry about accepted/discarded hunks and about response types ( #203780 )
2024-01-30 12:09:34 +01:00
Benjamin Pasero
860f38ba53
aux window renames ( #203775 )
2024-01-30 09:24:06 +01:00
Robo
74ef67b4ab
fix: update rpm release tag to el8 ( #203770 )
2024-01-30 07:09:47 +01:00
Raymond Zhao
e284396074
chore: use newest node-gyp for SDL pipeline ( #199820 )
...
* chore: use latest upstream node-gyp
* fix: use node-gyp.js file directly
* apply PR feedback
* chore: delete patch file
* Apply PR feedback
* Update cache salt
2024-01-30 12:24:14 +09:00
Justin Chen
c95fb565ba
changed issueReporterCommand types and bug fix ( #203747 )
...
changed uri from string, word wrap
2024-01-29 18:32:58 -08:00
Connor Peet
d7cfba7af7
cli: update dev tunnel sdk ( #203763 )
2024-01-30 03:01:21 +01:00
Peng Lyu
01a85f298b
Polish find widget css rules ( #203762 )
...
* refactor css variables for findWidget
* adapt css variable for findWidget
* Polish find widget css rules
---------
Co-authored-by: weartist <weartistt@gmail.com>
2024-01-30 03:01:03 +01:00
Andrea Mah
d6885f672a
Use const enum over const for search command IDs ( #203757 )
...
Fixes #190249
2024-01-29 17:30:20 -08:00
Michael Lively
b9511a9520
Adjust WordHighlighter to use hasTextFocus() instead of hasWidgetFocus() ( #203754 )
...
Potential fix for #201814
2024-01-30 01:06:36 +01:00
Andrea Mah
84bdd343e7
Notebook Search eagerly activates extensions ( #203748 )
...
* initial attempt for 'hasResult' in remote code
* Notebook Search eagerly activates extensions
Fixes #203389
2024-01-29 15:56:58 -08:00
meganrogge
f8a6171282
fix issues
2024-01-29 15:32:11 -08:00
meganrogge
f29cc2750e
set default for terminal bell
2024-01-29 15:14:27 -08:00
meganrogge
ea700efe61
fix #202025
2024-01-29 15:12:14 -08:00
