Commit graph

1647 commits

Author SHA1 Message Date
Matt Bierner d0d28a6295
Reapply building of web server (#166391)
* Reapply building of web server

Revert 8b4642ab23

* Fix critical dep error
2022-11-15 14:55:40 -08:00
Matt Bierner 4fdcdb17c6
Pick up latest jsonc parser (#166334) 2022-11-15 13:46:52 -08:00
Henning Dieterichs b11207c539 Revert "Copy webServer from Typescript to VS Code (#165771)"
This reverts commit cb43019d6a.
2022-11-15 14:45:32 +01:00
Matt Bierner 44441de137
Adopt prefer-readonly in JS/TS extension (#165089) 2022-11-14 20:12:10 -08:00
Greg Van Liew 27a550f451
Settings description edits (#166315)
* Settings description edits

* Remove unnecessary trailing line returns
2022-11-14 13:47:54 -08:00
Nathan Shively-Sanders cb43019d6a
Copy webServer from Typescript to VS Code (#165771)
* Initial draft.

Not working.
Also not correctly formatted, I'll do that later.

* Various fixes

It works now

* A bit of cleanup

* Move webServer to its own directory

And prepare for getting rid of dynamicImportCompat.js hack

* Remove dynamicImportCompat.js hack

* Revert unrelated change

* Webpac tsserver.web.js with webServer.ts as entrypoint

Instead of using CopyPlugin.

1. Shipping multiple entrypoints in a single file required fixes to
build code.
2. There are a couple of warnings from `require` calls in
tsserverlibrary.js. Those are not relevant since they're in non-web
code, but I haven't figured how to turn them off; they are fully dynamic
so `externals` didn't work.

* Ignore warnings from dynamic import in tsserver

* Add to .vscodeignore files
2022-11-14 10:56:31 -08:00
Logan Ramos 73d882bcf7
Update telemetry package (#166292) 2022-11-14 09:30:33 -08:00
Logan Ramos bf1697d98c
Consume proposed telemetry API (#165862)
* Consume proposed telemetry API

* Update webpack
2022-11-08 21:58:28 -05:00
Matt Bierner 5d04c3b06c
Don't assume file paths in tsconfigs (#165779)
Fixes #160979
2022-11-07 20:24:31 -08:00
Matt Bierner 3c874be287
Fix UI string (#165554) 2022-11-04 14:04:58 -07:00
Matt Bierner 0bd1531e00
Adopt l10n for ts extension (#165450)
For #164438

Also refines the eslint rule from #165448
2022-11-04 09:50:18 +01:00
Matt Bierner 8ad43669a9
Prompt users to test with extensions disabled (#165203) 2022-11-01 16:38:45 -07:00
Jake Bailey b99cf7e41e
Ensure 'undefined' does not make it into tsserver.web.js (#164064) 2022-10-19 16:44:03 -07:00
Daniel Rosenwasser 182beb6ee4
Merge pull request #163498 from DanielRosenwasser/iconsForWalkthroughs
Allow walkthroughs to specify icons.
2022-10-19 11:26:51 -07:00
Matt Bierner 7f99b7c655
Remove references to finalized proposals in js/ts (#164040) 2022-10-19 13:23:48 -04:00
Matt Bierner 33378c2ec0
Fix organize imports (#164035)
Fixes #163994

This fixes the organize imports command (it was using the wrong id) and also cleans up the implementation
2022-10-19 09:27:41 -07:00
Andrew Branch 1fb956d2f5
[typescript-language-features] Add removeUnusedImports command (#161654)
* Add `removeUnusedImports` command

* Continue to send `skipDestructiveCodeActions` for older TS versions

* Expose Sort Imports and Remove Unused Imports commands

* Update localization keys

* Update for 4.9 protocol

* Proto must be type only import?
2022-10-18 09:00:16 -07:00
Matt Bierner 186d3415a3
Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Jake Bailey 65a9097aa2
Remove forgoten reference to typescript/lib/protocol (#163585) 2022-10-13 13:15:13 -07:00
Daniel Rosenwasser a053a4d505 Allow walkthroughs to specify icons.
Useful for specifying icons *other* than those of the contributing extension.
2022-10-12 17:14:42 -07:00
Jake Bailey 07b87405e7
Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Suven-p 22ff985c19
Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Tyler James Leonhardt 4322170fd8
comment is an array (#163348) 2022-10-11 13:39:12 -07:00
Matt Bierner 3ee9749b35
Remove extra enums (#162686)
`showMessage` returns the selected item, so we don't need to create an enum here and can instead used the returned items directly
2022-10-04 10:46:53 -07:00
Tyler James Leonhardt 29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data (#161819)
ref #161297
2022-09-26 11:10:54 -07:00
Gerrit Birkeland cace09d0eb
Add schema for typedoc.json to default jsonValidation (#157592)
Add schema for typedoc.json to default 
jsonValidation
2022-09-26 15:51:42 +02:00
Daniel Rosenwasser da506e9b8d
Tag existing events with experimentation info in typescript-language-features (#161463)
* Associate experiment info with existing telemetry.

* Move the ExperimentTelemetryReporter to its own file.

* Roughly copied the 'getPackageInfo' function from other extensions.

* Addressed code review feedback.
2022-09-23 15:18:57 -07:00
Matt Bierner f25d47121b
Pick up newer vscode-tas-client version (#161344) 2022-09-20 13:52:29 -07:00
Daniel Rosenwasser 5cde74b767
Fix accidental case fallthroughs in experimentation services. (#161339) 2022-09-20 12:00:32 -07:00
Johannes Rieken 77309b33d4
add WorkspaceEditMetadata and use it for applyEdit, (#160996)
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
2022-09-16 09:44:19 +02:00
Matt Bierner 3c37a5a8d7
Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Daniel Rosenwasser 9dfd49db63
Ensure ExperimentationService gets disposed. (#161004) 2022-09-15 11:06:53 -07:00
Benjamin Pasero cfc0119755
Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
2022-09-15 08:26:22 +02:00
Daniel Rosenwasser 0cbcb1b1ab
JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
Daniel Rosenwasser 00902daee1
Instantiate ExperimentationService in typescript-language-features. (#160877)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:34:04 -07:00
Matt Bierner 1d500fb4de
Add CodeActionKind.RefactorMove (#160730)
Fixes #160728
2022-09-12 15:14:06 -07:00
Matt Bierner c4722f1bb2
Write markdown link setting change to correct scope (#159816)
Fixes #159084

Also fixes the same issue for JS/TS
2022-09-02 13:38:41 +10:00
Matt Bierner c9a97b5581
Pick up TS 4.8 final (#159238)
Fixes #157527
2022-08-26 01:30:07 +02:00
Matt Bierner 129f5bc976
Use own calls to localize (#158372)
Fixes #156684
2022-08-17 10:27:29 -04:00
Tyler James Leonhardt d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 (#157530)
* rev version of vscode-nls to 5.1.0

* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt 49394cc44d
Enable translations for extension code for the web (#155355)
* Initial attempt

* alex feedback
2022-08-08 09:11:16 -07:00
Matt Bierner 0c78644c6e
Use tabs to figure out when to report JS/TS diagnostics (#157117)
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
2022-08-04 10:46:56 -07:00
Matt Bierner 424fe151f1
Add patch for enabling new TS plugins on web approach (#149186)
* Add patch for enabling new TS plugins on web approach

https://github.com/microsoft/TypeScript/pull/47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR

* Update for new files names
2022-08-02 20:00:22 +02:00
Matt Bierner f0434c0960
Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Matt Bierner 97c8a97261
Include globally enabled TS Server plugins when reporting issues (#156510)
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
2022-08-01 10:44:46 -07:00
Matt Bierner 4eef7a94e1
Tell users about enabled TS plugins on crash (#156514)
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
2022-08-01 10:44:33 -07:00
Matt Bierner 06f8d52e37
Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Matt Bierner 00bb9bdefc
Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
ryuurock 42e79ca270
Update typescriptServiceClient.ts, fix naming errors (#155946)
Update typescriptServiceClient.ts

fix naming errors
2022-07-22 17:46:48 +00:00
Logan Ramos a20329d291
Switch extensions to 1DS (#154299)
* Move extensions to 1DS

* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Andrew Branch 1d16e313d6
[typescript-language-features] Add setting for autoImportFileExcludePatterns (#153160)
* Add setting for autoImportFileExcludePatterns

* Add TS 4.8 to message
2022-06-28 16:43:24 -07:00
Matt Bierner c16036705e
Initial contents for experimentation in typescript-language-features. (#153358)
Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
2022-06-27 12:53:24 -07:00
Matt Bierner 9051021473
Clarify label on source action (#153356)
Clairify label on source action

For https://github.com/microsoft/vscode-eslint/issues/1428
2022-06-27 19:01:41 +00:00
Logan Ramos 4a7a6a597a
Update extension telemetry modules (#153057) 2022-06-24 00:53:23 +00:00
Daniel Imms f0cf1ea129
Fix initial compilation problem matching in tsc-watch
Fixes #152966
2022-06-23 04:48:25 -07:00
Matt Bierner 8559324b09
Use more optional chaining in TS extension (#152271)
Use optional chaining in TS extension

Also removes `prefer-const` since this is now enabled globally
2022-06-16 05:33:58 +02:00
Matt Bierner a289e64e09
Switch to finalized TS protocol types (#152259) 2022-06-15 15:37:21 -07:00
Matt Bierner 8fb977f2c1
Make jsx: react the default for implicit js/ts projects (#152256)
Make jsx: react the default

Fixes #152150

This fixes imports of `react` getting removed with TS 4.7 in implicit projects
2022-06-15 21:41:52 +00:00
Andrew Branch 5a32c3ff17
[typescript-language-features] Pass through all typescript.unstable.* settings (#151472)
Pass through all `typescript.unstable.*` settings
2022-06-08 11:53:06 -07:00
Matt Bierner e44f4ba886
Add experimental tag to experimental extension settings (#151031)
This makes a few more extension settings with the `experimental` tag so that show up if you search `@tag:experimental`
2022-06-01 16:32:58 -07:00
Matt Bierner 6428d0fc7d
Support TS's includeInlayVariableTypeHintsWhenTypeMatchesName setting (#150489)
From https://github.com/microsoft/TypeScript/pull/48529

Let users control is variable type inlay hints are suppresed if the variable name matches the type name, such as:

```ts
const range = new Range();
```
2022-05-26 16:00:04 -07:00
Logan Ramos 3a8b1fe03e
More telemetry comments (#150303)
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
2022-05-24 16:00:55 -07:00
Matt Bierner 6bd7605ae1
Enable strictNullChecks for implicit projects (#149844)
Mistakenly enabled checkJS instead of strictNullChecks
2022-05-18 10:47:37 -07:00
Matt Bierner 101f6fb31d
Enable enabling js/ts.implicitProjectConfig.checkJs by default (#149660)
Fixes #149659
2022-05-16 11:52:27 -07:00
Matt Bierner 4923404e98
Don't include leading @ in JS/TS completion word range (#149400)
Fixes #149385
2022-05-12 15:22:18 -07:00
Matt Bierner 3ba66bf24f
Use explicit empty authority for JS/TS resources (#149125)
Fixes #149123

10c8c1c2cc made sure we sync over the authority of in-memory resources over to TS Server. However if a resource does not have an authority, this resulted in a url with `scheme//path` instead of `scheme/authority/path`

TS would then normalize the uri to `scheme/path`, resulting in us considering this a new resource

This fix adds an explicit empty authority that we use in this case instead
2022-05-09 15:52:52 -07:00
Matt Bierner 10c8c1c2cc
Include authority in TS in-memory scheme (#148940)
For #146853

Make sure we include the uri authority when serializing and then restoring the file paths we send to TSServer (similarly to how we already handle the uri scheme)
2022-05-06 11:48:53 -07:00
Andrew Branch 076bb03cb4
No commit characters for string completions (#148597) 2022-05-03 13:36:20 -07:00
Matt Bierner 17ee4c4265
Pick up TS 4.7 for bundling with VS Code 2022-05-02 15:50:42 -07:00
Andrew Branch e9e3ca02ef
Add flags to completions telemetry (#148313) 2022-04-30 17:57:13 -04:00
Matt Bierner 1d2461bed6
Sort 2022-04-21 22:23:48 -04:00
Andrii Dieiev 7e887b76ea
Fix version in error message (#147750) 2022-04-20 09:40:18 -07:00
Matt Bierner d851ea5d49
Add 'go to source definition' command
Fixes #147532

Requires TS 4.7+
2022-04-19 19:32:19 -07:00
Matt Bierner 977c9c9f98
Revert "Always use nameSpan for code lenses"
This reverts commit d218b48067.

Fixes #147154
Fixes #146818

TS still needs to make tweaks before we can remove this logic
2022-04-13 12:00:06 -07:00
Matt Bierner a52e45add2
Don't show busy for JS/TS files not in workspace
Fixes #145309
2022-04-05 17:03:12 -07:00
Matt Bierner 464e50f207
Use more consistent method names 2022-03-31 11:56:37 -07:00
Matt Bierner 8d5ae2bdd9
Add auto enum case for ts.locale
Fixes #146436
2022-03-31 11:56:36 -07:00
Gabriela Araujo Britto 88e3d49156
support label details (#146270) 2022-03-30 15:27:50 -07:00
Gabriela Araujo Britto 4e159b9e28
[typescript-language-features] Add includeCompletionsWithObjectLiteralMethodSnippets preference (#145941)
* create flag for object literal method snippet completions

* reword description
2022-03-24 15:17:43 -07:00
Logan Ramos 9b7268acf9
Update telemetry module 2022-03-18 11:34:33 -04:00
Matt Bierner 7ba9564ac6
Use correct casting when working with Object.freeze
Casting the result of Object.freeze results in a non-readonly object. Instead we should pass the type along to the call to `Object.freeze`
2022-03-16 16:00:32 -07:00
Robo 32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Matt Bierner 71c0686d04
Use lowercase preserve for jsxemit
This matches what the tsconfig schema expects
2022-03-09 14:38:13 -08:00
Matt Bierner b3832713db
Use esnext as implicit js/ts module
For https://github.com/microsoft/TypeScript/issues/46698

Also adds new settings for the target and module in implicit projects
2022-03-09 14:33:37 -08:00
Matt Bierner 9d41c706c6
Allow manually restarting TS Server even if it has crashed too many times
Currently if the server crashes too many times, the user has to restart VS Code. It's possible the user could fix something (such as a bad plugin) and then run this command to just restart the server without needing to restart the entire editor
2022-03-08 18:48:48 -08:00
Matt Bierner 886ab06860
Try to have more explicit error when we don't have a server
Fixes #143032

This change removes a call that would automatically restart the TS server when invoking a command. Instead we now return a `NoServer` response

When this happens, the server still should be restarted. This change stops us from logging a large number of errors when we get into this state where the server has crashed too many times and we no longer want to automatically restart it
2022-03-08 18:48:48 -08:00
Matt Bierner eb6050d8a8
Preserve path item details for JS/TS completions
Fixes #144455
2022-03-08 14:33:26 -08:00
Ondrej Medek 529cc9c859
fix markdownDescription for javascript.suggest.jsdoc.generateReturns (#144486) 2022-03-07 17:12:55 -08:00
Matt Bierner 5c452f8973
Use [].flat() 2022-03-03 15:03:33 -08:00
Matt Bierner 1900abc88b
while -> for 2022-03-01 16:39:41 -08:00
Matt Bierner ea76090229
Remove support for old plugin based semantic token responses
We removed support for the plugin a few iterations ago so this branch should no longer be active
2022-03-01 16:38:37 -08:00
Matt Bierner fb292d9a46
Cleanup semantic tokens provider
- Don't modify params
- mark public
- Use standard api version object
- remove extra disposable
- Don't use declare for const enums
2022-03-01 16:38:36 -08:00
Matt Bierner e6d702383d
Remove experimental protocol stubs 2022-03-01 16:38:36 -08:00
Matt Bierner a068ebee8d
Finalize markdownstring.baseUri
Fixes #142051
2022-03-01 15:48:53 -08:00
Matt Bierner e04c70a676
Fix TS resolved paths when on vfs
For #136433

These paths always have to start with `/`
2022-02-28 17:27:43 -08:00
Matt Bierner c662fe67bf
Bump default target for jsconfig template 2022-02-28 15:16:39 -08:00
Matt Bierner 062b82c1bc
Use .test instead of .match 2022-02-28 14:27:47 -08:00
Matt Bierner 1d77856203
Use ?.forEach instead of ( || []).forEach 2022-02-28 13:52:59 -08:00
Matt Bierner 6f63577e80
Remove unused event 2022-02-28 13:46:52 -08:00
Matt Bierner 2fc747419d
use ?. 2022-02-28 13:44:48 -08:00
Matt Bierner cf898ff7d1
null -> undefined 2022-02-28 13:43:18 -08:00
Matt Bierner 70dd24e9bd
Remove extra check
This should not be nullable
2022-02-28 13:43:18 -08:00
Matt Bierner d218b48067
Always use nameSpan for code lenses
Fixes #143648

The nameSpan property has existed for something like years or so, so it should be safe to use. There's currently not a good way to request the reference count of an anon function and I don't think this is actually useful to show since the ref count should always be 1 for these
2022-02-28 13:43:16 -08:00
Matt Bierner ee9c87ccca
Clean up logged messages 2022-02-24 14:28:27 -08:00
Matt Bierner 2a72cf7070
Restore 'follow link' text on tsconfig links
For #141112
2022-02-24 14:02:38 -08:00
Robo df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Matt Bierner 932976b8d2
Fix return type typing 2022-02-22 16:22:55 -08:00
Matt Bierner ad0311a25a
Improve quote style setting display
Follow up on #143164
2022-02-16 12:13:45 -08:00
Matt Bierner 1f5f486ccb
Add note about quote style setting to jsxAttributeCompletionStyle
For #143164
2022-02-16 12:13:45 -08:00
Matt Bierner 3ecc99a3f5
Format switch using braces 2022-02-09 14:49:13 -08:00
Matt Bierner ca6c806af5
Adopt busy for TS intellisense status
For #141269
2022-02-09 14:49:13 -08:00
Johannes Rieken b7955eac38
finalize inlay hints provider API, https://github.com/microsoft/vscode/issues/16221 2022-02-09 15:32:46 +01:00
Matt Bierner 36ee187589
Surface TS code action desc in completions
Fixes #141591
2022-02-08 17:11:48 -08:00
Robo 01df559c18
chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Johannes Rieken 17ed7bf82c
finalize LanguageStatusItem API, https://github.com/microsoft/vscode/issues/129037 2022-02-08 18:50:46 +01:00
Johannes Rieken 765d2ef252
add doc for padding-left/right, add doc for inlay hint kind but also remove InlayHintKind#other, https://github.com/microsoft/vscode/issues/16221 2022-02-08 18:37:43 +01:00
Johannes Rieken 627d46551d
support double click gesture on inlay hints, API polish, https://github.com/microsoft/vscode/issues/16221 2022-02-05 14:25:37 +01:00
Matt Bierner df09257f2e
Make sure we pass along windows style paths to pluginProbeLocations 2022-02-03 17:10:43 -08:00
Matt Bierner 2b92835853
Move js/ts language configs to json file
Fixes #125748
2022-02-03 11:38:09 -08:00
Raymond Zhao 9b75370b4a
Modify click-here link on type init fail msg
Ref #140059
2022-02-03 10:52:52 -08:00
Matt Bierner 571a3c3a55
Don't try tacking on a tsconfig.json if the file already has a json ext 2022-02-03 09:59:10 -08:00
Matt Bierner 92616196f8
💄 2022-02-03 09:59:10 -08:00
Matt Bierner 94a3d96861
Fix missing semicolons 2022-02-03 09:59:10 -08:00
Matt Bierner 820c2b3a12
Update yarn lock 2022-02-03 09:37:29 -08:00
Vitaly c134702cc4
Resolve correct link path for tsconfig.extends (#141062)
* fix(ts-features-extension): resolve correct path for `extends` of tsconfig
fixes #131643

* always provide link. add command to resolve the link path on click

* cleanup
just make the code cleaner

* revert `yarn.lock` changes

* pretending eslint

* use `vscode.open`

* don't add `.json` to path if it's already here
this change better conforms the TS resolving algorithm (see the reference)

* style: move `resolveNodeModulesPath` to top level

* don't show falsy errors on absolute paths

* improve resolveNodeModulesPath impl
- fixed a bug with infinite loop
- check for module existence once per level
2022-02-03 09:37:00 -08:00
Matt Bierner 69896100ed
Add MarkdownString.baseUri proposal (#142055)
For #142051
2022-02-03 08:51:49 -08:00
Andrew Jones 9dc211a499
fix indentation (#141997)
* fix indentation

* add tests

* make regex valid
2022-02-02 19:51:57 -08:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Matt Bierner 90b50dc7e2
Use ?. in a few more places 2022-02-01 13:59:12 -08:00
Martin Aeschlimann d971263085
remove the last typescript-vscode-sh-plugin references 2022-02-01 17:38:36 +01:00
Matt Bierner ce119308e8
Allow using language override for more js/ts settings
Fixes #141912
2022-01-31 18:03:51 -08:00
Matt Bierner c2af7753f6
Mark some JS/TS prefs as language-overridable
Fixes #139864
2022-01-31 17:48:45 -08:00
Matt Bierner 1ab6e6fd06
Pass in doc instead of doc uri 2022-01-31 17:41:03 -08:00
Matt Bierner c33f53e1f2
Pass language desc around instead of modeid 2022-01-31 17:21:55 -08:00
Matt Bierner 2a1274e4a9
Pass around language desc object instead of ids 2022-01-31 17:21:55 -08:00
Matt Bierner babda1e42e
Align name of languageIds with vscode api 2022-01-31 17:21:55 -08:00
Matt Bierner 42914f99ab
Scope JS/TS inlay hints settings per-resource
Fixes #140414
2022-01-31 17:21:54 -08:00
Matt Bierner 967370319a
Remove export 2022-01-25 12:55:37 -08:00
Tyler Leonhardt e15397d2bb
finalize quickpick API 2022-01-21 14:08:20 -08:00
Logan Ramos c047af40b2
Fix compilation 2022-01-19 16:18:14 -05:00
Logan Ramos b22ee20028
Move to @vscode/extension-telemetry 2022-01-19 15:57:17 -05:00
Johannes Rieken 8ef8933a1a
incorporate API feedback, https://github.com/microsoft/vscode/issues/16221 2022-01-19 09:23:48 +01:00
Matt Bierner b39c8e9989
Avoid not null assertion and use joinPath 2022-01-18 16:42:42 -08:00
Matt Bierner 789bdb8189
Use more specific return type in provider 2022-01-18 16:42:42 -08:00
Matt Bierner c62c36dea3
Remove extra assertions 2022-01-18 16:42:41 -08:00
Benjamin Pasero e3cf7e5e1b
API: Allow to use the file watcher for aribitrary folders (#3025) (#139881)
* API: Allow to use the file watcher for aribitrary folders (#3025)

* fix tests

* update `createFileSystemWatcher` docs

* refuse to watch resources that are watched in workspace already

* properly check proposed API

* make it work via `createFileSystemWacher` (first cut)

* more docs

* cleanup

* enable recursive watching based on pattern

* add tests

* drop out-of-workspace events when using simple patterns

* do not apply excludes when watchig files

* log extension watch requests

* also log unwatch

* improved exclude handling

* more docs

* drop proposed api needs

* remove `suite.only`

* cannot watch inside workspace more than once

* do not send extension decriptor over

* adopt latest changes

* add `baseUri` to relative pattern

* backwards compat
2022-01-13 13:32:03 +01:00
Matt Bierner fd745e79f5
Enable passing TSServer plugins to TSServer on web
For #140455

This does not actually enable this feature but a first step for it. Requires work on the TS side to actually get working
2022-01-10 19:33:31 -08:00
Matt Bierner c42d0864dc
Remove extra newline for TS Server log on web 2022-01-10 19:33:30 -08:00
Matt Bierner deb9abe55e
Use node ipc for communication with TS Server (#135341)
* Use node ipc for communicating with TS Server

For https://github.com/microsoft/TypeScript/issues/46417

* Don't use ipc for stdio of we're not using ipc

* Use node ipc for communicating with TS Server

Fixes #85565
2022-01-10 14:36:23 -08:00
Matt Bierner 9ed5a855c1
Add support for office-script virtual file system 2022-01-05 14:53:44 -08:00