Commit graph

119912 commits

Author SHA1 Message Date
Ulugbek Abdullaev 40565ce894 rename suggestions: feat: implement new UX 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 04f0647a59 rename suggestions: fix: arrow up works always 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 3de62000fd rename suggestions: refactor: use a DeferredPromise 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 1fb761447d rename suggestions: refactor: better name 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev f219b35392 rename suggestions: refactor: don't apply editor font to rename input field label because it's 'workbench' font 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 84bb33091b rename suggestions: refactor: don't use a setter for a method mutating stuff 2024-03-18 14:36:30 +01:00
Henning Dieterichs 889093bb7a Fixes diff gutter styling issues
Signed-off-by: Henning Dieterichs <hdieterichs@microsoft.com>
2024-03-18 13:16:10 +01:00
Robo 7c21685343
fix: legacy server stage dependency for CI builds (#207994) 2024-03-18 12:12:23 +01:00
Don Jayamanne 1b4e4196b0
Better timeline title for cell metadata changes (#207972) 2024-03-18 12:02:41 +01:00
Benjamin Pasero 568fe88e69
aux window - try to mitigate custom editor claim across windows (#207992) 2024-03-18 11:37:18 +01:00
Sandeep Somavarapu e1ce54ff03
fix installing and watching workspace extensions (#207983)
* fix installing and watching workspace extensions

* fix tests and debounde listening
2024-03-18 11:11:40 +01:00
Robo 1413fc87a7
feat: create and upload legacy remote server (#204139) 2024-03-18 11:09:55 +01:00
David Gileadi c800bf9216
Introduce minimap section headers, a la Xcode (#190759)
* WIP for adding minimap section headers for #74843

* Get section headers rendering

* Fix default value of section header font size

* Fix tests

* Improve section header position

* Fix separator display, update after config change

* Split too-long headers with an ellipsis

* Render section headers on the decorations canvas

* Support MARK with just a separator line

* Calculate minimap section headers asynchronously

* Simplify change

* Avoid font variable duplication

* Fix issue introduced earlier

* Recompute section headers when the language configuration changes

* Fix problem in constructing region header range

* Parse mark headers in the entire file and then filter out the ones not appearing in comments on the UI side, where tokens info is available

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-18 08:49:27 +00:00
Benjamin Christopher Simmonds cda53a0627
Add single view pane container title support (#207816)
Chat title
2024-03-18 09:49:23 +01:00
Benjamin Pasero 5412743dcb
working copy - allow to shutdown even with dirty changes and no backup (#207974) 2024-03-18 08:00:51 +01:00
Don Jayamanne 9ccb0fa738
Remove dead code (type IOutputRequestDto) (#207971) 2024-03-17 21:16:10 -07:00
Don Jayamanne 9f25e63114
Re-order Cut/Copy/Paste in the Cell context menu (#207963) 2024-03-18 04:14:04 +01:00
Don Jayamanne b216b43c2f
Shift+PageUp/Down to select NB output contents (#207962) 2024-03-18 00:37:02 +01:00
Don Jayamanne 8c7cf6a7ad
Support Ctrl+A in notebook outputs (#207548)
* Support Ctrl+A in notebook outputs

* Better handling of outputs

* oops

* Better determination of outputId
2024-03-18 00:31:17 +01:00
Daniel Imms aefe7e830c
Merge pull request #207952 from microsoft/tyriar/instance_cleanup
Reuse write code in _onProcessData
2024-03-17 13:03:11 -07:00
Daniel Imms 08159ae502
Reuse write code in _onProcessData 2024-03-17 09:55:35 -07:00
Benjamin Pasero ca90b8ec28
aux window - drop buggy AuxWindowUnsupported capability
This needs a different approach, likely on the level of custom editors itself. Given custom editors are to implement backups, moving between windows should actually not result in data loss in most cases.

For custom editors that ignore backups, a better approach would be to throw an error or force to save right before a `webview` is about to get disposed because it moved to another window.
2024-03-16 09:44:48 +01:00
Jan Niklas Hasse 997212d6c0
Use indentSize instead of tabSize for LineCommentCommand (#193811)
Tab size and indent size were separated in #155450, but for deciding
where to put "//" or "#" when toggling a line comment tab size was still
used.

Fixes #170393.

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-16 01:52:14 +01:00
Fred Silberberg c7578a3366
Do not trim whitespace when part of strings or regexes (#198164)
* Do not trim whitespace when part of strings or regexes

Fixes https://github.com/microsoft/vscode/issues/195010. If the token to be removed is part of a string or a regex, then we do not want to remove the character, as it is very likely semantically important.

* Address initial feedback:

1. Add a new setting to control whether to trim whitespace in multiline strings/regexes. This setting is then piped through to everywhere that is calling trim whitespace, which is file save editing, the trim whitespace command, and notebooks.
2. Force line tokenization to complete when the setting is enabled so that trim is accurate.

* Don't force tokenization; instead, check to see if there are tokens for a given line and do not format if there are none.

* Look for syntactical tokens

* Fix compilation errors

* Add a test

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2024-03-16 00:43:15 +00:00
hu de yi 7caab31bf4
editor paste event result return ClipboardEvent (#192732)
* editor paste event result return ClipboardEvent

* Remove commented out code

* Cleanup `applyDefaultPasteHandler`

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-03-16 00:42:52 +00:00
James Yang e1acb1bbb5
feat: add ipcLogger and timeoutDelay for IPCServer (#193896)
* feat: add ipcLogger and timeoutDelay for IPCServer

* 💄

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-15 23:56:59 +00:00
Rob Moran b7bfbefe35
Update extensionPaths when web extension host started (#193849)
* Invalidate and update extensionPaths on load

* Also update the `ExtensionPaths` search tree after startup because it applies an extension delta

* Cache realpath calls

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-16 00:56:36 +01:00
Daniel Imms 32b939e4d8
Merge pull request #207892 from microsoft/tyriar/cleanup
Remove unwanted comment, improve name
2024-03-15 15:29:49 -07:00
Daniel Imms 7583d9899d
Remove unwanted comment, improve name 2024-03-15 15:14:37 -07:00
Daniel Imms 2f4d129163
Merge pull request #207891 from microsoft/tyriar/207372
Move TerminalMainContribution back to block startup
2024-03-15 15:12:41 -07:00
Daniel Imms ca3acd1090
Merge pull request #207888 from microsoft/tyriar/207488
Simplify terminal chat layout, fix width of content
2024-03-15 15:02:01 -07:00
Daniel Imms 3292991f20
Register disposables 2024-03-15 14:57:55 -07:00
Daniel Imms 1b760ca082
Move TerminalMainContribution back to block startup
Fixes #207372
2024-03-15 14:56:38 -07:00
Daniel Imms af87eacc15
Remove unused import 2024-03-15 14:47:35 -07:00
Peng Lyu a737ec76d4
Avoid kb conflicts with inline chat (#207890) 2024-03-15 22:47:05 +01:00
Daniel Imms e8fd06fba1
Merge pull request #207889 from microsoft/limitSplit
Limit splits of `=` for environment variables.
2024-03-15 14:44:36 -07:00
Daniel Imms b2b2dc1e68
Handle resizing off screen 2024-03-15 14:38:03 -07:00
Peng Lyu 5ac16f437f
Merge pull request #207887 from microsoft/rebornix/diplomatic-crab
Adopt InlineChatWidget in notebook and fix UI glitches.
2024-03-15 14:35:15 -07:00
Tyler James Leonhardt ce0b797bdb
Temporary solution to enable an "All Files" option in the #file variable (#207886) 2024-03-15 22:34:23 +01:00
Daniel Imms c2be0c1f7f
Remove hardcoded 400px
Fixes #207488
2024-03-15 14:31:36 -07:00
Daniel Rosenwasser 250211e505 Limit splits of '=' for environment variables. 2024-03-15 21:25:03 +00:00
Peng Lyu 61af42e8c0 Adopt InlineChatWidget in notebook 2024-03-15 14:18:22 -07:00
Peng Lyu cf5ebe5a55 Update inline chat input width when toolbar width change. 2024-03-15 14:17:47 -07:00
Rob Lourens b58f46da6f
Add API warning to defaultImplicitVariables (#207883)
Add proposed API warning to defaultImplicitVariables
2024-03-15 21:45:51 +01:00
Tyler James Leonhardt c99ae85c1e
Fix a couple style issues (#207873)
* no more pointy bottom corners of quick pick
* quick pick items have some padding again
* inherit radius instead of hard coding pixels
2024-03-15 12:30:59 -07:00
Benjamin Pasero 2fed6fa574
aux window - pick the right editor part (#207874) 2024-03-15 12:30:35 -07:00
Benjamin Pasero fedccb4ec1
aux window - override user-agent styles for tables for extensions editor (#207876) 2024-03-15 20:30:13 +01:00
Daniel Imms ad28dbfbc9
Simplify terminal chat layout
Part of #207488
2024-03-15 12:24:00 -07:00
Benjamin Pasero 070af85e73
commands - log error when history is invalid (#207706) (#207871) 2024-03-15 12:13:22 -07:00
Connor Peet ebfab45007
testing: colorize ansi codes in plain text test messages (#207852)
* testing: colorize ansi codes in plain text test messages

Closes #207750

* remove ansi removal
2024-03-15 11:58:41 -07:00