Commit graph

1124 commits

Author SHA1 Message Date
Matt Bierner 143bebfbb4 Use em for code font size instead of rem
This fixes some cases where a user style sheet may be setting a weird base font-size.
2019-05-29 15:44:48 -07:00
Matt Bierner f3b8d15b0d Add DocumentLink.tooltip api proposal
For #72824
2019-05-23 17:57:04 -07:00
Matt Bierner 71deb5b6ee Extend disposable 2019-05-22 15:25:48 -07:00
Matt Bierner 519eb3690c Extract duplicated escaping code 2019-05-22 15:25:48 -07:00
Matt Bierner f250d19bb5 Use relative size for markdown code font size
Fixes #74125
2019-05-22 10:53:49 -07:00
Howard Hung 0ddd999172 Fix typo: showSecutitySelectorForResource -> showSecuritySelectorForResource 2019-05-22 01:25:59 +08:00
Matt Bierner 4470b868a3 Check pending version before updating markdown preview content
For #72671
2019-04-29 13:49:36 -07:00
Matt Bierner 6b2daa3388 Revert marking markdown extension with explicit kind 2019-04-22 21:05:16 -07:00
Matt Bierner 5ae3178c1d Mark markdown as a ui extension 2019-04-15 15:28:03 -07:00
Matt Bierner 312b09cc6b extract setContent 2019-04-12 14:43:14 -07:00
Matt Bierner 74103c4c8d Don't change preview when click fails but do show an alert 2019-04-12 14:43:14 -07:00
Matt Bierner 3b58a011da Only try/catch openTextDocument 2019-04-12 14:43:14 -07:00
Matt Bierner c79f1cd8e3 Styling 2019-04-12 14:43:14 -07:00
pkoushik bda2870db9 fix-71570 Fixed localize string issue 2019-04-06 12:19:10 +05:30
pkoushik 10a4ebf006 Merge remote-tracking branch 'upstream/master' into fix-71570
* upstream/master: (34 commits)
  Fix markdown.styled regression caused by Uri.parse changes
  Process explorer refactoring
  fix compile error
  fix open workspace uri from cli
  Delete deprecated search provider stub
  test dependenices are devDependencies
  Fix default uri when scheme is file
  disable flaky test, #71801
  use `readonly T[]` instead of `ReadonlyArray<T>`
  simplify protocol check
  Let enablment service handles local workspace extensions in remote window
  debt - make ext host init data more complete
  Fix colorization tests
  fixes #71671
  Update grammars
  Add yes-no choice for overwriting existing file for save as
  update distro
  ExtensionEnablementService: - Remove getDisabledExtensions and instead use isEnabled or getEnablementState methods
  Simplify reload action and fix test
  Update distro hash
  ...
2019-04-06 12:17:00 +05:30
Matt Bierner f44e51ed38 Fix markdown.styled regression caused by Uri.parse changes
Fixes #71802

Uri.parse now defaults to a `file` scheme, which broke this code
2019-04-05 16:05:32 -07:00
pkoushik 3cef5067be fix-71570 Added logic to handle markdown preview update on file rename and delete 2019-04-05 11:38:18 +05:30
Matt Bierner 86fe4b3b1c 💄 2019-04-03 11:37:19 -07:00
Matt Bierner 0ec326531e Use flatten array helper 2019-04-02 17:16:10 -07:00
Matt Bierner d655e6f726 Make sure we always include uriScheme in knownSchems for markdown 2019-04-02 16:27:22 -07:00
Matt Bierner 37c9a750b0
Merge pull request #71442 from vitaliymaz/fix-markdonw-re-render
re-rendering Markdown preview when updated extra configurations provided by extension
2019-04-02 11:03:59 -07:00
Evan Bovie 8c1079b443
Add vscode-insiders URI prefix to knownSchemes in links.ts 2019-04-02 10:23:39 -07:00
Vitaliy Mazurenko e40d72b1b5 re-rendering Markdown preview when updated extra configurations provided by extension 2019-04-01 10:52:23 +03:00
Evan Bovie 13948796f3
Add vscode: URI prefix to knownSchemes in links.ts 2019-03-28 12:36:37 -07:00
Matt Bierner f62d1f25f3 Only show the markdown refresh preview command when preview is active or you are in a markdown file 2019-03-01 16:06:51 -08:00
Matt Bierner 877bb6f5d8 Remove tommorow theme from registrations.
Fixes #63564

We only use highlight.js which includes a theme based on tommorw, we do not use the tommorow theme repository directly.
2019-02-22 16:04:08 -08:00
Matt Bierner fe01a19db1 Revert change accidentially include in check in 2019-02-20 13:56:58 -08:00
Matt Bierner 178327770c Add lightbulb badge when a preferred fix is available
Fixes #66702
2019-02-20 13:36:44 -08:00
Matt Bierner 003521e715 Fix markdown preview restoring to wrong position on restart 2019-02-14 18:24:01 -08:00
Johannes Rieken c110d84460 fix integration test 2019-02-08 18:03:56 +01:00
Alex Dima f15a6faaca Try to fix Markdown 2019-02-07 09:53:52 +01:00
Benjamin Pasero e2d1fd06d1 debt - update extensions node dependency to 10.x 2019-02-07 08:49:36 +01:00
Matt Bierner 6ca137730b Extract 2019-02-06 14:04:24 -08:00
Matt Bierner 198e6a55e7 Make sure we dispose of event emitters properly 2019-02-06 14:04:24 -08:00
Matt Bierner 6b8b1b7bea Improve naming 2019-02-06 14:04:24 -08:00
Matt Bierner 038e8d3904 Make markdown extension points dynamic
For #67574

Blocked by #67958
2019-02-05 17:45:11 -08:00
Matt Bierner 8f10101dd4 Create base class for disposable objects 2019-02-05 17:45:11 -08:00
Matt Bierner 476d7fe0ab Refactor markdown contributions
Reducing code duplication and reducing state
2019-02-05 16:56:45 -08:00
Matt Bierner c79a8bf7eb Remove stray log
:)
2019-02-01 14:45:26 -08:00
Matt Bierner c1c3e5eab0 Properly encode markdown file path for open links
Fixes #59523

Double encode the path so that `Uri.parse`'s decoding only strips out the first level of encoding
2019-01-28 15:45:42 -08:00
Matt Bierner 4fe1cdc4df
Merge pull request #66958 from flurmbo/detect-md-image-link
Detect md image link
2019-01-25 17:46:47 -08:00
Phil Marshall 4c2d33559f lazy quantifiers for linkPattern regex 2019-01-25 19:07:45 -06:00
Phil Marshall ef66e5fab1 tweaked linkPattern regex to pass new tests 2019-01-25 18:55:42 -06:00
Phil Marshall a7c88d79a2 updated test for switched order and new tests for image link 2019-01-25 18:46:28 -06:00
Phil Marshall 9070abedaf image link should be pushed to results before other link 2019-01-25 18:45:06 -06:00
Matt Bierner 7f1745027b Re-use options from markdown engine instead of creating new options object
Fixes https://github.com/mjbvz/vscode-markdown-mermaid/issues/26
2019-01-25 11:48:25 -08:00
Phil Marshall 5fdc5c2675 factor documentlink extraction into separate function 2019-01-24 17:25:09 -06:00
Phil Marshall b1de159292 added test for markdown image link underline 2019-01-22 18:46:55 -06:00
Phil Marshall d372fa0697 md extension should underline images used as link description 2019-01-22 18:46:46 -06:00
Matt Bierner 59ce7f3b28 Fix markdown preview code highlighting
Fixes #66772
2019-01-21 14:09:30 -08:00
alexet 0798d13f10 Remove duplicate character from regex class 2019-01-16 17:56:17 +00:00
SteVen Batten ccdd2997a6
update AI module (#66370)
fixes #64849
2019-01-10 17:43:25 -08:00
Matt Bierner 344f4fa361 Make sure we update the markdown document on config changes 2019-01-09 19:32:53 -08:00
Matt Bierner 758280cc47 Extract TokenCache 2019-01-09 19:27:41 -08:00
Matt Bierner 5496ba7617 Prevent possible race while initilizing markdown engine 2019-01-09 19:18:23 -08:00
Matt Bierner 1bbc0e3b4d Deprecate the previewFrontMatter setting
Switch to always hiding the frontmatter and then allowing markdown-it plugins to render it properly if they wish. `previewFrontMatter: "show"` is also not very useful since it usually results in a jumble of text at the top of the file

This is required with the new performance work to avoid re-tokenizing the document  multiple times during rendering
2019-01-09 19:05:55 -08:00
Matt Bierner e325cce9bc Fixing markdown unit tests 2019-01-09 18:15:34 -08:00
Matt Bierner 9140285092
Merge pull request #65953 from skprabhanjan/fix-65575
Fix-65575 MarkdownIt plugins (or Rules) called multiple times for one input
2019-01-09 17:41:47 -08:00
pkoushik a6b761b033 fix-65575 Updated tokenize method - Returns cached token if exists or newly created token and cache it 2019-01-08 15:22:29 +05:30
pkoushik eabf436c07 fix-65575 tokenize method cache update bug fixed 2019-01-04 20:13:27 +05:30
pkoushik 661d191638 fix-65575 tokenize method added 2019-01-04 20:07:21 +05:30
Benjamin Pasero 83232ef060 fonts - remove HelveticaNeue-Light from list 2019-01-04 10:11:04 +01:00
Matt Bierner 5cc00861fc Enable no-var-keyword tslint rule 2019-01-03 18:02:48 -08:00
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
pkoushik 1ef045875d fix-65575 Added CachedToken and implementation to use it 2019-01-03 11:56:11 +05:30
Matt Bierner cba84fba5e Take progress within element into account for markdown scroll sync
Fixes #65504
2019-01-02 14:36:16 -08:00
Matt Bierner 7086fb76ec Take document as parameter instead document components 2019-01-02 11:56:39 -08:00
Matt Bierner 23508cf1a0 Update markdown dependencies 2018-12-19 13:40:54 -08:00
Prabhanjan S Koushik 55ebf93842 fix-65287 Added webviewManager.refresh() (#65396) 2018-12-19 11:05:57 -08:00
Matt Bierner 54386cc1f4 Fix word pattern
Too much escaping :0
2018-12-12 15:30:49 -08:00
Matt Bierner 66e07e14a4 Fix regexp 2018-12-12 15:18:46 -08:00
Matt Bierner a637dd7261 Avoid unicode regexp literal
This breaks our minifier step
2018-12-12 13:27:08 -08:00
Matt Bierner a2078fd559 Strict null auto add 2018-12-11 12:50:45 -08:00
Matt Bierner 100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Matt Bierner f52f29d65e Add typings for markdown preview messages 2018-12-04 15:54:53 -08:00
Matt Bierner a2893ce678 Fix markdown fragments when opening file in workspace
Fixes #64141
2018-12-04 15:42:17 -08:00
Matt Bierner 1feed6a23c Delete unused typings file 2018-11-29 10:44:27 -08:00
Prabhanjan S Koushik e05aa178d6 Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..." (#63936)
* fix-63749 - Added UNICODE_NEWLINE_REGEX

* fix-63749 - Removed .skip for the test method

* fix-63749 Moved Replace to parse
2018-11-29 09:09:36 -08:00
Matt Bierner 2f9f0c35cc Added failing test for #63749
Add skipped test for #63749 so someone can pick this up
2018-11-27 12:02:39 -08:00
isidor 1e3efda93c polish cgmanifest.json 2018-11-20 17:02:09 +01:00
isidor 9edd984da8 delete OSSREADME.json 2018-11-20 12:54:22 +01:00
Alex Dima 976cfe3aa7 Merge branch 'master' into isidorn/cgmanifest 2018-11-16 17:52:27 +01:00
isidor 2ba92aa3e8 add commitHash to cgmanifest 2018-11-15 17:43:46 +01:00
isidor 347fb6347b add all cgmanifests. Still no commitHash 2018-11-14 18:18:25 +01:00
Matt Bierner 4737e3efd1 Fixing TS 3.2 compile errors 2018-11-13 17:13:15 -08:00
ImgBotApp d412f89baf
[ImgBot] Optimize images
*Total -- 201.93kb -> 142.81kb (29.28%)

/extensions/npm/images/npm_icon.png -- 3.21kb -> 0.51kb (84.1%)
/src/vs/workbench/parts/debug/electron-browser/media/stepout-tb.png -- 2.89kb -> 0.47kb (83.83%)
/src/vs/workbench/parts/debug/electron-browser/media/stop-tb.png -- 1.50kb -> 0.35kb (76.43%)
/src/vs/workbench/parts/debug/electron-browser/media/pause-tb.png -- 1.55kb -> 0.37kb (76.34%)
/src/vs/workbench/browser/parts/editor/media/forward-tb.png -- 1.57kb -> 0.37kb (76.25%)
/src/vs/workbench/browser/parts/editor/media/back-tb.png -- 1.52kb -> 0.37kb (75.53%)
/src/vs/workbench/parts/debug/electron-browser/media/continue-tb.png -- 1.60kb -> 0.42kb (73.48%)
/src/vs/workbench/parts/debug/electron-browser/media/stepinto-tb.png -- 1.66kb -> 0.47kb (71.51%)
/src/vs/workbench/parts/debug/electron-browser/media/restart-tb.png -- 1.91kb -> 0.59kb (68.84%)
/src/vs/workbench/parts/debug/electron-browser/media/stepover-tb.png -- 1.93kb -> 0.62kb (67.75%)
/resources/linux/code.png -- 5.76kb -> 2.66kb (53.86%)
/extensions/html-language-features/icons/html.png -- 4.40kb -> 2.28kb (48.15%)
/extensions/theme-seti/icons/seti-circular-128x128.png -- 8.73kb -> 4.70kb (46.12%)
/extensions/typescript-language-features/icon.png -- 1.60kb -> 0.97kb (39.15%)
/src/vs/platform/extensionManagement/node/media/defaultIcon.png -- 1.65kb -> 1.03kb (37.49%)
/src/vs/workbench/parts/extensions/electron-browser/media/defaultIcon.png -- 1.65kb -> 1.03kb (37.49%)
/extensions/vscode-api-tests/testWorkspace/sub/image.png -- 35.87kb -> 24.99kb (30.33%)
/extensions/vscode-api-tests/testWorkspace/image.png -- 35.87kb -> 24.99kb (30.33%)
/resources/win32/code_150x150.png -- 0.55kb -> 0.39kb (29.96%)
/extensions/css-language-features/icons/css.png -- 5.07kb -> 3.63kb (28.37%)
/extensions/json-language-features/icons/json.png -- 5.84kb -> 4.33kb (25.89%)
/extensions/markdown-language-features/icon.png -- 1.19kb -> 0.88kb (25.86%)
/src/vs/workbench/parts/extensions/electron-browser/media/theme-icon.png -- 9.90kb -> 7.42kb (25.1%)
/extensions/php-language-features/icons/logo.png -- 10.85kb -> 8.99kb (17.13%)
/extensions/gulp/images/gulp.png -- 7.36kb -> 6.20kb (15.8%)
/extensions/merge-conflict/resources/icons/merge-conflict.png -- 2.47kb -> 2.10kb (14.96%)
/extensions/jake/images/cowboy_hat.png -- 43.85kb -> 41.67kb (4.98%)
2018-11-06 20:46:03 +00:00
Matt Bierner e21df781db Treat data: as a known markdown link scheme
Fixes #62142
2018-10-30 11:34:33 -07:00
Matt Bierner b72c349e05 Don't try re-encoding vscode-resoure markdown links
Fixes #60374

Some markdown-it extensions end up reprocessing the same tokens multiple times. This can result in our link normalized being re-invoked on a link, which causes it to fail

Fix to to make sure that `vscode-resource` is a recongized link so that we don't try re-normalizing in these cases
2018-10-29 16:18:11 -07:00
Matt Bierner 907924abc0 Reveal absolute top of markdown preview when scrolling to line 0
Fixes #61816
2018-10-25 11:57:50 -07:00
Matt Bierner fe63c7e2f2 Reveal line 0 in editor when markdown preview scrolls to top
Fixes #61815
2018-10-25 11:57:50 -07:00
Johannes Rieken b343fcf6ab declare proposed api usage only where actually being used 2018-10-24 12:27:59 +02:00
Sankt Petersbug f2653c04cb Fix Markdown Preview incorrectly encodes a link (#61530)
For known external scheme, the customized normalizeLink method use vscode.Uri to parse and create
the string representation of the link before caling the original normalizeLink method.
The toString method of vscode.Uri encodes the result by default, and this is unecessary since encoding
is handled by the original normalizeLink method.

Calls toString method with skipEncoding option.

Resolves: #60525
2018-10-22 15:41:22 -07:00
Ahmed Atito 6944a221c3 🐛 - Support C# in markdown preview code block syntax highlighting. (#61291) 2018-10-19 15:13:44 -07:00
Matt Bierner 1b812bade4 Don't re-encode markdown styles http uris
Fixes #60742

These uris should already be encoded. Don't try encoding them again which may cause the uri to become invalid
2018-10-17 18:49:18 -07:00
Ramya Achutha Rao a975e59eaf Update applicationInsights for #60585 2018-10-16 16:29:08 -07:00
Matt Bierner 9e017425b3 Replace markdown-named-headers with custom version
Fixes #47537

Use our own version of markdown named headers. This fixes some bugs around handling duplicate headers
2018-10-08 16:04:47 -07:00
Matt Bierner 7d95e3e5f9 Support markdown link navigation when duplicate slugs exist
Fixes #59711

For a md document:

```md
# a

# a

- [a](#a)
- [next a](#a-1)
```

You can now click on the second link in the editor to navigate to the second `a` header. It is identified by being suffixed with `-1`.
2018-10-08 15:51:29 -07:00
Matt Bierner f87369e1af Treat json5 as json in the markdown preview 2018-10-05 13:06:37 -07:00
Matt Bierner a529621b3d Disable command uris in preview
We are now using the modern, message passing approach to handling actions in the markdown preview. No more need for command uris
2018-10-04 19:01:34 -07:00
Matt Bierner 6d5214053c Fix local markdown document links for untitled files
Fixes #59523
2018-10-04 19:01:34 -07:00
Adam Curtis ccb63aacfa Removed duplicate "the" from documentation. (#59736) 2018-10-01 17:30:06 -07:00
Matt Bierner 1d192bb4f0 Onboard markdown to use shared tsconfig 2018-10-01 16:41:19 -07:00
Joao Moreno 707787c5b8 update yarn.lock files to use integrity 2018-09-30 16:34:43 +02:00
Ramya Achutha Rao 972ee3f948 Use latest applicationinsights in extensions too 2018-09-25 16:45:00 -07:00
Agustín Rodríguez 9041e6a4b5 styles for diff on markdown preview (#59289)
* styles for diff on markdown preview

* moved styles to markdown specific css file
2018-09-25 12:02:15 -07:00
Matt Bierner e19c9ba82d Addd option to open markdown preview links in markdown preview
Fixes #19339
2018-09-21 15:08:42 -07:00
Matt Bierner a101ececf4 Remove onCommand from markdown preview 2018-09-21 15:08:41 -07:00
Matt Bierner 388a62fe12 Fix anchor links in markdown preview 2018-09-21 15:08:41 -07:00
Matt Bierner 7185906189 Reduce usage of postCommand in markdown preview 2018-09-21 15:08:41 -07:00
Alex Dima 5bae3f69d9 Use webpack also for small built-in extensions 2018-09-20 14:17:45 +02:00
Johannes Rieken 5037516238 updated lock files 2018-09-20 12:06:55 +02:00
Johannes Rieken 6999ddbab7 update vscode-extension-telemetry 2018-09-20 12:06:55 +02:00
Alex Dima 34e7a220c8 Avoid shipping unnecessary files 2018-09-19 19:53:46 +02:00
Johannes Rieken 1da08a83c8 update vsce ignore file #57680 2018-09-19 10:55:17 +02:00
Ramya Achutha Rao d0a67178ca Update appinsights in built in extensions 2018-09-18 18:35:12 -07:00
SteVen Batten f8f4d3af30
improve markdown preview scroll sync (#58852)
* improve markdown preview scroll sync
2018-09-18 15:08:37 -07:00
Matt Bierner 4096b5d68e Avoid uri parse warnings for markdown uris
Fixes #58566

We only support local file links or a small set of normal schemes, like `http` and `mailto`. Use this to avoid calling `Uri.parse` with scheme-less paths such as `Uri.parse('/images/cat.gif')`
2018-09-13 15:43:47 -07:00
Matt Bierner 2806df93e4 Try to keep one blank line after markdown block element folds
Fixes #58187
2018-09-07 13:48:44 -07:00
Matt Bierner a118676a3b Allow folding of html blocks in markdown files
Fixes #57505
2018-09-07 13:41:55 -07:00
Matt Bierner 5eab03cf75 Fix folding code blocks / lists with front matter 2018-09-07 11:36:38 -07:00
Alex Dima c36258d23f Use const enums (to inline their values in JS) 2018-09-06 20:39:19 +02:00
Johannes Rieken fc2b0a8ec1 add missing vscode-nls updates 2018-09-06 15:12:28 +02:00
Matt Bierner 8a849b5734 Allow folding fenced code blocks in md
Fixes #36169
2018-09-05 14:59:34 -07:00
Matt Bierner 957a16690d Webpack markdown extension
Part of #57680
2018-09-05 09:03:35 -07:00
tsangint c90755b665 Fix typo (#57192) 2018-09-05 08:36:16 -07:00
Jason Bright d540729e40 add markdown list folding, #57104 (#57899) 2018-09-04 17:43:35 -07:00
Rob Lourens af243726fb Exclude test files from extensions #57426 2018-08-28 10:39:56 -07:00
Matt Bierner 49edd3d038 markdown toc should include full span to next header
The folding range should exclude blank lines before the next header level
2018-08-24 12:01:25 +02:00
Matt Bierner 2c43eaebec Fix markdown document symbols not having full range of section 2018-08-24 11:01:23 +02:00
Matt Bierner c3c75a237b Extract getHeaderFoldingRanges 2018-08-24 11:01:22 +02:00
Matt Bierner ee947947a7 Fix duplicate markdown previews potentially being shown in the same editor group
Fixes #56910
2018-08-21 16:42:11 +02:00
Benjamin Pasero 920defc6a6 debt - update extensions node dependency to 8.x 2018-08-14 10:44:56 +02:00
Johannes Rieken c8ac8ec300 debt - towards scheme-enforcement, #56108 2018-08-10 12:10:30 +02:00
Jackson Kearl 6a1515671f Markdown region folding (#55399)
* Add foldin g of regions to markdown

* Add test for region folding

* Tweak region identification regex
2018-08-07 22:47:29 +02:00
Ramya Achutha Rao 1912c5d755 Allow extensions to log telemetry to log files #54001 2018-07-30 16:18:54 -07:00
Matt Bierner 4be0f07230
Add WebviewPanel.iconPath (#54912)
* Add WebviewPanel.iconPath

Allows webviews to provide icons used in UI. Adds a new `WebviewPanel.iconPath` property for this.

Replaces the static contribution approach from #49657

Fixes #48864

* Fix doc

* Move icon into mainthreadwebview

* Cleaning up implementation

* Cleaning up implementation
2018-07-24 15:08:46 -07:00
HUA Yang 9038bc7b45 fix #53590 (#54257) 2018-07-18 16:22:29 -07:00
Greg Van Liew c150d0d42d Edit pass on new built-in extension comments (#54277) 2018-07-13 15:28:27 -07:00
Ramya Achutha Rao a32654c5f1 Link to docs in the website from builtin extension readme #54098 2018-07-12 18:16:01 -07:00
Dirk Baeumer 21991b4912 Move to latest vscode-nls for corrupted cache support 2018-07-03 16:12:52 +02:00
Matt Bierner a2974a0782 Fix markdown code blocks getting two backgrounds in preview
Fixes #53246
2018-06-28 15:18:05 -07:00
Matt Bierner 33446a0a9e Use hierarchical markdown document symbols
Fixes #52546
2018-06-26 17:31:45 -07:00
Matt Bierner 48c54a009f Override light color for function and params in md code preview
Fixes #52710
2018-06-25 11:09:05 -07:00
Matt Bierner 78f410ce39 Make sure we correctly update local resource roots when switching previewed markdown file
Fixes #49859
2018-06-20 15:48:14 -07:00
Matt Bierner 1a9f7c85b8 Fix content after fenced code block being treated as code
Fixes #52509
2018-06-20 14:15:34 -07:00
Matt Bierner 66a9cfd809 Update deps 2018-06-20 14:12:18 -07:00
Matt Bierner a85c0b6669 Introduce webview.active
The current `.visible` property actually means active. Rename this value to `.active` and introduce a real `.visible`
2018-06-15 15:51:46 -07:00
Matt Bierner 749eb1ebcd Make sure we handle line number links correctly in preview
Fixes #51919
2018-06-15 10:09:27 -07:00
Benjamin Pasero 2ec2cf597a
API tweaks for grid editor (#51876)
* fix #51001

* add onDidChangeTextEditorViewColumn test that validates moving editor group

* adopt vscode.ViewColumn.Beside

* add vscode.setEditorLayout command
2018-06-14 17:17:39 +02:00
Matt Bierner 68afee908e Allow updating webview settings after creation
Fixes #51733
2018-06-13 15:20:18 -07:00
Matt Bierner 99c825f4e2 Make sure we use correct resource when accessing the [markdown] config setting
Fixes #51650
2018-06-12 11:09:41 -07:00
Joao Moreno 8a3ffed0ab vsts: report smoketest results 2018-06-12 17:37:53 +02:00
Joao Moreno 4dc738593b complete integration test results 2018-06-12 17:24:23 +02:00
Matt Bierner 05aab259e7 Extract constant 2018-06-11 18:38:03 -07:00
Matt Bierner 31a8fe2690 Use lazy for creating output channel 2018-06-11 18:38:03 -07:00
Matt Bierner ed3e645112 Use _private 2018-06-11 18:38:03 -07:00
Joao Moreno d8555f56c1 tests: scope xml file per platform 2018-06-11 22:36:32 +02:00
Joao Moreno 4eceb88ebf wip: build show integration tests 2018-06-11 22:05:12 +02:00
Matt Bierner 4f324d1712 Fix markdown preview not cleaning up context/state on close
Fixes #51033
2018-06-07 16:38:52 -07:00
Rob Lourens 047b88c39c Fix deps for building with node 10 - see #48699 and anodynos/upath#20 2018-06-04 14:28:51 -07:00
Matt Bierner e0ae63888d Extracting common code for getMarkdownDocument 2018-06-04 11:50:04 -07:00
Matt Bierner 7b69194f91 Introduce the concept of a SkinnyTextDocument that provides minimal interface to generate toc 2018-06-04 11:50:04 -07:00
Matt Bierner 7a24ced69f Make sure fenced code blocks properly get line numbers assigned
Fixes #51095
2018-06-04 10:16:58 -07:00
Cherry Wang 749a1bfeee Markdown and common toolbar icons consistency pass (#50484)
* arkdown and common toolbar icons consistency pass

* Fixed icon size related css

* fix merge issue

* flip
2018-06-03 11:32:59 +02:00
Matt Bierner 717c2f4b2c Fix markdown preview not setting context properly on first creation
Fixes #50558
2018-05-31 01:09:10 -07:00
Matt Bierner 608bbb7c01 Use better colors for markdown code blocks 2018-05-30 22:53:56 -07:00
Matt Bierner 2319e47db1 Make sure we use normalized path for compare
Fixes #50760

(the path should already have been normalized at this point so I don't think there is any user impact)
2018-05-30 11:16:16 -07:00
Matt Bierner b00948ffec Use more specific onWebviewPanel activation event 2018-05-25 12:11:57 -07:00
Matt Bierner 558c694d47 Use blacklist for puctuators
Currently we can't use `/\p{L}/u` which would let use use a whitelist instead

Fixes #37079
2018-05-25 11:57:01 -07:00
Matt Bierner 281f242cff Don't strip special characters in slugify
Fixes #48482
2018-05-25 11:57:01 -07:00
Matt Bierner feeefd1037 Inject slugifier into markdown engine 2018-05-25 11:57:01 -07:00
Matt Bierner 176a27a53b Start encapsulating slugifier 2018-05-24 08:05:52 -07:00
Matt Bierner ab2efd6724 Make sure we inherit the correct border-color
#49978
2018-05-16 15:16:15 -07:00
Matt Bierner be413aed89 Use css vars for more webview styling
Fixes #49749
2018-05-14 14:36:13 -07:00
Matt Bierner 21ee81c03b Working on webview persistence API
#49022
2018-05-14 10:34:59 -07:00
Matt Bierner 7980812a43 Properly handle links with title 2018-05-04 11:37:32 -07:00
Matt Bierner 43ed87ccde Add test for #49011 2018-05-04 11:37:32 -07:00
Matt Bierner bd29afad2c More pinning tests for markdown links 2018-05-04 11:37:32 -07:00
Matt Bierner c068e6fdfe Start adding some basic document link pinning tests 2018-05-04 11:37:32 -07:00
Matt Bierner 0d584a9086 Allow open preview from markdown file title context menu
Part of #37045
2018-04-30 17:30:44 -07:00
Matt Bierner 051b8b3243 Remove old package lock file 2018-04-26 11:34:17 -07:00
Matt Bierner 2864ccf676 Only register markdown for file and untitled schemes
Fixes #48777
2018-04-26 11:03:29 -07:00
Matt Bierner 82d97b4c3c Add acquireVsCodeApi to get handle to vscode api inside webview
Fixes #48540
2018-04-25 22:28:31 -07:00
Matt Bierner f36cae36dc Add vscode namespace in webview
From discussion around #48540
2018-04-25 15:33:45 -07:00
Ramya Achutha Rao 1139de12c0 Create appInsights client only if user has opt-in to telemetry 2018-04-25 15:21:15 -07:00
Matt Bierner edc3bbe603 Use string symbol kind for markdown symbols 2018-04-25 12:43:02 -07:00
Matt Bierner b845ce918f Don't include node_modules in markdown results 2018-04-23 18:03:19 -07:00
Matt Bierner 4222253670 Make sure we update markdown workspace results when editing a file wihtout saving 2018-04-23 17:59:29 -07:00
Ramya Achutha Rao 0c47c04e85 Add missing yarn updates 2018-04-21 20:44:21 -07:00
Ramya Achutha Rao 953cdf7f3d Update vscode-extension-telemetry version 2018-04-20 10:30:05 -07:00
Matt Bierner 91191fb866
Promote webview Api to stable (#47989)
* Promote webview Api to stable

Fixes #43713
Fixes #28263

* Rename position back to viewColumn and mark viewColumn as deprecated

This allows us to more easily re-introduce a `position` property once we have gridlayout

* Move dispose methods onto webview itself

Also better hide a few 'internal' methods / properties on the panel / webview

* Revert "Move dispose methods onto webview itself"

This reverts commit 8fab6cc1a1.

* Move title onto webview panel

* Use _ names for private setters

* Remove unused emitter and dispose onMessageEmitter

* Preview internal emitters with _
2018-04-19 10:55:49 -07:00
Martin Aeschlimann a1bb202eb6 incorperate folding api feedback 2018-04-18 15:26:43 +02:00
Matt Bierner 3a14fde91d Fix double click md preview when source document is not showing
Fixes #47188
2018-04-16 15:21:24 -07:00
Matt Bierner bc6a2d52ac Move onDidChangeActiveTextEditor into Preview 2018-04-16 15:13:49 -07:00
Matt Bierner 017d09e2fe Be more lazy computing symbols 2018-04-13 16:34:25 -07:00
Matt Bierner 7761157030 Update results on file create 2018-04-13 16:34:25 -07:00
Matt Bierner 79098619a5 Handle delete document 2018-04-13 16:34:25 -07:00
Matt Bierner 87f97ad853 Adding test for file change 2018-04-13 16:34:25 -07:00
Matt Bierner 8f877ceec6 Adding multi document workspace symbol provider test 2018-04-13 16:34:25 -07:00
Matt Bierner 6044fcacc8 Adding single file test 2018-04-13 16:34:25 -07:00
Matt Bierner aa0d43ea2d Name cleanup 2018-04-13 16:34:25 -07:00
Matt Bierner 62078256fb Switch to using watcher 2018-04-13 16:34:25 -07:00
Matt Bierner ba87894f5d Don't depend on lodash 2018-04-13 15:09:07 -07:00
Pradeep Murugesan 5e993f7160 added the workspace symbol provider for markdown #46406 (#47610)
* added the workspace symbol provider for markdown 46406

* fixed the review comments 46406
2018-04-13 15:03:50 -07:00
Matt Bierner 4f880aaf59 Rename webview.viewColumn to the more generic webview.position 2018-04-12 14:25:55 -07:00
Matt Bierner e16ec3c1ff Tweak WebviewPanelOnDidChangeViewStateEvent to only provide a webview panel
Expose a webview panel's view state as properties. Make WebviewPanelOnDidChangeViewStateEvent only fire an event with the webview who's state changed
2018-04-12 14:22:42 -07:00
Matt Bierner a2346c606d Rename WebviewEditor to WebviewPanel 2018-04-12 12:06:07 -07:00
Matt Bierner 8cb7e80544
Split out Webview from WebviewEditor in proposed API (#47370)
* Split out `Webview` from `WebviewEditor` in API

**Problem**
The current proposed `Webview` interface has a few methods and properties that are very editor specific, such as `.reveal` and `.onDidChangeViewState`. These properies will not make sense if we ever allow webview to be displayed in other locations, such as in widgets

**Proposal**
Split the concepts of a `Webview` and of a `WebveiwEditor`. A webview is the html content itself. A `WebviewEditor` is an editor that displays a `Webview`

This would allow us to easily add other types of `Webview` owning objects in the future without having to document that some methods only apply when a webview is used as an editor vs as a widget
2018-04-11 11:49:02 -07:00
Matt Bierner 52c293a050 Fix webview type name casing 2018-04-06 17:09:41 -07:00
Matt Bierner b641742452 Targeted fix for markdown special character links in #37079
Fixes #37079
2018-04-06 16:06:45 -07:00
Matt Bierner 5b90e42e3c Make sure we don't try posting mesages to disposed markdown previews
Fixes #45553
2018-04-06 16:06:45 -07:00
Matt Bierner c14e30aeb4 Show error when webview restore fails 2018-04-05 19:18:55 -07:00
Matt Bierner afc08ae477 Make markdown preview revive wait on content populated 2018-04-05 10:24:07 -07:00
Matt Bierner 9755b46bf6 Fix double click markdown editor when in split view
#47188
2018-04-05 10:16:39 -07:00
Matt Bierner dd21d3520a
Add webview restoration api proposal (#46380)
Adds a proposed webiew serialization api that allows webviews to be restored automatically when vscode restarts
2018-04-03 18:25:22 -07:00
Martin Aeschlimann f57c35c0f2 Languages -> Programming Languages (for #47103) 2018-04-03 14:30:02 +02:00
Matt Bierner fd182746cb Fix can't change markdown security level for directly opened file
Fixes #46424
2018-04-02 16:29:49 -07:00
Andreas Offenhaeuser e64b9b4f41 add AllowInsecureLocalContent option to MarkdownPreviewSecurityLevel (#46473) 2018-03-26 12:23:27 -07:00
Matt Bierner 67d8eebaf4 Rename webview.show to webview.reveal
Make it more clear that this command only reveals an existing webview

Fixes #44580
2018-03-20 16:16:05 -07:00
Matt Bierner ea1fed9616 Use viewType instead of uri for webviews
As discussed in #45994, move from using a uri to using a viewType. The view type is shared among all webviews of a given type, such as all markdown previews

Fixes #44575
2018-03-20 14:44:10 -07:00
Matt Bierner 18146e8c71 Use activePreview when running markdown commands
Fixes #46216
2018-03-20 14:30:39 -07:00
Matt Bierner 27a17935b8 Move webview to use onDidChangeViewState event
After discussions, we settled on making the webview private unlike `TextEditors`. This means that webview events will live on the webview object itself

Fixes #44571
2018-03-20 14:30:39 -07:00
Martin Aeschlimann 53332ed17f fix npm scripts after extension rename 2018-03-20 15:29:48 +01:00
Matt Bierner 468dc867cd Rename markdown to markdown-language-features 2018-03-19 21:08:39 -07:00