development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-11-05 18:29:38 +00:00
Code Issues Projects Releases Packages Wiki Activity
120513 commits 1130 branches 299 tags 1.2 GiB
Commit graph

120513 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matt Bierner
125e308ea4
Bump @typescript-eslint versions (#209516) 
6.x is the latest release that supports our current node target
 2024-04-04 10:36:59 -07:00
Matt Bierner
ae91138701
Add eslint rule for potentially unsafe disposable patterns (#209555) 
`DisposableStore`/`MutableDisposable` properties should almost always be `readonly`. Otherwise it's easy to accidentally overwrite the property and leak the previous value. This commonly happens with code such as:

```ts
class Foo {
     private disposables = new DisposableStore();

     bar() {
         this.disposables = new DisposableStore(); // leaks old values
         ...
     }
```

This change adds an eslint rule to enforce this and adopts `readonly` for the caught cases. I only needed to add 2 suppression comments, which seems like an acceptable tradeoff for helping catch a common mistake
 2024-04-04 10:34:45 -07:00
Sandeep Somavarapu
b4378dfa1d
fix #207813 (#209553) 2024-04-04 18:19:58 +02:00
Megan Rogge
a32d57b598
Merge pull request #209550 from microsoft/merogge/descrs 
improve command descriptions
 2024-04-04 09:10:33 -07:00
Daniel Imms
cb6942bf39
Merge pull request #209548 from microsoft/tyriar/api_todos 
Add todos for shellIntegration API from API sync
 2024-04-04 08:59:33 -07:00
Megan Rogge
f4806a28df
Update src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatActions.ts 2024-04-04 08:52:05 -07:00
meganrogge
77fdf27159
add discard description 2024-04-04 08:50:56 -07:00
Daniel Imms
e16e41ea3c
Add todos for shellIntegration API from API sync 
Part of #145234
 2024-04-04 08:42:17 -07:00
Megan Rogge
8cf1fbea8d
Merge pull request #209546 from microsoft/merogge/accessibility-cleanup 
accessibility contrib/config renaming, cleanup
 2024-04-04 08:38:58 -07:00
meganrogge
7ac815275d
more descriptions 2024-04-04 08:34:59 -07:00
meganrogge
86c3607799
accessibility signals 2024-04-04 08:28:02 -07:00
meganrogge
32b24760fa
add scope 2024-04-04 07:59:08 -07:00
meganrogge
50b145a240
Merge branch 'main' into merogge/accessibility-cleanup 2024-04-04 07:41:37 -07:00
meganrogge
9713bb3f13
add accessibility signals to l8n 2024-04-04 07:36:04 -07:00
meganrogge
68257f61f7
rename, move things around 2024-04-04 07:32:43 -07:00
Megan Rogge
3f0dbfe658
Merge pull request #209544 from microsoft/merogge/cue-fix 
fix accessibility signal resource scope
 2024-04-04 07:29:03 -07:00
meganrogge
2b010cf72a
move audio cue config to new file 2024-04-04 07:21:28 -07:00
meganrogge
4c71a4ef65
fix #207101 2024-04-04 07:00:43 -07:00
Johannes Rieken
a52d0d95df
Merge pull request #209529 from microsoft/joh/overseas-cougar 
Add support for `ChatResponseTextEditPart`
 2024-04-04 15:39:39 +02:00
Justin Chen
140f3b2694
removing issue reporter API (#209125) 
* first snap

* sent the comments to the shadow realm

* one comment we forgot to remove :(
 2024-04-04 04:23:23 -07:00
Benjamin Christopher Simmonds
15528c7a38
Fix tab indicator size when tab action left and tab sizing fixed/shrink (#209532) 
fixes #207003
 2024-04-04 12:53:35 +02:00
Johannes
76301af69c
💄 2024-04-04 12:43:56 +02:00
Alex Ross
ae1a6d6aa4
Count replies, not comments (#209527) 
Fixes microsoft/vscode-pull-request-github#5869
 2024-04-04 12:29:20 +02:00
Benjamin Christopher Simmonds
8012a40059
Add color item for sidebar title background (#209528) 
fixes #209164
 2024-04-04 12:28:52 +02:00
Johannes Rieken
c91cf1b5e6
fix https://github.com/microsoft/vscode/issues/209441 (#209526) 2024-04-04 12:22:05 +02:00
Benjamin Christopher Simmonds
87050cad1d
Add descriptions for commands #209511 (#209524) 2024-04-04 12:03:15 +02:00
Johannes
5b1b744590
- extract IChatListItemRendererOptions 
- use diff editor hiding of unchanged regions
- simpler code compare block (for now)
 2024-04-04 11:51:06 +02:00
Johannes
c71d1c0706
Merge branch 'main' into joh/overseas-cougar 2024-04-04 08:22:26 +02:00
Matt Bierner
1e765ade0e
Fix injected services becoming public by mistake (#209513) 
* Fix injected services becoming public by mistake

Fixes cases of `@IFooService readonly foo: IFooService`. This makes the service public, which is likely not expected and also means we can't mangle it

* Fix name

* Remove unused props
 2024-04-04 08:06:16 +02:00
Peng Lyu
641eb4c02d
Hide notebook chat actions from f1. (#209501) 2024-04-03 19:35:20 -07:00
Peng Lyu
98ce5b3548
Convert Workspace Cell Edit dto to renderer types (#209498) 2024-04-04 02:18:32 +02:00
Connor Peet
26edf9ca9f
cli: add progress for extraction (#209499) 
For https://github.com/microsoft/vscode-remote-tunnels/issues/724
 2024-04-03 17:08:49 -07:00
Raymond Zhao
951c1b7d76
chore: increase compile job timeout (#209497) 2024-04-03 16:38:22 -07:00
Megan Rogge
34dc36cffe
Merge pull request #209495 from microsoft/merogge/speech-signal 
move speech accessibility signals to contribution file
 2024-04-03 15:58:55 -07:00
meganrogge
7a71cd15d4
fix #209487 2024-04-03 15:40:15 -07:00
Connor Peet
8558da1335
cli: allow public port forwarding via tunnels (#209489) 2024-04-04 00:28:00 +02:00
Megan Rogge
0f13661a91
Merge pull request #209464 from microsoft/merogge/disposable-store 
use disposableStore for listeners created in render
 2024-04-03 14:35:27 -07:00
Megan Rogge
9c892dba6a
Merge pull request #209467 from microsoft/merogge/splits 
fix join terminals bug
 2024-04-03 14:34:30 -07:00
Megan Rogge
f756507655
Merge pull request #209477 from microsoft/merogge/default-task 
fix build task command issues
 2024-04-03 14:33:49 -07:00
Connor Peet
efee188faf
web: add didResolveRemoteAuthority function for embedders (#209480) 2024-04-03 14:16:56 -07:00
Daniel Imms
feb823cc57
Merge pull request #209442 from microsoft/tyriar/204965 
Introduce IHoverService.setupUpdatableHover
 2024-04-03 14:13:39 -07:00
meganrogge
81cfeac812
rm empty line 2024-04-03 12:17:38 -07:00
meganrogge
b3bbaec18a
fix #184454 2024-04-03 12:16:28 -07:00
Daniel Imms
5d92626966
Merge branch 'main' into tyriar/204965 2024-04-03 12:12:04 -07:00
Aaron Munger
23860e98f0
dispose saved text model with wrong view type (#209461) 2024-04-03 11:40:33 -07:00
Raymond Zhao
fb7f833668
fix: trim end of matched link (#209469) 2024-04-03 11:25:21 -07:00
Matt Bierner
9efebbe2e4
Enable copy paste api in scm input (#209466) 
* Enable dnd and copy paste apis in scm input

For #209460

Enables dropping or pasting a file from the vscode/system explorer into the scminput to insert the file name. Currently nothing happens when you try this

In the future will also allow extensions to hook into these apis

* Revert organize imports

* Remove duplication
 2024-04-03 19:39:11 +02:00
meganrogge
69193b54ad
fix #152476 2024-04-03 10:29:12 -07:00
Logan Ramos
80a9d24148
Add CLI cleaning regex (#209462) 2024-04-03 18:56:56 +02:00
meganrogge
6b91b701d0
use disposableStore 2024-04-03 09:52:26 -07:00