Commit graph

822 commits

Author SHA1 Message Date
Matt Bierner 9bdb4a2f70 Handle normalized windows paths in resource map
Fixes #86433

During path normalization, we convert `\` in windows paths to  `/`. This causes the isWindowsPath check to fail

I think it is generally safe to assume that file paths that start with a drive letter and then any type of slash should be treated as windows paths
2019-12-05 15:08:13 -08:00
Martin Aeschlimann eeee6244d9 [josn] fix wrong schema-schema reference, use draft-07 everywhere 2019-12-05 11:15:39 +01:00
Matt Bierner 57455124b5 Make sure we also log the typescript error properties on fatal error telemetry events
Fixes #86205

We already log error metadata for failed requests. However we don't include this on the fatalError event. This makes investigation of these errors difficult
2019-12-04 10:59:15 -08:00
Martin Aeschlimann 3bef2000a8
Merge branch 'master' into patch-2 2019-11-26 14:28:00 +01:00
Matt Bierner a63d88ec55 Make sure we normalize paths before sending them to tsserver
Fixes #84826
2019-11-25 20:58:47 -08:00
Matt Bierner 16fffb122b Mark parameter suggestions as variables
For #85430
2019-11-25 20:09:10 -08:00
Matt Bierner dd300e4fe7 Show constants as normal variables
Fixes #85429
2019-11-25 19:50:32 -08:00
Matt Bierner 4116c9411b Use enum member completion type 2019-11-25 19:50:32 -08:00
Samuel Bronson 96479b86f3
Allow trailing commas in jsconfig.json, too
This is a followup to commit bcf67c867f "allow trailing commas in tsconfig.json (for #80419)".
2019-11-23 21:36:10 -05:00
okmttdhr 0db887a1a3 Show JS/TS References Code Lens for Inner Functions (#84689)
* Show code lens for inner functions

* Create typescript.referencesCodeLens.showOnAllFunctions setting

* Create javascript.referencesCodeLens.showOnAllFunctions setting

* Add a new setting in a existing class

* Avoid unnecessary fallthrough
2019-11-22 18:06:23 -08:00
Matt Bierner 827e94edef Hook up basic alert of why a code action could not be applied
For #85160
2019-11-20 17:10:00 -08:00
Alex Ross e82dd213dd Make typescript problem match watch patterns less locale specific
Improves #46373
2019-11-20 09:33:32 +00:00
Matt Bierner 0e5a5f6524 Better time logging for js + markdown
We don't need full date, only times
2019-11-19 11:22:08 -08:00
Alexandru Dima cf624b01fc
Fix memory leak caused by listeners to nulToken (#84940) 2019-11-19 11:13:38 +01:00
Matt Bierner 942287eb44 Fix report issue command
For #85021
2019-11-18 11:00:47 -08:00
Matt Bierner 5b428d2ec1 Don't use locale strings
For #84803

These can cause issues on node 12
2019-11-18 09:35:35 -08:00
Johannes Rieken 95a7255725 fix more compilos 2019-11-18 15:26:44 +01:00
Alexandru Dima e7f8a94eb2
Split TS changes to separate PR 2019-11-18 12:17:23 +01:00
Alexandru Dima 41be9a6142
Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-18 08:59:14 +01:00
Matt Bierner 91200b1202 Use const enum for types 2019-11-15 14:55:14 -08:00
Matt Bierner fa72810c77 Don't send TS Server open requests if we open then quickly close a resource
Fixes #84875
2019-11-15 14:02:46 -08:00
Alexandru Dima cbb231754f
Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-15 10:10:39 +01:00
Matt Bierner 738d85a51e Don't return js/ts fix all for empty edits 2019-11-14 15:35:46 -08:00
Matt Bierner 88c2100793 Make sure we always reset bufferSyncSupport when the TS server is started
Splits `reset` from `reinitialize` and makes sure we always `resset` buffer sync support when the service starts
2019-11-14 11:30:41 -08:00
Matt Bierner 4e8ef4cf4d Remove gating for inMemoryResourcePrefix
Some users are setting weird errors related to untitled TS files. In some of these cases (such as https://github.com/microsoft/TypeScript/issues/35091) we see a untitled file being sent to the tsserver without the `inMemoryResourcePrefix`.

I can't figure out how to get into this state but am removing the gating that *could* perhaps cause use not to set `inMemoryResourcePrefix`. This gating targets TS 2.7 or older, which telemetry shows very, very few users are still enabling in their workspaces
2019-11-14 00:17:57 -08:00
Alex Dima 15beb36ccf
Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-14 09:16:10 +01:00
Johannes Rieken 27eafea04a
Merge pull request #84578 from microsoft/joh/outlineNav
Symbol navigation
2019-11-13 12:33:36 +01:00
Matt Bierner cf197953d7 Prefer using vscode.workspace.fs over node fs 2019-11-12 21:59:36 -08:00
Matt Bierner 0749b7aca8 Timebox the TSServer request used in the JS/TS task provider
Fixes #84278
2019-11-12 21:59:36 -08:00
Matt Bierner 1f3642a07d Add explicit type on experimental fixAll provider
For #84602
2019-11-12 14:28:43 -08:00
Matt Bierner a170916295 Highlight a few other types in jsdoc comments
Fixes #84622
2019-11-12 13:31:09 -08:00
Greg Van Liew 8ae2921645 Nits in settings comments 2019-11-12 10:55:04 -08:00
Johannes Rieken 7e333135dd often set selection range for TS document symbols, #84576 2019-11-12 11:28:48 +01:00
Matt Bierner 2ec3bc4fd0 Removed undocumented setting usage 2019-11-11 16:12:52 -08:00
Matt Bierner 8904a3cbce 💄 2019-11-11 16:12:52 -08:00
Matt Bierner 6118d2713e Make sure synchronized buffers are reset when tsserver restarts 2019-11-11 16:12:52 -08:00
Matt Bierner 21fd94b70c Make sure buffer sync reset clears pending diagnostics 2019-11-08 14:47:06 -08:00
Matt Bierner 7218d47251 Make sure we don't try calling a cached getErr on a closed resources that are in the getErr queue 2019-11-08 14:47:06 -08:00
kieferrm 59ba1190b4 fix GDPR annotation 2019-11-08 22:36:55 +00:00
Alex Dima c9a2de2d9c
Improve integration test output on Windows (#84239) 2019-11-08 17:21:35 +01:00
Matt Bierner fdeb9aa9b8 Use 'as const' instead of readonly class object 2019-11-07 20:31:32 -08:00
Matt Bierner a8ad448cb0 Aggressively cancel code lens requests when the resource changes
For #84185
2019-11-07 18:47:39 -08:00
Matt Bierner d83f121f6d Fix spelling 2019-11-07 07:57:04 -08:00
Alexandru Dima c34e736195
Forward SemanticColoring disposals to the ext host 2019-11-07 16:06:46 +01:00
Alexandru Dima bdbe2e3612
Clear semantic tokens in case of errors/empty results 2019-11-07 15:40:06 +01:00
Alexandru Dima 7761e75deb
API tweak from the standup discussion 2019-11-07 15:26:22 +01:00
Matt Bierner bea911842a Fix name and make sure tell VS Code about about specific code actions 2019-11-06 18:21:43 -08:00
Matt Bierner 5b63895862 Docment remaining known js/ts refactorings 2019-11-06 18:13:54 -08:00
Matt Bierner 26c4541c4a Add coalease helper function 2019-11-06 17:47:43 -08:00
Matt Bierner 692630172a Documenting more js/ts refactorings 2019-11-06 17:47:43 -08:00