Ladislau Szomoru
0426dd4e2a
SCM - 💄 adopt observables ( #219162 )
2024-06-29 20:06:00 +02:00
Sandeep Somavarapu
0225546178
#212879 dispose child instantiation service ( #219217 )
...
* #212879 dispose child instantiation service
* fix tests
2024-06-29 19:40:07 +02:00
Benjamin Pasero
943b47ae17
debt - adopt nlsCoreBaseUrl ( #219165 )
2024-06-29 17:47:45 +02:00
Rob Lourens
39aba8e0af
Tune chat render rate ( #219241 )
...
Count words more correctly
Don't measure the time before text starts to appear
Better logs
2024-06-29 14:31:50 +02:00
Rob Lourens
5bece9e46a
Clear all workspace chats should also clear all open chats ( #219198 )
...
Fix #218034
2024-06-29 00:39:18 +02:00
Rob Lourens
c8a4a25577
Add 'command' to chat telemetry ( #219218 )
2024-06-28 14:25:19 -07:00
Aaron Munger
032c1b7544
don't show output items if they are empty ( #216844 )
...
* wait for content to attach toolbar
* command to show hidden outputs
* avoid perf hit of checking innerText on resize
* empty based on 0 content height
* just rely on height=0 for empty output
* use event to attach toolbar
* leave border in, but account for the height it adds
* hide again if content goes back to zero height
* zero
* tests, fix memory leaks
* move magic number to common function
2024-06-28 23:07:28 +02:00
Rob Lourens
206e438ff4
Fix #218031 ( #219215 )
2024-06-28 13:48:14 -07:00
Sandeep Somavarapu
da36fe717e
fix #218133 ( #219212 )
2024-06-28 13:47:41 -07:00
Sandeep Somavarapu
5fc4b6e873
skip version check in oss ( #219206 )
2024-06-28 13:31:08 -07:00
Justin Chen
fe473c806f
issue reporter short circuit logic fix ( #219002 )
...
* add better desccription check
* check on listener change
2024-06-28 13:05:29 -07:00
Rob Lourens
46362deb36
Support <sub> and <sup> in chat ( #219053 )
2024-06-28 11:06:45 -07:00
Johannes Rieken
5da15f50df
Merge pull request #218393 from c-claeys/instantiation-dfs
...
Fix exponential runtime in service instantiation
2024-06-28 18:11:12 +02:00
Sandeep Somavarapu
d9744cf206
skip version check in oss ( #219127 )
2024-06-28 17:59:27 +02:00
Johannes Rieken
dd7d9376fb
remove dead types from old proposal versions ( #219120 )
2024-06-28 17:03:26 +02:00
Alex Ross
6889c34d61
Adopt editor placeholder for comment widget ( #219119 )
2024-06-28 16:55:07 +02:00
Johannes Rieken
ecf818849d
add location specific data along when making chat request ( #219114 )
...
with this PR the implicit variables tricks aren't needed anymore
2024-06-28 16:27:08 +02:00
Daniel Imms
8cb093f364
Merge pull request #218941 from microsoft/tyriar/216817
...
Use webgl in terminal sticky scroll
2024-06-28 07:00:13 -07:00
Benjamin Christopher Simmonds
efa1397e63
Update default color for sticky scroll and location specific ones ( #218712 )
...
default color for sticky scroll and location specific ones
2024-06-28 15:47:48 +02:00
Benjamin Christopher Simmonds
f272e4d094
Disable compare action when no resource selected ( #218875 )
...
Fix #212925
2024-06-28 15:47:18 +02:00
Benjamin Christopher Simmonds
c50fcf3d7c
Fix selection issue with filtered group models ( #218889 )
...
Review: Filtered Editor Group Models and Selections - fixes #213163
2024-06-28 15:46:43 +02:00
Benjamin Pasero
2014f1ddb2
nls - removal of loader plugin ( #219098 )
2024-06-28 15:45:52 +02:00
Ladislau Szomoru
ff1b0028ad
SCM - 💄 remove custom observable logging ( #219101 )
2024-06-28 14:49:35 +02:00
Johannes Rieken
388469b7b4
debt - CSS cleanup, accessibile diff viewer padding ( #219102 )
...
* remove `InlineChatWidget#updateProgress` because the chat widget already shows progress
* debt - CSS cleanup, accessibile diff viewer padding
2024-06-28 14:48:54 +02:00
Benjamin Pasero
f6f90e0163
Implement NLS without AMD loader ( #214588 )
2024-06-28 11:55:48 +02:00
Johannes
d390b22c6d
fix lint error
2024-06-28 09:31:37 +02:00
Aaron Munger
2eedc1373c
look for keylabel that is used for mac as well ( #219015 )
...
look for mac keylabel as well
2024-06-27 23:20:34 +02:00
Snoppy
8d54ffc9f6
chore: fix typos ( #216562 )
...
Signed-off-by: snoppy <michaleli@foxmail.com>
2024-06-27 20:01:19 +00:00
Daniel Imms
4b28f5d48c
Use webgl in terminal sticky scroll
...
Fixes #216817
Fixes #218427
2024-06-27 11:00:50 -07:00
Sandeep Somavarapu
973dc3065b
fix #218219 ( #218876 )
2024-06-27 16:48:33 +02:00
Johannes Rieken
1ae48f15b7
fix https://github.com/microsoft/vscode/issues/218804 ( #218822 )
2024-06-27 14:45:52 +02:00
Sandeep Somavarapu
2e3a1d8bd9
fix #217902 ( #218716 )
2024-06-27 12:46:29 +02:00
Alex Ross
9e9eb5e3f6
Don't check locked stat in file picker ( #218707 )
...
Fixes #212408
2024-06-27 12:29:50 +02:00
Sandeep Somavarapu
56a2eb0dbb
fix #217851 ( #218698 )
2024-06-27 12:27:05 +02:00
Alex Ross
53ed07606e
Fix comment threads starting expanded ( #218684 )
2024-06-27 11:29:37 +02:00
Sandeep Somavarapu
5ba8a8b7a1
fix #218126 ( #218679 )
2024-06-27 11:21:43 +02:00
Rob Lourens
cb9d1e4589
Don't throw for $updateAgent failure ( #218649 )
...
Fix #214157
This can happen after something else went wrong, and the exception doesn't go back to the extension or anywhere helpful besides error telemetry.
2024-06-26 19:18:24 -07:00
Rob Lourens
5950c29098
Fix 'cancel chat' keybinding on windows ( #218647 )
...
Fix #217861
2024-06-26 19:18:00 -07:00
Aaron Munger
fb3bace29e
switch order of keybinding registration ( #218622 )
2024-06-26 14:51:08 -07:00
Joyce Er
9e7cd445fa
fix: show context menu option to disable empty editor hint ( #218548 )
...
* fix: show context menu option to disable empty editor hint
* Fix action name
2024-06-26 14:03:37 -07:00
Rob Lourens
b9f2435180
Fix up markdown lists that use * ( #218483 )
...
* Fix up markdown lists that use *
Fix #217946
* Comment
2024-06-26 11:25:07 -07:00
Daniel Imms
e80e61a6e0
Merge pull request #218451 from microsoft/tyriar/213941
...
Add new line before end of fenced code block
2024-06-26 10:28:16 -07:00
Daniel Imms
955be75839
Add new line before end of fenced code block
...
Fixes #218397
2024-06-26 10:10:32 -07:00
Daniel Imms
e73d388133
Merge pull request #218439 from microsoft/tyriar/213820
...
Disable terminal initial hint when ctrl+i is triggered
2024-06-26 10:10:06 -07:00
Daniel Imms
02cbb7a96d
Merge pull request #218417 from microsoft/tyriar/216624
...
Fix terminalChatFocus behavior
2024-06-26 10:03:20 -07:00
Daniel Imms
47262beab7
Disable terminal initial hint when ctrl+i is triggered
...
Previously this would only happen when _clicked_.
Fixes #213820
2024-06-26 09:46:12 -07:00
Daniel Imms
b37c33ddcb
Fix missing cases for not reporting prompts
...
Fixes #215482
2024-06-26 09:39:17 -07:00
Ole
a11a0d7edc
Fix two bugs in #214589 fixing #213535 . ( #218357 )
...
* Fix two bugs in #214589 .
1. We must not `dispose()` the `MutableDisposable` `this._commentThreadWidget` - as that disposes the MutableDisposable itself, and it cannot then later be reassigned to a new value. Instead, we need to assign `value=undefined`, which disposes the previous `value`, but keeps the `MutableDisposable` available to be reused later.
2. `initialize()` is a no-op if `this.currentElement` is already identical to the passed `element`, so we must not do that assignment before calling initialize - instead `initialize()` does the assignment after checking.
* Fix blank line.
* Register the _commentThreadWidget MutableDisposable so that it gets disposed when CellComments is disposed.
2024-06-26 16:10:56 +00:00
Daniel Imms
c6e312a80e
Fix terminalChatFocus behavior
...
Fixes #216624
2024-06-26 09:10:25 -07:00
Daniel Imms
720c89311e
Merge pull request #218405 from microsoft/tyriar/218402
...
Reset inline chat widget before terminal chat widget
2024-06-26 08:27:03 -07:00
