Commit graph

291 commits

Author SHA1 Message Date
Robo b5a6aa14a8
feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
David Dossett daf1b14904
Fix contrast ratio for selected menu items in Dark VS theme 2024-08-02 14:02:25 -07:00
Benjamin Christopher Simmonds 146b3fb6e0
Update tab selected background color (#212872)
tab selected background light vs

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2024-05-16 16:15:28 +02:00
Benjamin Christopher Simmonds 942d81c5b1
Improve tabs multi select theme colors and high contrast support (#212795)
Improved tabs multi select theme colors and high contrast support
2024-05-15 12:41:13 +02:00
David Dossett 2fb4572cce
Update menu selected state colors 2024-04-17 15:18:30 -07:00
Hylke Bons b8ac113876 themes: Increase contrast of inputs placeholder text 2024-02-01 18:03:40 +01:00
Henning Dieterichs ad18bb00ce Fixes #199351 2024-01-09 23:40:26 +01:00
Alex Ross b0d60e8e2e
Add the new Less grammar back in (#200043)
This reverts commit 95c05bf57b.
2023-12-05 15:17:02 +01:00
Alex Ross 95c05bf57b
Revert new Less grammar in preparation for release (#199017)
* Revert "merge theme rules for css/less/scss variables (#197657)"

This reverts commit cc08867677.

* Revert "Adopt Better-Less grammar (#197557)"

This reverts commit ce40e7ce61.
2023-11-24 14:11:23 +01:00
Martin Aeschlimann cc08867677
merge theme rules for css/less/scss variables (#197657) 2023-11-17 11:40:21 +01:00
Alex Ross ce40e7ce61
Adopt Better-Less grammar (#197557)
Consider adopting a new Less grammar
Fixes #171239
2023-11-07 17:36:06 +01:00
Mohammad Reza Gharabaghi 93351c7436
Update theme-defaults (#197449)
* Update dark_vs.json

* Update light_modern.json

* Update light_vs.json

* Update hc_black.json
2023-11-07 16:49:05 +01:00
David Dossett b206bc2c51
Merge pull request #195853 from microsoft/ddossett/wicked-narwhal
Increase link contrast in dark modern
2023-10-17 18:30:11 -07:00
David Dossett 49671031d1
Increase link contrast in dark modern 2023-10-17 18:15:34 -07:00
David Dossett 8e17fcac92
Update input placeholder color in dark modern 2023-10-17 17:40:58 -07:00
David Dossett 243e6cec50
Tweak text preformat foreground and background (#195821) 2023-10-17 22:18:28 +02:00
Alex Ross cc4775f55a
Update themes to accommodate C# grammar change (#192854)
See https://github.com/dotnet/csharp-tmLanguage/issues/290
2023-09-12 12:37:49 +02:00
Alex Ross f605341af6
Syntax highlighting incorrect in vscode.python for the word 'file' (#191111)
* Syntax highlighting incorrect in vscode.python for the word 'file'
Fixes #188190

* Update colorization test
2023-08-23 22:17:23 +01:00
Henning Dieterichs d72cb889ed Uses inputActiveOptionBackground as default for actionBar.toggledBackground 2023-08-14 18:45:24 +02:00
David Dossett 54902a3f0b
Tweak slash command widget pill colors and padding (#190208)
* Tweak slash command pill colors

* Fix padding
2023-08-10 16:23:00 -07:00
David Dossett caebd5c3a7
Tune secondary button colors (#189989) 2023-08-09 00:19:23 +01:00
David Dossett d1c4bf3fcb
Add CSS vars for slash commands and tweak styling (#189965)
Add css vars for slash commands and tweak styling
2023-08-08 13:37:37 -07:00
David Dossett c27bc0ff97
Fine tune editor widget backgrounds and border (#189957)
Fine tine editor widgets and border
2023-08-08 19:07:46 +01:00
David Dossett 299407db3d
Fix invisible border and use new foreground color for quick pick separators (#189857) 2023-08-07 12:36:29 -07:00
David Dossett 83fc3ad9bd
Replace transparent colors in Light/Dark Modern themes (#189585)
* Switch to solid colors in light modern and transform values to all caps

* Remove transparent values from workbench in dark+

* Finish merge
2023-08-04 10:34:09 +10:00
David Dossett 2bba361d30
Fix list backgrounds, editor hover widget, and quick pick colors (#189591)
* Fix editor hover widget background

* Remove list overrides and match quick pick background to editor widgets
2023-08-04 09:41:07 +10:00
David Dossett f0e0d81e2c
Revert scrollbar overrides in Dark Modern (#189593) 2023-08-04 00:26:48 +01:00
David Dossett 1d28efe34c
Fix light modern list focus outline (#189590) 2023-08-03 16:11:41 -07:00
David Dossett 45efcb4d17
Fix markdown pre and quote styling (#189586) 2023-08-03 15:41:07 -07:00
David Dossett f78157b2b5
Update badge colors in light/dark modern themes (#189503)
* Update badge background and foreground colors for Light/Dark Modern themes

* Fix hc-dark
2023-08-02 15:00:24 -07:00
Hylke Bons 741de09ada themes: Fall back to Light/Dark+ themes for diff colors 2023-07-24 13:41:30 +02:00
Rickey K. Liang 2ff3c9a7e7
Revert Python docstring color (#184938)
Revert b4368691e9

all color themes: treat comment docstrings as comments too (#182162)
2023-07-10 14:48:51 +02:00
David Dossett a3231fc857
Update inlay hint colors (#186658)
* Update inlay hints colors

* Update new themes
2023-06-29 12:49:50 -07:00
David Dossett 80f09eef48
Fix settings dropdown list background (#184547) 2023-06-08 00:03:16 +02:00
David Dossett 742d3670cb
Fix code block background in light modern theme (#183131) 2023-05-22 18:43:43 +02:00
David Dossett 4d0b34bf48
Rename new default theme files (#183001)
* Rename new default theme files

* Update tests
2023-05-22 08:27:24 -07:00
David Dossett a4037a72ef
Use default theme focus border color in Dark Modern theme (#182997)
Use regular focus border color in Dark Modern theme
2023-05-20 00:06:28 +02:00
Gabriel Staples b4368691e9
all color themes: treat comment docstrings as comments too (#182162)
* monokai-color-theme.json: treat Python comment string blocks

...as comments too

* Update *all* themes to consider Python block string comments as comments

	modified:   extensions/theme-abyss/themes/abyss-color-theme.json
	modified:   extensions/theme-defaults/themes/dark_vs.json
	modified:   extensions/theme-defaults/themes/hc_black.json
	modified:   extensions/theme-defaults/themes/hc_light.json
	modified:   extensions/theme-defaults/themes/light_vs.json
	modified:   extensions/theme-kimbie-dark/themes/kimbie-dark-color-theme.json
	modified:   extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json
	modified:   extensions/theme-monokai/themes/monokai-color-theme.json
	modified:   extensions/theme-quietlight/themes/quietlight-color-theme.json
	modified:   extensions/theme-red/themes/Red-color-theme.json
	modified:   extensions/theme-solarized-dark/themes/solarized-dark-color-theme.json
	modified:   extensions/theme-solarized-light/themes/solarized-light-color-theme.json
	modified:   extensions/theme-tomorrow-night-blue/themes/tomorrow-night-blue-color-theme.json

* Update all changes to use "string.quoted.docstring"

...instead of "string.quoted.docstring.multi.python", per
@aeschli's request here:
https://github.com/microsoft/vscode/pull/182162#issuecomment-1545296640

This way the comment formatting applies to *all* language quoted
docstrings, instead of just to Python.

* bring back python colorize tests

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2023-05-15 14:38:43 +02:00
Martin Aeschlimann e04309e92a
Default Themes: Rename Experimental to Dark Modern (#180785)
Default Themes: Rename Experimental to Modern
2023-04-25 09:02:17 +02:00
David Dossett 7f5644cc70
Fix active list background in dark+ v2 (#180170) 2023-04-18 07:50:26 -07:00
Martin Aeschlimann 05bb1775dc
Set new default theme (#179812) 2023-04-12 15:45:39 -07:00
Alex Ross 0e8b1c8e09
Confusing Bash/Shell syntax highlighting (#179775)
Fixes #179749
2023-04-12 14:33:55 +01:00
David Dossett 4448102523
Use solid color for input backgrounds in dark+ v2 (#178053) 2023-03-22 19:38:30 +01:00
Joyce Er fc76f309cc
Remove textPreformat-foreground override in experimental dark theme (#176679) 2023-03-09 12:07:39 -08:00
David Dossett 42062cb3ea
Fix find highlight background in Light+ V2 (#175372) 2023-02-24 19:40:00 +01:00
David Dossett 4965a140e9
Update active activity bar item foreground in v2 themes (#174980) 2023-02-21 20:25:22 +01:00
David Dossett d47bacfb75
Fix input border contrast in v2 themes (#172951)
* Fix v2 light theme input contrast

* Fix dark v2 theme border contrast
2023-02-21 11:15:45 -08:00
David Dossett e123385d1d
Fix active tab foreground in dark+ v2 (#174991) 2023-02-21 20:10:51 +01:00
David Dossett a987fee52e
Use solid foreground colors in v2 themes (#173844) 2023-02-08 11:46:07 -08:00
David Dossett d30d44aea2
Fix textPreformat.foreground in v2 themes (#173848) 2023-02-08 10:06:07 -08:00