Commit Graph

17 Commits

Author SHA1 Message Date
Robo
5216c04428
chore: update to electron 29 (#209818)
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs a0f9e09f64

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs eacec5f490

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Robo
974c6b3fb9
chore: update to electron 28 (#203956)
* chore: update electron@28.1.4

* ci: use latest Node.js v18 release

18.18.2 has npm version that has removed the node-gyp script
which will cause native modules fail to build that rely on
something like `install: node-gyp rebuild`

Refs c93edb55f5

* chore: update rpm dependencies

* chore: bump electron@28.2.1

* chore: bump nodejs@18.18.2

* chore: bump electron@28.2.2

* chore: bump distro
2024-02-26 12:11:47 +01:00
João Moreno
417e17038c
Use NodeJS mirror for more reliable downloads (#196038)
get node from mirror
2023-10-20 09:53:57 +02:00
Raymond Zhao
187fa0eff0
Ignore unloadable PDBs (#194731) 2023-10-07 01:39:58 +09:00
Rob Lourens
df7d3d0540
Downgrade nvmrc to unblock build (#194961)
See #194921
2023-10-06 11:40:19 +09:00
Rob Lourens
7d4027b62b
Test using nvmrc in CI (#194836)
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f37d5.

* Make all jobs use node from nvmrc
And install node-gyp where needed
2023-10-04 19:08:50 -07:00
Connor Peet
6004a9f716
debug: put user data dir in home dir, update versions of things (#189855) 2023-08-07 19:46:38 +01:00
Robo
e5f61433b5
chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Robo
3a11b47eee
chore: revert to Electron 19 (#175851)
* Revert "Update to min supported version of node (#175723)"

This reverts commit f749e6be2d.

* Revert "chore: update min node version for development (#175663)"

This reverts commit f2a822fbe9.

* Revert "electron 22 sandbox - enable for OSS (#175659)"

This reverts commit 2551af21f8.

* Revert "chore: update to Electron 22 (#166430)"

This reverts commit 6e85d2b51e.
2023-03-02 02:58:46 -08:00
Don Jayamanne
f749e6be2d
Update to min supported version of node (#175723) 2023-03-01 03:02:10 +01:00
Errietta Erry Kostala
9e0de4af67
Add .nvmrc (#152883)
Since the contribution guidelines advise on a specific version of node,
it adding .nvmrc for those that use nvm will automatically let them use the
correct version of node if they do nvm use

just a small QOL thing for devs.

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-07-22 15:55:53 +02:00
João Moreno
0f779f644f
remove nvmrc 2020-09-30 11:09:03 +02:00
Alasdair McLeay
65579c1715
Update .nvmrc
How to contribute lists recommendation of node 10:

> Node.JS, 64-bit, recommended >=10.15.1, < 11.0.0
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites

Updating .nvmrc to match
2019-03-18 15:13:14 +00:00
Thien Do
13b73269d9
Update nvmrc
As noted in [the wiki](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) node's version should be larger than 8.12 so 8.9.2 will not work.

In fact, I think we only need to define the target version as `8` so we can have the latest version that satisfies the requirement (`>= 8.12.0, < 9.0.0`). At the time of writing it is `8.15` which works perfectly fine (install + watch + run).
2019-01-28 00:57:32 +07:00
Tomer Ohana
3070e87332 Add .nvmrc file 2017-12-06 19:10:45 +02:00
Joao Moreno
800e3db207 Revert "add .nvmrc for using osx native fs-events with gulp"
This reverts commit bdbd4fa2f2.
2016-03-09 18:36:35 +01:00
Joao Moreno
bdbd4fa2f2 add .nvmrc for using osx native fs-events with gulp 2016-03-09 17:40:45 +01:00