* esm - remove `graceful-fs`
This module was used to patch `fs`, which is not supported in ESM. Besides, it makes us behave different from standard node.js that has meanwhile evolved from the time where `graceful-fs` was created.
* update comment
* update comment
* use more `fs.promises`
* 💄
This adds a new (off by default) eslint rule that disables two specific types of dangerous type assertions:
```ts
<Type>{...};
{...} as Type;
```
These are bad because they can easily hide missing properties and strictness errors
Right now just adding this rule but will assign out fixes to owners in different areas of the code
`DisposableStore`/`MutableDisposable` properties should almost always be `readonly`. Otherwise it's easy to accidentally overwrite the property and leak the previous value. This commonly happens with code such as:
```ts
class Foo {
private disposables = new DisposableStore();
bar() {
this.disposables = new DisposableStore(); // leaks old values
...
}
```
This change adds an eslint rule to enforce this and adopts `readonly` for the caught cases. I only needed to add 2 suppression comments, which seems like an acceptable tradeoff for helping catch a common mistake
* Fix injected services becoming public by mistake
Fixes cases of `@IFooService readonly foo: IFooService`. This makes the service public, which is likely not expected and also means we can't mangle it
* Fix name
* Remove unused props
* test: add ensureNoDisposablesAreLeakedInTestSuite
* fix: register moar disposables
* chore: adjust some registrations
* chore: preferencesService is a singleton
* fix: revert to registering the input within the singleton
* make TestEditorService disposable and dispose its inputs
* rm leak
---------
Co-authored-by: Connor Peet <connor@peet.io>
Adds a lint rule that ensures ensureNoDisposablesAreLeakedInTestSuite
is called in suites. It grandfathers in existing files that were lacking
the call entirely.
This PR also includes manual fixes to files that used the function
already but were missing it in one or more suites, which the lint rule
detects.
This adds an `assertHeap` function that can be used in tests. It
takes a heap snapshot, and asserts the state of classes in memory. This
works in Node and the Electron sandbox, but is a no-op in the browser.
Snapshots are process asynchronously and will report failures at the end
of the suite.
This method should be used sparingly (e.g. once at the end of a suite to
ensure nothing leaked before), as gathering a heap snapshot is fairly
slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots).
When used, the function will ensure the test has a minimum timeout
duration of 20s to avoid immediate failures.
It takes options containing a mapping of class names, and assertion functions
to run on the number of retained instances of that class. For example:
```ts
assertSnapshot({
classes: {
ShouldNeverLeak: count => assert.strictEqual(count, 0),
SomeSingleton: count => assert(count <= 1),
}
});
```
Closes https://github.com/microsoft/vscode/issues/191920
