development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #174375. Better scrollable check for outputs. (#175367)

Browse source
This commit is contained in:
Peng Lyu 2023-02-24 09:59:00 -08:00 committed by GitHub
parent de97fd7334
commit ffc78442f1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file

@ -366,11 +366,26 @@ async function webviewPreloads(ctx: PreloadContext) {
return false;
}
// scroll up
if (event.deltaY < 0 && node.scrollTop > 0) {
// there is still some content to scroll
return true;
}
// scroll down
if (event.deltaY > 0 && node.scrollTop + node.clientHeight < node.scrollHeight) {
// per https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight
// scrollTop is not rounded but scrollHeight and clientHeight are
// so we need to check if the difference is less than some threshold
if (node.scrollHeight - node.scrollTop - node.clientHeight < 2) {
continue;
}
// if the node is not scrollable, we can continue. We don't check the computed style always as it's expensive
if (window.getComputedStyle(node).overflowY === 'hidden' || window.getComputedStyle(node).overflowY === 'visible') {
continue;
}
return true;
}
}