development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 09:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

allow time to scroll (#204646)

Browse source
This commit is contained in:
Aaron Munger 2024-02-07 11:08:03 -08:00 committed by GitHub
parent 533da38207
commit fe6db4073f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
extensions/vscode-api-tests/src/singlefolder-tests/interactiveWindow.test.ts
View file

@ -99,8 +99,13 @@ async function addCellAndRun(code: string, notebook: vscode.NotebookDocument) {
}
// Verify visible range has the last cell
assert.strictEqual(notebookEditor.visibleRanges[notebookEditor.visibleRanges.length - 1].end, notebookEditor.notebook.cellCount, `Last cell is not visible`);
if (!lastCellIsVisible(notebookEditor)) {
// scroll happens async, so give it some time to scroll
await new Promise<void>((resolve) => setTimeout(() => {
assert.ok(lastCellIsVisible(notebookEditor), `Last cell is not visible`);
resolve();
}, 1000));
}
});
test('Interactive window has the correct kernel', async () => {
@ -120,3 +125,8 @@ async function addCellAndRun(code: string, notebook: vscode.NotebookDocument) {
});
});
function lastCellIsVisible(notebookEditor: vscode.NotebookEditor) {
const lastVisibleCell = notebookEditor.visibleRanges[notebookEditor.visibleRanges.length - 1].end;
return notebookEditor.notebook.cellCount === lastVisibleCell;
}