From fc1a9a48ec064237617bf1c11cae5f03a87e414f Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Sun, 16 Jun 2024 23:08:36 +0200 Subject: [PATCH] report telemetry even when not auto (#215792) --- .../browser/extensionsWorkbenchService.ts | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts b/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts index 7cc4cf224da..f76a65d5e57 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts @@ -1299,7 +1299,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension return undefined; } - async updateRunningExtensions(auto?: boolean): Promise { + async updateRunningExtensions(auto: boolean = false): Promise { const toAdd: ILocalExtension[] = []; const toRemove: string[] = []; @@ -1342,17 +1342,17 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension if (toAdd.length || toRemove.length) { if (await this.extensionService.stopExtensionHosts(nls.localize('restart', "Enable or Disable extensions"), auto)) { await this.extensionService.startExtensionHosts({ toAdd, toRemove }); - if (auto) { - type ExtensionsAutoRestartClassification = { - owner: 'sandy081'; - comment: 'Report when extensions are auto restarted'; - count: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Number of extensions auto restarted' }; - }; - type ExtensionsAutoRestartEvent = { - count: number; - }; - this.telemetryService.publicLog2('extensions:autorestart', { count: toAdd.length + toRemove.length }); - } + type ExtensionsAutoRestartClassification = { + owner: 'sandy081'; + comment: 'Report when extensions are auto restarted'; + count: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Number of extensions auto restarted' }; + auto: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the restart was triggered automatically' }; + }; + type ExtensionsAutoRestartEvent = { + count: number; + auto: boolean; + }; + this.telemetryService.publicLog2('extensions:autorestart', { count: toAdd.length + toRemove.length, auto }); } } }