development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-01 08:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #215410 (#216828)

Browse source
This commit is contained in:
Sandeep Somavarapu 2024-06-21 18:45:33 +02:00 committed by GitHub
parent 68ca9a7f4c
commit f44e0dad3b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/vs/platform/extensionManagement/node/extensionManagementService.ts
View file

@ -971,16 +971,15 @@ class InstallExtensionInProfileTask extends AbstractExtensionTask<ILocalExtensio
throw new Error(nls.localize('restartCode', "Please restart VS Code before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
}
}
} else {
// Remove the extension with same version if it is already uninstalled.
// Installing a VSIX extension shall replace the existing extension always.
const existingWithSameVersion = await this.unsetIfUninstalled(this.extensionKey);
if (existingWithSameVersion) {
try {
await this.extensionsScanner.removeExtension(existingWithSameVersion, 'existing');
} catch (e) {
throw new Error(nls.localize('restartCode', "Please restart VS Code before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
}
}
// Remove the extension with same version if it is already uninstalled.
// Installing a VSIX extension shall replace the existing extension always.
const existingWithSameVersion = await this.unsetIfUninstalled(this.extensionKey);
if (existingWithSameVersion) {
try {
await this.extensionsScanner.removeExtension(existingWithSameVersion, 'existing');
} catch (e) {
throw new Error(nls.localize('restartCode', "Please restart VS Code before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
}
}