mirror of
https://github.com/Microsoft/vscode
synced 2024-09-18 01:58:27 +00:00
ReferenceWidget should call clear to reset itself when the model changes
This commit is contained in:
parent
79aace1b39
commit
f16e33cf13
|
@ -194,8 +194,8 @@ export class ReferenceWidget extends PeekViewWidget {
|
|||
private _model: ReferencesModel | undefined;
|
||||
private _decorationsManager: DecorationsManager;
|
||||
|
||||
private _disposeOnNewModel = new DisposableStore();
|
||||
private _callOnDispose = new DisposableStore();
|
||||
private readonly _disposeOnNewModel = new DisposableStore();
|
||||
private readonly _callOnDispose = new DisposableStore();
|
||||
private _onDidSelectReference = new Emitter<SelectionEvent>();
|
||||
|
||||
private _tree: WorkbenchAsyncDataTree<ReferencesModel | FileReferences, TreeElement, FuzzyScore>;
|
||||
|
@ -230,6 +230,7 @@ export class ReferenceWidget extends PeekViewWidget {
|
|||
dispose(): void {
|
||||
this.setModel(undefined);
|
||||
this._callOnDispose.dispose();
|
||||
this._disposeOnNewModel.dispose();
|
||||
dispose(this._preview);
|
||||
dispose(this._previewNotAvailableMessage);
|
||||
dispose(this._tree);
|
||||
|
@ -424,7 +425,7 @@ export class ReferenceWidget extends PeekViewWidget {
|
|||
|
||||
public setModel(newModel: ReferencesModel | undefined): Promise<any> {
|
||||
// clean up
|
||||
this._disposeOnNewModel = dispose(this._disposeOnNewModel);
|
||||
this._disposeOnNewModel.clear();
|
||||
this._model = newModel;
|
||||
if (this._model) {
|
||||
return this._onNewModel();
|
||||
|
|
Loading…
Reference in a new issue