development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add telemetry comments (#155503)

Browse source 
* add telemetry comments

* update comments
This commit is contained in:
João Moreno 2022-07-18 16:44:01 +02:00 committed by GitHub
parent 4b0d6f3bbc
commit f127c6cf28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/vs/platform/update/electron-main/abstractUpdateService.ts
View file

@ -20,7 +20,8 @@ export function createUpdateURL(platform: string, quality: string, productServic
export type UpdateNotAvailableClassification = {
owner: 'joaomoreno';
explicit: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true };
explicit: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the user has manually checked for updates, or this was an automatic check.' };
comment: 'This is used to understand how often VS Code pings the update server for an update and there\'s none available.';
};
export abstract class AbstractUpdateService implements IUpdateService {

3
src/vs/platform/update/electron-main/updateService.darwin.ts
View file

@ -93,7 +93,8 @@ export class DarwinUpdateService extends AbstractUpdateService {
type UpdateDownloadedClassification = {
owner: 'joaomoreno';
version: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
version: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The version number of the new VS Code that has been downloaded.' };
comment: 'This is used to know how often VS Code has successfully downloaded the update.';
};
this.telemetryService.publicLog2<{ version: String }, UpdateDownloadedClassification>('update:downloaded', { version: update.version });

3
src/vs/workbench/api/common/extHostSCM.ts
View file

@ -745,7 +745,8 @@ export class ExtHostSCM implements ExtHostSCMShape {
type TEvent = { extensionId: string };
type TMeta = {
owner: 'joaomoreno';
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The ID of the extension contributing to the Source Control API.' };
comment: 'This is used to know what extensions contribute to the Source Control API.';
};
this._telemetry.$publicLog2<TEvent, TMeta>('api/scm/createSourceControl', {
extensionId: extension.identifier.value,

5
src/vs/workbench/browser/parts/views/viewPane.ts
View file

@ -52,8 +52,9 @@ export interface IViewPaneOptions extends IPaneOptions {
type WelcomeActionClassification = {
owner: 'joaomoreno';
viewId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
uri: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
viewId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The view ID in which the welcome view button was clicked.' };
uri: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The URI of the command ran by the result of clicking the button.' };
comment: 'This is used to know when users click on the welcome view buttons.';
};
const viewPaneContainerExpandedIcon = registerIcon('view-pane-container-expanded', Codicon.chevronDown, nls.localize('viewPaneContainerExpandedIcon', 'Icon for an expanded view pane container.'));

3
src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts
View file

@ -83,7 +83,8 @@ export interface ExtensionUrlHandlerEvent {
export interface ExtensionUrlHandlerClassification extends GDPRClassification<ExtensionUrlHandlerEvent> {
owner: 'joaomoreno';
readonly extensionId: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight' };
readonly extensionId: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; comment: 'The ID of the extension that should handle the URI' };
comment: 'This is used to understand the drop funnel of extension URI handling by the OS & VS Code.';
}
/**