From f00cf99102eee522ee2d8e3e74cf3c1e75621718 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Fri, 16 Nov 2018 09:04:02 +0100 Subject: [PATCH] Can be undefined (#63033) --- build/lib/extensions.js | 10 ++++++---- build/lib/extensions.ts | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/build/lib/extensions.js b/build/lib/extensions.js index 49699b797b6..994d1336e6b 100644 --- a/build/lib/extensions.js +++ b/build/lib/extensions.js @@ -36,10 +36,12 @@ function fromLocalWebpack(extensionPath, sourceMappingURLBase) { const result = es.through(); const packagedDependencies = []; const packageJsonConfig = require(path.join(extensionPath, 'package.json')); - const webpackRootConfig = require(path.join(extensionPath, 'extension.webpack.config.js')); - for (const key in webpackRootConfig.externals) { - if (key in packageJsonConfig.dependencies) { - packagedDependencies.push(key); + if (packageJsonConfig.dependencies) { + const webpackRootConfig = require(path.join(extensionPath, 'extension.webpack.config.js')); + for (const key in webpackRootConfig.externals) { + if (key in packageJsonConfig.dependencies) { + packagedDependencies.push(key); + } } } vsce.listFiles({ cwd: extensionPath, packageManager: vsce.PackageManager.Yarn, packagedDependencies }).then(fileNames => { diff --git a/build/lib/extensions.ts b/build/lib/extensions.ts index 75d02370319..844b711a829 100644 --- a/build/lib/extensions.ts +++ b/build/lib/extensions.ts @@ -39,10 +39,12 @@ function fromLocalWebpack(extensionPath: string, sourceMappingURLBase: string | const packagedDependencies: string[] = []; const packageJsonConfig = require(path.join(extensionPath, 'package.json')); - const webpackRootConfig = require(path.join(extensionPath, 'extension.webpack.config.js')); - for (const key in webpackRootConfig.externals) { - if (key in packageJsonConfig.dependencies) { - packagedDependencies.push(key); + if (packageJsonConfig.dependencies) { + const webpackRootConfig = require(path.join(extensionPath, 'extension.webpack.config.js')); + for (const key in webpackRootConfig.externals) { + if (key in packageJsonConfig.dependencies) { + packagedDependencies.push(key); + } } }