development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve windows update ux

Browse source
This commit is contained in:
Joao Moreno 2018-03-28 12:06:59 +02:00
parent 15ca98b189
commit ef7763a2d5
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/workbench/parts/update/electron-browser/update.ts
View file

@ -355,7 +355,7 @@ export class UpdateContribution implements IGlobalActivity {
const handle = this.notificationService.notify({
severity: severity.Info,
message: nls.localize('updateAvailable', "There's an available update: {0} {1}", product.nameLong, update.productVersion),
message: nls.localize('updateAvailable', "There's an update available: {0} {1}", product.nameLong, update.productVersion),
actions: { primary: [installUpdateAction, NotNowAction, releaseNotesAction] }
});
once(handle.onDidDispose)(() => dispose(installUpdateAction, releaseNotesAction));
@ -379,7 +379,7 @@ export class UpdateContribution implements IGlobalActivity {
// windows and mac
private onUpdateReady(update: IUpdate): void {
if (!this.shouldShowNotification()) {
if (!isWindows && !this.shouldShowNotification()) {
return;
}
@ -396,10 +396,6 @@ export class UpdateContribution implements IGlobalActivity {
}
private shouldShowNotification(): boolean {
if (isWindows) {
return true;
}
const currentVersion = product.commit;
const currentMillis = new Date().getTime();
const lastKnownVersion = this.storageService.get('update/lastKnownVersion', StorageScope.GLOBAL);