development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-06 03:17:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

show inline chat content widget above selection (#208997)

Browse source
This commit is contained in:
Johannes Rieken 2024-03-28 11:21:33 +01:00 committed by GitHub
parent 94f7c1d971
commit edfd5b8ba5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/inlineChat/browser/inlineChatContentWidget.ts
View file

@ -124,7 +124,7 @@ export class InlineChatContentWidget implements IContentWidget {
}
return {
position: this._position,
preference: [ContentWidgetPositionPreference.BELOW]
preference: [ContentWidgetPositionPreference.ABOVE]
};
}

14
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts
View file

@ -935,12 +935,14 @@ export class InlineChatController implements IEditorContribution {
} else if (initialRender) {
const selection = this._editor.getSelection();
widgetPosition = selection.getEndPosition();
if (Range.spansMultipleLines(selection) && widgetPosition.column === 1) {
// selection ends on "nothing" -> move up to match the
// rendered/visible part of the selection
widgetPosition = this._editor.getModel().validatePosition(widgetPosition.delta(-1, Number.MAX_SAFE_INTEGER));
}
widgetPosition = selection.getStartPosition();
// TODO@jrieken we are not ready for this
// widgetPosition = selection.getEndPosition();
// if (Range.spansMultipleLines(selection) && widgetPosition.column === 1) {
// // selection ends on "nothing" -> move up to match the
// // rendered/visible part of the selection
// widgetPosition = this._editor.getModel().validatePosition(widgetPosition.delta(-1, Number.MAX_SAFE_INTEGER));
// }
this._input.value.show(widgetPosition);
} else {