development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove resourceColumn logic for markdown previews

Browse source 
Makes dynamic markdown previews always sync to any markdown document that is active instead of only ones that become active in  a specific column. The old behavior became very confusing once you start moving markdown previews about
This commit is contained in:
Matt Bierner 2018-02-26 17:59:50 -08:00
parent f10b71e994
commit ecc7279182
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/markdown/src/features/previewContentProvider.ts
View file

@ -292,7 +292,6 @@ class MarkdownPreview {
constructor(
private _resource: vscode.Uri,
public resourceColumn: vscode.ViewColumn,
previewColumn: vscode.ViewColumn,
public readonly pinned: boolean,
private readonly contentProvider: MarkdownContentProvider,
@ -493,7 +492,7 @@ export class MarkdownPreviewManager {
if (editor && editor.editorType === 'texteditor') {
if (isMarkdownFile(editor.document)) {
for (const preview of this.previews.filter(preview => !preview.pinned && preview.resourceColumn === editor.viewColumn)) {
for (const preview of this.previews.filter(preview => !preview.pinned)) {
preview.update(editor.document.uri);
}
}
@ -524,10 +523,9 @@ export class MarkdownPreviewManager {
): void {
let preview = this.getExistingPreview(resource, previewSettings);
if (preview) {
preview.resourceColumn = previewSettings.resourceColumn;
preview.show(previewSettings.previewColumn);
} else {
preview = new MarkdownPreview(resource, previewSettings.resourceColumn, previewSettings.previewColumn, previewSettings.pinned, this.contentProvider, this.previewConfigurations, this.logger);
preview = new MarkdownPreview(resource, previewSettings.previewColumn, previewSettings.pinned, this.contentProvider, this.previewConfigurations, this.logger);
preview.onDispose(() => {
const existing = this.previews.indexOf(preview!);
if (existing >= 0) {