mirror of
https://github.com/Microsoft/vscode
synced 2024-10-12 22:37:41 +00:00
protect against bad results, #11455
This commit is contained in:
parent
0c4759ac1a
commit
ec8f8da569
|
@ -156,9 +156,11 @@ export class MainThreadLanguageFeatures extends MainThreadLanguageFeaturesShape
|
|||
this._registrations[handle] = WorkspaceSymbolProviderRegistry.register(<IWorkspaceSymbolProvider>{
|
||||
provideWorkspaceSymbols: (search: string): TPromise<IWorkspaceSymbol[]> => {
|
||||
return this._proxy.$provideWorkspaceSymbols(handle, search).then(result => {
|
||||
if (result) {
|
||||
for (const item of result) {
|
||||
trackGarbageCollection(item, ObjectIdentifier.get(item));
|
||||
}
|
||||
}
|
||||
return result;
|
||||
});
|
||||
},
|
||||
|
@ -187,9 +189,11 @@ export class MainThreadLanguageFeatures extends MainThreadLanguageFeaturesShape
|
|||
triggerCharacters: triggerCharacters,
|
||||
provideCompletionItems: (model:IReadOnlyModel, position:EditorPosition, token:CancellationToken): Thenable<modes.ISuggestResult> => {
|
||||
return wireCancellationToken(token, this._proxy.$provideCompletionItems(handle, model.uri, position)).then(result => {
|
||||
if (result && result.suggestions) {
|
||||
for (const suggestion of result.suggestions) {
|
||||
trackGarbageCollection(suggestion, ObjectIdentifier.get(suggestion));
|
||||
}
|
||||
}
|
||||
return result;
|
||||
});
|
||||
},
|
||||
|
|
Loading…
Reference in a new issue