development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-12 14:30:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

protect against bad results, #11455

Browse source
This commit is contained in:
Johannes Rieken 2016-09-19 15:54:17 +02:00
parent 0c4759ac1a
commit ec8f8da569
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/api/node/mainThreadLanguageFeatures.ts
View file

@ -156,8 +156,10 @@ export class MainThreadLanguageFeatures extends MainThreadLanguageFeaturesShape
this._registrations[handle] = WorkspaceSymbolProviderRegistry.register(<IWorkspaceSymbolProvider>{
provideWorkspaceSymbols: (search: string): TPromise<IWorkspaceSymbol[]> => {
return this._proxy.$provideWorkspaceSymbols(handle, search).then(result => {
for (const item of result) {
trackGarbageCollection(item, ObjectIdentifier.get(item));
if (result) {
for (const item of result) {
trackGarbageCollection(item, ObjectIdentifier.get(item));
}
}
return result;
});
@ -187,8 +189,10 @@ export class MainThreadLanguageFeatures extends MainThreadLanguageFeaturesShape
triggerCharacters: triggerCharacters,
provideCompletionItems: (model:IReadOnlyModel, position:EditorPosition, token:CancellationToken): Thenable<modes.ISuggestResult> => {
return wireCancellationToken(token, this._proxy.$provideCompletionItems(handle, model.uri, position)).then(result => {
for (const suggestion of result.suggestions) {
trackGarbageCollection(suggestion, ObjectIdentifier.get(suggestion));
if (result && result.suggestions) {
for (const suggestion of result.suggestions) {
trackGarbageCollection(suggestion, ObjectIdentifier.get(suggestion));
}
}
return result;
});