development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

make sure activeParameter isn't larger then aviablable parameters, fixes #4618

Browse source
This commit is contained in:
Johannes Rieken 2016-04-22 10:18:28 +02:00
parent d9b4e4d625
commit e9564ddeb0
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
extensions/typescript/src/features/signatureHelpProvider.ts
View file

@ -38,7 +38,15 @@ export default class TypeScriptSignatureHelpProvider implements SignatureHelpPro
result.activeSignature = info.selectedItemIndex;
result.activeParameter = info.argumentIndex;
info.items.forEach(item => {
if (info.items[info.selectedItemIndex].isVariadic) {
}
info.items.forEach((item, i) => {
// keep active parameter in bounds
if (i === info.selectedItemIndex && item.isVariadic) {
result.activeParameter = Math.min(info.argumentIndex, item.parameters.length - 1);
}
let signature = new SignatureInformation('');
signature.label += Previewer.plain(item.prefixDisplayParts);