Strict null checking for node/storage browser/ui/dataTree and browser/htmlContent (#65503)

* Enable strict null checking for String test

* Enable strict null checking for node/storage test

* Enable strict null checking for browser/htmlContent test

* Enable strict null checking for browser/ui/dataTree test

src/tsconfig.strictNullChecks.json

@@ -103,6 +103,7 @@
 		"./vs/base/test/browser/browser.test.ts",
 		"./vs/base/test/browser/comparers.test.ts",
 		"./vs/base/test/browser/dom.test.ts",
+		"./vs/base/test/browser/htmlContent.test.ts",
 		"./vs/base/test/browser/highlightedLabel.test.ts",
 		"./vs/base/test/browser/progressBar.test.ts",
 		"./vs/base/test/browser/ui/contextview/contextview.test.ts",
@@ -115,6 +116,7 @@
 		"./vs/base/test/browser/ui/scrollbar/scrollbarState.test.ts",
 		"./vs/base/test/browser/ui/splitview/splitview.test.ts",
 		"./vs/base/test/browser/ui/tree/asyncDataTree.test.ts",
+		"./vs/base/test/browser/ui/tree/dataTree.test.ts",
 		"./vs/base/test/browser/ui/tree/indexTreeModel.test.ts",
 		"./vs/base/test/browser/ui/tree/objectTree.test.ts",
 		"./vs/base/test/browser/ui/tree/objectTreeModel.test.ts",
@@ -168,6 +170,7 @@
 		"./vs/base/test/node/processes/fixtures/fork.ts",
 		"./vs/base/test/node/processes/fixtures/fork_large.ts",
 		"./vs/base/test/node/processes/processes.test.ts",
+		"./vs/base/test/node/storage/storage.test.ts",
 		"./vs/base/test/node/stream/stream.test.ts",
 		"./vs/base/test/node/uri.test.perf.ts",
 		"./vs/base/test/node/utils.ts",

src/vs/base/test/browser/htmlContent.test.ts

@@ -26,7 +26,7 @@ suite('HtmlContent', () => {
 	test('simple formatting', () => {
 		var result: HTMLElement = renderFormattedText('**bold**');
 		assert.strictEqual(result.children.length, 1);
-		assert.strictEqual(result.firstChild.textContent, 'bold');
+		assert.strictEqual(result.firstChild!.textContent, 'bold');
 		assert.strictEqual((<HTMLElement>result.firstChild).tagName, 'B');
 		assert.strictEqual(result.innerHTML, '<b>bold</b>');
 
@@ -62,7 +62,7 @@ suite('HtmlContent', () => {
 
 		var event: MouseEvent = <any>document.createEvent('MouseEvent');
 		event.initEvent('click', true, true);
-		result.firstChild.dispatchEvent(event);
+		result.firstChild!.dispatchEvent(event);
 		assert.strictEqual(callbackCalled, true);
 	});
 
@@ -81,7 +81,7 @@ suite('HtmlContent', () => {
 
 		var event: MouseEvent = <any>document.createEvent('MouseEvent');
 		event.initEvent('click', true, true);
-		result.firstChild.firstChild.firstChild.dispatchEvent(event);
+		result.firstChild!.firstChild!.firstChild!.dispatchEvent(event);
 		assert.strictEqual(callbackCalled, true);
 	});
 

src/vs/base/test/browser/ui/tree/dataTree.test.ts

@@ -77,34 +77,34 @@ suite('DataTree', function () {
 		tree.setInput(root);
 
 		let navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 10);
-		assert.equal(navigator.next().value, 11);
-		assert.equal(navigator.next().value, 12);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 10);
+		assert.equal(navigator.next()!.value, 11);
+		assert.equal(navigator.next()!.value, 12);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
-		tree.collapse(root.children[0]);
+		tree.collapse(root.children![0]);
 		navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
-		tree.setSelection([root.children[1]]);
-		tree.setFocus([root.children[2]]);
+		tree.setSelection([root.children![1]]);
+		tree.setFocus([root.children![2]]);
 
 		tree.setInput(empty);
 		tree.setInput(root);
 		navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 10);
-		assert.equal(navigator.next().value, 11);
-		assert.equal(navigator.next().value, 12);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 10);
+		assert.equal(navigator.next()!.value, 11);
+		assert.equal(navigator.next()!.value, 12);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
 		assert.deepEqual(tree.getSelection(), []);
 		assert.deepEqual(tree.getFocus(), []);
@@ -114,35 +114,35 @@ suite('DataTree', function () {
 		tree.setInput(root);
 
 		let navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 10);
-		assert.equal(navigator.next().value, 11);
-		assert.equal(navigator.next().value, 12);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 10);
+		assert.equal(navigator.next()!.value, 11);
+		assert.equal(navigator.next()!.value, 12);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
-		tree.collapse(root.children[0]);
+		tree.collapse(root.children![0]);
 		navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
-		tree.setSelection([root.children[1]]);
-		tree.setFocus([root.children[2]]);
+		tree.setSelection([root.children![1]]);
+		tree.setFocus([root.children![2]]);
 
 		const viewState = tree.getViewState();
 
 		tree.setInput(empty);
 		tree.setInput(root, viewState);
 		navigator = tree.navigate();
-		assert.equal(navigator.next().value, 0);
-		assert.equal(navigator.next().value, 1);
-		assert.equal(navigator.next().value, 2);
-		assert.equal(navigator.next(), null);
+		assert.equal(navigator.next()!.value, 0);
+		assert.equal(navigator.next()!.value, 1);
+		assert.equal(navigator.next()!.value, 2);
+		assert.equal(navigator.next()!, null);
 
-		assert.deepEqual(tree.getSelection(), [root.children[1]]);
-		assert.deepEqual(tree.getFocus(), [root.children[2]]);
+		assert.deepEqual(tree.getSelection(), [root.children![1]]);
+		assert.deepEqual(tree.getFocus(), [root.children![2]]);
 	});
 });

src/vs/base/test/node/storage/storage.test.ts

@@ -138,7 +138,7 @@ suite('Storage Library', () => {
 		change.set('foo', void 0);
 		database.fireDidChangeItemsExternal({ items: change });
 		ok(changes.has('foo'));
-		equal(storage.get('foo', null), null);
+		equal(storage.get('foo', null!), null);
 		changes.clear();
 
 		// Nothing happens if changing to same value
@@ -263,7 +263,7 @@ suite('SQLite Storage Library', () => {
 	}
 
 	async function testDBBasics(path, logError?: (error) => void) {
-		let options: ISQLiteStorageDatabaseOptions;
+		let options!: ISQLiteStorageDatabaseOptions;
 		if (logError) {
 			options = {
 				logging: {