development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Switch to using sha256 for checksums (fixes CodeQL warning) (#201977)

Browse source 
* Switch to using sha256 for checksums (fixes CodeQL warning)

* Fix unit test
This commit is contained in:
Alexandru Dima 2024-01-08 14:11:19 +01:00 committed by GitHub
parent 51e490e8a2
commit deae3ca4b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/gulpfile.vscode.js
View file

@ -184,7 +184,7 @@ function computeChecksum(filename) {
const contents = fs.readFileSync(filename);
const hash = crypto
.createHash('md5')
.createHash('sha256')
.update(contents)
.digest('base64')
.replace(/=+$/, '');

2
src/vs/platform/checksum/node/checksumService.ts
View file

@ -18,7 +18,7 @@ export class ChecksumService implements IChecksumService {
async checksum(resource: URI): Promise<string> {
const stream = (await this.fileService.readFileStream(resource)).value;
return new Promise<string>((resolve, reject) => {
const hash = createHash('md5');
const hash = createHash('sha256');
listenStream(stream, {
onData: data => hash.update(data.buffer),

2
src/vs/platform/checksum/test/node/checksumService.test.ts
View file

@ -35,7 +35,7 @@ suite('Checksum Service', () => {
const checksumService = new ChecksumService(fileService);
const checksum = await checksumService.checksum(URI.file(FileAccess.asFileUri('vs/platform/checksum/test/node/fixtures/lorem.txt').fsPath));
assert.ok(checksum === '8mi5KF8kcb817zmlal1kZA' || checksum === 'DnUKbJ1bHPPNZoHgHV25sg'); // depends on line endings git config
assert.ok(checksum === 'd/9bMU0ydNCmc/hg8ItWeiLT/ePnf7gyPRQVGpd6tRI' || checksum === 'eJeeTIS0dzi8MZY+nHhjPBVtNbmGqxfVvgEOB4sqVIc'); // depends on line endings git config
});
ensureNoDisposablesAreLeakedInTestSuite();