diff --git a/extensions/git/src/askpass.ts b/extensions/git/src/askpass.ts index 6afe5065657..bbd2ca576e7 100644 --- a/extensions/git/src/askpass.ts +++ b/extensions/git/src/askpass.ts @@ -20,7 +20,7 @@ export class Askpass implements Disposable { try { this.server.listen(0); - this.portPromise = new Promise(c => this.server.on('listening', () => c(this.server.address().port))); + this.portPromise = new Promise(c => this.server.on('listening', () => c(this.server.address().port))); this.server.on('error', err => console.error(err)); } catch (err) { this.enabled = false; diff --git a/extensions/git/src/commands.ts b/extensions/git/src/commands.ts index dcd402e8556..db3bf427fc0 100644 --- a/extensions/git/src/commands.ts +++ b/extensions/git/src/commands.ts @@ -533,7 +533,7 @@ export class CommandCenter { } private async smartCommit( - getCommitMessage: () => Promise, + getCommitMessage: () => Promise, opts?: CommitOptions ): Promise { if (!opts) { diff --git a/extensions/git/src/util.ts b/extensions/git/src/util.ts index 08113a9f433..668dcf56fdc 100644 --- a/extensions/git/src/util.ts +++ b/extensions/git/src/util.ts @@ -68,7 +68,7 @@ export function once(event: Event): Event { } export function eventToPromise(event: Event): Promise { - return new Promise(c => once(event)(c)); + return new Promise(c => once(event)(c)); } // TODO@Joao: replace with Object.assign @@ -104,11 +104,11 @@ export function groupBy(arr: T[], fn: (el: T) => string): { [key: string]: T[ } export function denodeify(fn: Function): (...args) => Promise { - return (...args) => new Promise((c, e) => fn(...args, (err, r) => err ? e(err) : c(r))); + return (...args) => new Promise((c, e) => fn(...args, (err, r) => err ? e(err) : c(r))); } export function nfcall(fn: Function, ...args): Promise { - return new Promise((c, e) => fn(...args, (err, r) => err ? e(err) : c(r))); + return new Promise((c, e) => fn(...args, (err, r) => err ? e(err) : c(r))); } export async function mkdirp(path: string, mode?: number): Promise { diff --git a/extensions/php/src/features/utils/async.ts b/extensions/php/src/features/utils/async.ts index 131bd8f48fd..f9c86930453 100644 --- a/extensions/php/src/features/utils/async.ts +++ b/extensions/php/src/features/utils/async.ts @@ -176,7 +176,7 @@ export class ThrottledDelayer extends Delayer> { constructor(defaultDelay: number) { super(defaultDelay); - this.throttler = new Throttler(); + this.throttler = new Throttler(); } public trigger(promiseFactory: ITask>, delay?: number): Promise> { diff --git a/extensions/typescript/src/features/formattingProvider.ts b/extensions/typescript/src/features/formattingProvider.ts index 7e390462c34..77f6971201e 100644 --- a/extensions/typescript/src/features/formattingProvider.ts +++ b/extensions/typescript/src/features/formattingProvider.ts @@ -117,13 +117,15 @@ export default class TypeScriptFormattingProvider implements DocumentRangeFormat if (!absPath) { return Promise.resolve(Object.create(null)); } + + const formatOptions = this.getFormatOptions(options); const args: Proto.ConfigureRequestArguments = { file: absPath, - formatOptions: this.getFormatOptions(options) + formatOptions: formatOptions }; return this.client.execute('configure', args, token).then(_ => { - this.formatOptions[key] = args.formatOptions; - return args.formatOptions; + this.formatOptions[key] = formatOptions; + return formatOptions; }); } } diff --git a/extensions/typescript/src/typescriptMain.ts b/extensions/typescript/src/typescriptMain.ts index 4d8c74bbc54..186f4c73d0d 100644 --- a/extensions/typescript/src/typescriptMain.ts +++ b/extensions/typescript/src/typescriptMain.ts @@ -123,7 +123,7 @@ export function activate(context: ExtensionContext): void { window.onDidChangeActiveTextEditor(VersionStatus.showHideStatus, null, context.subscriptions); client.onReady().then(() => { context.subscriptions.push(ProjectStatus.create(client, - path => new Promise(resolve => setTimeout(() => resolve(clientHost.handles(path)), 750)), + path => new Promise(resolve => setTimeout(() => resolve(clientHost.handles(path)), 750)), context.workspaceState)); }, () => { // Nothing to do here. The client did show a message; diff --git a/extensions/typescript/src/typescriptServiceClient.ts b/extensions/typescript/src/typescriptServiceClient.ts index 072dfa2d087..5c3812cd5d8 100644 --- a/extensions/typescript/src/typescriptServiceClient.ts +++ b/extensions/typescript/src/typescriptServiceClient.ts @@ -686,7 +686,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient if (localModulePath) { tryShowRestart(localModulePath); } - return localModulePath; + return localModulePath || ''; }); case MessageAction.useBundled: return this.workspaceState.update(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false) diff --git a/extensions/typescript/src/utils/async.ts b/extensions/typescript/src/utils/async.ts index 35aa1ea4afe..fb260bde50b 100644 --- a/extensions/typescript/src/utils/async.ts +++ b/extensions/typescript/src/utils/async.ts @@ -13,7 +13,7 @@ export class Delayer { public defaultDelay: number; private timeout: any; // Timer - private completionPromise: Promise | null; + private completionPromise: Promise | null; private onSuccess: ((value?: T | Thenable) => void) | null; private task: ITask | null; @@ -25,7 +25,7 @@ export class Delayer { this.task = null; } - public trigger(task: ITask, delay: number = this.defaultDelay): Promise { + public trigger(task: ITask, delay: number = this.defaultDelay): Promise { this.task = task; if (delay >= 0) { this.cancelTimeout(); @@ -55,7 +55,7 @@ export class Delayer { return this.completionPromise; } - public forceDelivery(): Promise | null { + public forceDelivery(): Promise | null { if (!this.completionPromise) { return null; }