development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 17:32:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use fs.readFile instead of openTextDocument (#175077)

Browse source
This commit is contained in:
Joyce Er 2023-02-22 06:35:34 +00:00 committed by GitHub
parent 2b838fda85
commit d7fec23a8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/extension-editing/src/extensionLinter.ts
View file

@ -12,6 +12,7 @@ import * as MarkdownItType from 'markdown-it';
import { languages, workspace, Disposable, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position, env, l10n } from 'vscode';
import { INormalizedVersion, normalizeVersion, parseVersion } from './extensionEngineValidation';
import { TextDecoder } from 'util';
const product = JSON.parse(fs.readFileSync(path.join(env.appRoot, 'product.json'), { encoding: 'utf-8' }));
const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders || []).map((s: string) => s.toLowerCase());
@ -69,6 +70,7 @@ export class ExtensionLinter {
private timer: NodeJS.Timer | undefined;
private markdownIt: MarkdownItType.MarkdownIt | undefined;
private parse5: typeof import('parse5') | undefined;
private textDecoder = new TextDecoder();
constructor() {
this.disposables.push(
@ -346,8 +348,8 @@ export class ExtensionLinter {
}
const file = folder.with({ path: path.posix.join(folder.path, 'package.json') });
try {
const document = await workspace.openTextDocument(file);
return parseTree(document.getText());
const fileContents = await workspace.fs.readFile(file); // #174888
return parseTree(this.textDecoder.decode(fileContents));
} catch (err) {
return undefined;
}