development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 09:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

cli: ensure vscode server outlives CLI on windows (#210279)

Browse source
This commit is contained in:
Connor Peet 2024-04-12 16:50:34 -07:00 committed by GitHub
parent a9174e5ac9
commit d30b358ac7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cli/src/tunnels/code_server.rs
View file

@ -606,7 +606,9 @@ impl<'a> ServerBuilder<'a> {
// Original issue: https://github.com/microsoft/vscode/issues/184058
// Partial fix: https://github.com/microsoft/vscode/pull/184621
#[cfg(target_os = "windows")]
let cmd = cmd.creation_flags(winapi::um::winbase::CREATE_NO_WINDOW);
let cmd = cmd.creation_flags(
winapi::um::winbase::CREATE_NO_WINDOW | winapi::um::winbase::CREATE_NEW_PROCESS_GROUP | winapi::um::winbase::CREATE_BREAKAWAY_FROM_JOB,
);
let child = cmd
.stderr(std::process::Stdio::piped())