development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused method getAllRecommendations()

Browse source
This commit is contained in:
Ramya Achutha Rao 2018-11-15 18:35:53 -08:00
parent f8a46bc570
commit cb1c3ed262
2 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/platform/extensionManagement/common/extensionManagement.ts
View file

@ -426,7 +426,6 @@ export interface IExtensionTipsService {
getOtherRecommendations(): Promise<IExtensionRecommendation[]>;
getWorkspaceRecommendations(): Promise<IExtensionRecommendation[]>;
getKeymapRecommendations(): IExtensionRecommendation[];
getAllRecommendations(): Promise<IExtensionRecommendation[]>;
getKeywordsForExtension(extension: string): string[];
toggleIgnoredRecommendation(extensionId: string, shouldIgnore: boolean): void;
getAllIgnoredRecommendations(): { global: string[], workspace: string[] };

12
src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts
View file

@ -421,18 +421,6 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
.map(extensionId => (<IExtensionRecommendation>{ extensionId, sources: ['application'] }));
}
getAllRecommendations(): Promise<IExtensionRecommendation[]> {
if (!this.proactiveRecommendationsFetched) {
return Promise.resolve([]);
}
return Promise.all([
this.getWorkspaceRecommendations(),
Promise.resolve(this.getFileBasedRecommendations()),
this.getOtherRecommendations(),
Promise.resolve(this.getKeymapRecommendations())
]).then(result => flatten(result).filter(e => this.isExtensionAllowedToBeRecommended(e.extensionId)));
}
private fetchFileBasedRecommendations() {
const extensionTips = product.extensionTips;
if (!extensionTips) {