development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Remove undefined in the aria label

Browse source 
- Search extension by id
This commit is contained in:
Sandeep Somavarapu 2019-04-30 11:42:32 +02:00
parent 071a5cf16f
commit c77ec582b0
4 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/extensions/electron-browser/extensionsWidgets.ts
View file

@ -168,7 +168,7 @@ export class TooltipWidget extends ExtensionWidget {
this.parent.removeAttribute('aria-label');
this.parent.title = this.getTooltip();
if (this.extension) {
this.parent.setAttribute('aria-label', localize('extension-arialabel', "{0}. {1} Press enter for extension details.", this.extension.displayName));
this.parent.setAttribute('aria-label', localize('extension-arialabel', "{0}. Press enter for extension details.", this.extension.displayName));
}
}

3
test/smoke/src/areas/extensions/extensions.test.ts
View file

@ -15,10 +15,9 @@ export function setup() {
return;
}
const extensionName = 'vscode-smoketest-check';
await app.workbench.extensions.openExtensionsViewlet();
await app.workbench.extensions.installExtension(extensionName);
await app.workbench.extensions.installExtension('michelkaporin.vscode-smoketest-check', 'vscode-smoketest-check');
await app.workbench.extensions.waitForExtensionsViewlet();
await app.workbench.quickopen.runCommand('Smoke Test Check');

8
test/smoke/src/areas/extensions/extensions.ts
View file

@ -28,14 +28,14 @@ export class Extensions extends Viewlet {
await this.code.waitForElement(SEARCH_BOX);
}
async searchForExtension(name: string): Promise<any> {
async searchForExtension(id: string): Promise<any> {
await this.code.waitAndClick(SEARCH_BOX);
await this.code.waitForActiveElement(SEARCH_BOX);
await this.code.waitForTypeInEditor(SEARCH_BOX, `name:"${name}"`);
await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`);
}
async installExtension(name: string): Promise<void> {
await this.searchForExtension(name);
async installExtension(id: string, name: string): Promise<void> {
await this.searchForExtension(id);
const ariaLabel = `${name}. Press enter for extension details.`;
await this.code.waitAndClick(`div.extensions-viewlet[id="workbench.view.extensions"] .monaco-list-row[aria-label="${ariaLabel}"] .extension li[class='action-item'] .extension-action.install`);
await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);

3
test/smoke/src/areas/workbench/localization.test.ts
View file

@ -14,9 +14,8 @@ export function setup() {
return;
}
const extensionName = 'German Language Pack for Visual Studio Code';
await app.workbench.extensions.openExtensionsViewlet();
await app.workbench.extensions.installExtension(extensionName);
await app.workbench.extensions.installExtension('ms-ceintl.vscode-language-pack-de', 'German Language Pack for Visual Studio Code');
await app.restart({ extraArgs: ['--locale=DE'] });
});