From c6698eacedf365c2f152f1df85a79bd6da71fa02 Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Thu, 15 Sep 2022 10:21:48 +1000 Subject: [PATCH] Pass element to the JS preEvaluate renderer hook (#160851) --- extensions/notebook-renderers/src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/notebook-renderers/src/index.ts b/extensions/notebook-renderers/src/index.ts index ff07bad1524..61098afe4f3 100644 --- a/extensions/notebook-renderers/src/index.ts +++ b/extensions/notebook-renderers/src/index.ts @@ -25,7 +25,7 @@ interface JavaScriptRenderingHook { * * @return A new string of JavaScript or `undefined` to continue using the provided string. */ - preEvaluate(outputItem: OutputItem, element: string, signal: AbortSignal): string | undefined | Promise; + preEvaluate(outputItem: OutputItem, element: HTMLElement, script: string, signal: AbortSignal): string | undefined | Promise; } function clearContainer(container: HTMLElement) { @@ -103,7 +103,7 @@ async function renderJavascript(outputInfo: OutputItem, container: HTMLElement, let scriptText = outputInfo.text(); for (const hook of hooks) { - scriptText = (await hook.preEvaluate(outputInfo, scriptText, signal)) ?? scriptText; + scriptText = (await hook.preEvaluate(outputInfo, container, scriptText, signal)) ?? scriptText; if (signal.aborted) { return; }