development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-12 06:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce usage of invalid property overrides (#165293)

Browse source 
With native property fields, a few of our properties are no longer valid. This either removes them or switches them to use declare instead
This commit is contained in:
Matt Bierner 2022-11-02 19:23:14 -07:00 committed by GitHub
parent d9ed6d1ef4
commit c55ef92fed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/base/browser/ui/tree/asyncDataTree.ts
View file

@ -1150,7 +1150,7 @@ export interface ICompressibleAsyncDataTreeOptionsUpdate extends IAsyncDataTreeO
export class CompressibleAsyncDataTree<TInput, T, TFilterData = void> extends AsyncDataTree<TInput, T, TFilterData> {
protected override readonly tree!: CompressibleObjectTree<IAsyncDataTreeNode<TInput, T>, TFilterData>;
protected declare readonly tree: CompressibleObjectTree<IAsyncDataTreeNode<TInput, T>, TFilterData>;
protected readonly compressibleNodeMapper: CompressibleAsyncDataTreeNodeMapper<TInput, T, TFilterData> = new WeakMapper(node => new CompressibleAsyncDataTreeNodeWrapper(node));
private filter?: ITreeFilter<T, TFilterData>;

2
src/vs/base/browser/ui/tree/dataTree.ts
View file

@ -16,7 +16,7 @@ export interface IDataTreeOptions<T, TFilterData = void> extends IAbstractTreeOp
export class DataTree<TInput, T, TFilterData = void> extends AbstractTree<T | null, TFilterData, T | null> {
protected override model!: ObjectTreeModel<T, TFilterData>;
protected declare model: ObjectTreeModel<T, TFilterData>;
private input: TInput | undefined;
private identityProvider: IIdentityProvider<T> | undefined;

2
src/vs/base/browser/ui/tree/indexTree.ts
View file

@ -14,7 +14,7 @@ export interface IIndexTreeOptions<T, TFilterData = void> extends IAbstractTreeO
export class IndexTree<T, TFilterData = void> extends AbstractTree<T, TFilterData, number[]> {
protected override model!: IndexTreeModel<T, TFilterData>;
protected declare model: IndexTreeModel<T, TFilterData>;
constructor(
user: string,

4
src/vs/base/browser/ui/tree/objectTree.ts
View file

@ -45,7 +45,7 @@ export interface IObjectTreeViewState {
export class ObjectTree<T extends NonNullable<any>, TFilterData = void> extends AbstractTree<T | null, TFilterData, T | null> {
protected override model!: IObjectTreeModel<T, TFilterData>;
protected declare model: IObjectTreeModel<T, TFilterData>;
override get onDidChangeCollapseState(): Event<ICollapseStateChangeEvent<T | null, TFilterData>> { return this.model.onDidChangeCollapseState; }
@ -197,7 +197,7 @@ export interface ICompressibleObjectTreeOptionsUpdate extends IAbstractTreeOptio
export class CompressibleObjectTree<T extends NonNullable<any>, TFilterData = void> extends ObjectTree<T, TFilterData> implements ICompressedTreeNodeProvider<T, TFilterData> {
protected override model!: CompressibleObjectTreeModel<T, TFilterData>;
protected declare model: CompressibleObjectTreeModel<T, TFilterData>;
constructor(
user: string,

2
src/vs/platform/extensionManagement/electron-sandbox/extensionTipsService.ts
View file

@ -44,8 +44,6 @@ const lastPromptedMediumImpExeTimeStorageKey = 'extensionTips/lastPromptedMedium
export class ExtensionTipsService extends BaseExtensionTipsService {
override _serviceBrand: any;
private readonly highImportanceExecutableTips: Map<string, IExeBasedExtensionTips> = new Map<string, IExeBasedExtensionTips>();
private readonly mediumImportanceExecutableTips: Map<string, IExeBasedExtensionTips> = new Map<string, IExeBasedExtensionTips>();
private readonly allOtherExecutableTips: Map<string, IExeBasedExtensionTips> = new Map<string, IExeBasedExtensionTips>();

4
src/vs/platform/list/browser/listService.ts
View file

@ -782,7 +782,7 @@ class ListResourceNavigator<T> extends ResourceNavigator<T> {
class TableResourceNavigator<TRow> extends ResourceNavigator<TRow> {
protected override readonly widget!: Table<TRow>;
protected declare readonly widget: Table<TRow>;
constructor(
widget: Table<TRow>,
@ -798,7 +798,7 @@ class TableResourceNavigator<TRow> extends ResourceNavigator<TRow> {
class TreeResourceNavigator<T, TFilterData> extends ResourceNavigator<T> {
protected override readonly widget!: ObjectTree<T, TFilterData> | CompressibleObjectTree<T, TFilterData> | DataTree<any, T, TFilterData> | AsyncDataTree<any, T, TFilterData> | CompressibleAsyncDataTree<any, T, TFilterData>;
protected declare readonly widget: ObjectTree<T, TFilterData> | CompressibleObjectTree<T, TFilterData> | DataTree<any, T, TFilterData> | AsyncDataTree<any, T, TFilterData> | CompressibleAsyncDataTree<any, T, TFilterData>;
constructor(
widget: ObjectTree<T, TFilterData> | CompressibleObjectTree<T, TFilterData> | DataTree<any, T, TFilterData> | AsyncDataTree<any, T, TFilterData> | CompressibleAsyncDataTree<any, T, TFilterData>,

2
src/vs/workbench/browser/web.main.ts
View file

@ -197,7 +197,7 @@ export class BrowserMain extends Disposable {
}
return new class extends DisposableTunnel implements ITunnel {
override localAddress!: string;
declare localAddress: string;
}({ port: tunnel.tunnelRemotePort, host: tunnel.tunnelRemoteHost }, tunnel.localAddress, () => tunnel.dispose());
}
},

6
src/vs/workbench/contrib/tasks/common/tasks.ts
View file

@ -701,7 +701,7 @@ export abstract class CommonTask {
*/
export class CustomTask extends CommonTask {
override type!: '$customized'; // CUSTOMIZED_TASK_TYPE
declare type: '$customized'; // CUSTOMIZED_TASK_TYPE
instance: number | undefined;
@ -903,7 +903,7 @@ export class ContributedTask extends CommonTask {
* Indicated the source of the task (e.g. tasks.json or extension)
* Set in the super constructor
*/
override _source!: IExtensionTaskSource;
declare _source: IExtensionTaskSource;
instance: number | undefined;
@ -997,7 +997,7 @@ export class InMemoryTask extends CommonTask {
instance: number | undefined;
override type!: 'inMemory';
declare type: 'inMemory';
public constructor(id: string, source: IInMemoryTaskSource, label: string, type: string,
runOptions: IRunOptions, configurationProperties: IConfigurationProperties) {

2
src/vs/workbench/services/extensionManagement/electron-sandbox/extensionTipsService.ts
View file

@ -17,8 +17,6 @@ import { Schemas } from 'vs/base/common/network';
class NativeExtensionTipsService extends ExtensionTipsService implements IExtensionTipsService {
override _serviceBrand: any;
private readonly channel: IChannel;
constructor(