development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix remove recent task causing configure to run

Browse source 
Fixes #114679
This commit is contained in:
Alex Ross 2021-02-05 14:53:05 +01:00
parent 251e3e6ee3
commit c54fb3c0d1
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts
View file

@ -182,24 +182,23 @@ export class TaskQuickPick extends Disposable {
picker.onDidTriggerItemButton(async (context) => {
let task = context.item.task;
if (task && !Types.isString(task) && context.button.iconClass === ThemeIcon.asClassName(removeTaskIcon)) {
const key = task.getRecentlyUsedKey();
if (context.button.iconClass === ThemeIcon.asClassName(removeTaskIcon)) {
const key = (task && !Types.isString(task)) ? task.getRecentlyUsedKey() : undefined;
if (key) {
this.taskService.removeRecentlyUsedTask(key);
const indexToRemove = picker.items.indexOf(context.item);
if (indexToRemove >= 0) {
picker.items = [...picker.items.slice(0, indexToRemove), ...picker.items.slice(indexToRemove + 1)];
}
}
return;
}
this.quickInputService.cancel();
if (ContributedTask.is(task)) {
this.taskService.customize(task, undefined, true);
} else if (CustomTask.is(task) || ConfiguringTask.is(task)) {
if (!(await this.taskService.openConfig(task))) {
const indexToRemove = picker.items.indexOf(context.item);
if (indexToRemove >= 0) {
picker.items = [...picker.items.slice(0, indexToRemove), ...picker.items.slice(indexToRemove + 1)];
}
} else {
this.quickInputService.cancel();
if (ContributedTask.is(task)) {
this.taskService.customize(task, undefined, true);
} else if (CustomTask.is(task) || ConfiguringTask.is(task)) {
if (!(await this.taskService.openConfig(task))) {
this.taskService.customize(task, undefined, true);
}
}
}
});