development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-13 14:57:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Settings editor - fix NPE rendering settings with no description

Browse source
This commit is contained in:
Rob Lourens 2018-08-01 11:55:30 -07:00
parent adf837e769
commit c259ee91ec
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/parts/preferences/browser/settingsTree.ts
View file

@ -1025,7 +1025,7 @@ export class SettingsRenderer implements ITreeRenderer {
const result = this.renderValue(element, isSelected, templateId, <ISettingItemTemplate>template);
const firstLineOverflows = renderedDescription.firstElementChild.clientHeight > 18;
const firstLineOverflows = renderedDescription.firstElementChild && renderedDescription.firstElementChild.clientHeight > 18;
const hasExtraLines = renderedDescription.childElementCount > 1;
const needsManualOverflowIndicator = (hasExtraLines || result.overflows) && !firstLineOverflows && !isSelected;
DOM.toggleClass(template.descriptionElement, 'setting-item-description-artificial-overflow', needsManualOverflowIndicator);