development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage - use void as return type

Browse source
This commit is contained in:
Benjamin Pasero 2018-10-15 15:00:38 +02:00
parent 0a70cc6d46
commit c19f675af9
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vs/platform/storage/common/storage.ts
View file

@ -60,7 +60,7 @@ export interface IStorageService {
* The scope argument allows to define the scope of the storage
* operation to either the current workspace only or all workspaces.
*/
store(key: string, value: any, scope: StorageScope): Promise<void>;
store(key: string, value: any, scope: StorageScope): void;
/**
* Delete an element stored under the provided key from storage.
@ -68,7 +68,7 @@ export interface IStorageService {
* The scope argument allows to define the scope of the storage
* operation to either the current workspace only or all workspaces.
*/
remove(key: string, scope: StorageScope): Promise<void>;
remove(key: string, scope: StorageScope): void;
}
export const enum StorageScope {

20
src/vs/platform/storage/electron-browser/storageService.ts
View file

@ -77,12 +77,12 @@ export class StorageService extends Disposable implements IStorageService {
return this.getStorage(scope).getInteger(key, fallbackValue);
}
store(key: string, value: any, scope: StorageScope): Promise<void> {
return this.getStorage(scope).set(key, value);
store(key: string, value: any, scope: StorageScope): void {
this.getStorage(scope).set(key, value);
}
remove(key: string, scope: StorageScope): Promise<void> {
return this.getStorage(scope).delete(key);
remove(key: string, scope: StorageScope): void {
this.getStorage(scope).delete(key);
}
close(reason: ShutdownReason): Promise<void> {
@ -230,28 +230,28 @@ export class DelegatingStorageService extends Disposable implements IStorageServ
}
}
store(key: string, value: any, scope: StorageScope): Promise<void> {
store(key: string, value: any, scope: StorageScope): void {
if (this.closed) {
this.logService.warn(`Unsupported write (store) access after close (key: ${key})`);
return Promise.resolve(); // prevent writing after close to detect late write access
return; // prevent writing after close to detect late write access
}
this.storageLegacyService.store(key, value, this.convertScope(scope));
return this.storageService.store(key, value, scope);
this.storageService.store(key, value, scope);
}
remove(key: string, scope: StorageScope): Promise<void> {
remove(key: string, scope: StorageScope): void {
if (this.closed) {
this.logService.warn(`Unsupported write (remove) access after close (key: ${key})`);
return Promise.resolve(); // prevent writing after close to detect late write access
return; // prevent writing after close to detect late write access
}
this.storageLegacyService.remove(key, this.convertScope(scope));
return this.storageService.remove(key, scope);
this.storageService.remove(key, scope);
}
close(reason: ShutdownReason): Promise<void> {