Re #166603. Avoid visibility change in override. (#168122)

src/vs/workbench/contrib/notebook/browser/controller/coreActions.ts

@@ -160,7 +160,7 @@ export abstract class NotebookAction extends Action2 {
 		return !!context && !!(context as INotebookActionContext).notebookEditor;
 	}
 
-	protected getEditorContextFromArgsOrActive(accessor: ServicesAccessor, context?: any, ...additionalArgs: any[]): INotebookActionContext | undefined {
+	getEditorContextFromArgsOrActive(accessor: ServicesAccessor, context?: any, ...additionalArgs: any[]): INotebookActionContext | undefined {
 		return getContextFromActiveEditor(accessor.get(IEditorService));
 	}
 }

src/vs/workbench/contrib/notebook/browser/view/cellPart.ts

@@ -35,7 +35,7 @@ export abstract class CellContentPart extends Disposable {
 		this.didRenderCell(element);
 	}
 
-	protected didRenderCell(element: ICellViewModel): void { }
+	didRenderCell(element: ICellViewModel): void { }
 
 	/**
 	 * Dispose any disposables generated from `didRenderCell`
@@ -94,7 +94,7 @@ export abstract class CellOverlayPart extends Disposable {
 		this.didRenderCell(element);
 	}
 
-	protected didRenderCell(element: ICellViewModel): void { }
+	didRenderCell(element: ICellViewModel): void { }
 
 	/**
 	 * Dispose any disposables generated from `didRenderCell`

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellComments.ts

@@ -152,7 +152,7 @@ export class CellComments extends CellContentPart {
 		this._commentThreadWidget?.applyTheme(theme, fontInfo);
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		if (element.cellKind === CellKind.Code) {
 			this.currentElement = element as CodeCellViewModel;
 			this.initialize(element);

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellContextKeys.ts

@@ -27,7 +27,7 @@ export class CellContextKeyPart extends CellContentPart {
 		this.cellContextKeyManager = this._register(this.instantiationService.createInstance(CellContextKeyManager, notebookEditor, undefined));
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		this.cellContextKeyManager.updateForElement(element);
 	}
 }

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellDecorations.ts

@@ -15,7 +15,7 @@ export class CellDecorations extends CellContentPart {
 		super();
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		const removedClassNames: string[] = [];
 		this.rootContainer.classList.forEach(className => {
 			if (/^nb\-.*$/.test(className)) {

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellDnd.ts

@@ -37,7 +37,7 @@ export class CellDragAndDropPart extends CellContentPart {
 		super();
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		this.update(element);
 	}
 

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellExecution.ts

@@ -41,7 +41,7 @@ export class CellExecutionPart extends CellContentPart {
 		}));
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		this.updateExecutionOrder(element.internalMetadata, true);
 	}
 

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellToolbars.ts

@@ -76,7 +76,7 @@ export class BetweenCellToolbar extends CellOverlayPart {
 		return betweenCellToolbar;
 	}
 
-	protected override didRenderCell(element: ICellViewModel): void {
+	override didRenderCell(element: ICellViewModel): void {
 		const betweenCellToolbar = this._initialize();
 		betweenCellToolbar.context = <INotebookCellActionContext>{
 			ui: true,

src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelView.ts

@@ -169,7 +169,7 @@ export class NotebooKernelActionViewItem extends ActionViewItem {
 		this.updateLabel();
 	}
 
-	override updateLabel() {
+	protected override updateLabel() {
 		if (this._kernelLabel) {
 			this._kernelLabel.classList.add('kernel-label');
 			this._kernelLabel.innerText = this._action.label;