development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #186568 from microsoft/merogge/close-help-2

Browse source 
prevent help menu from being read in full when escape is used
This commit is contained in:
Megan Rogge 2023-06-28 14:43:57 -07:00 committed by GitHub
parent 68dc2206ef 89f9fb8db3
commit be624280e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
View file

@ -96,10 +96,6 @@ class AccessibleView extends Disposable {
getAnchor: () => this._editorContainer,
render: (container) => {
return this._render(provider, container);
},
onHide: () => {
provider.onClose();
this._keyListener?.dispose();
}
};
this._contextViewService.showContextView(delegate);
@ -128,6 +124,9 @@ class AccessibleView extends Disposable {
this._keyListener = this._register(this._editorWidget.onKeyUp((e) => {
if (e.keyCode === KeyCode.Escape) {
this._contextViewService.hideContextView();
// Delay to allow the context view to hide #186514
setTimeout(() => provider.onClose(), 100);
this._keyListener?.dispose();
} else if (e.keyCode === KeyCode.KeyD && this._configurationService.getValue(settingKey)) {
this._configurationService.updateValue(settingKey, false);
} else if (e.keyCode === KeyCode.KeyH && provider.options.readMoreUrl) {
@ -143,7 +142,7 @@ class AccessibleView extends Disposable {
this._editorWidget.updateOptions({ ariaLabel: provider.options.ariaLabel });
this._editorWidget.focus();
});
return toDisposable(() => provider.onClose());
return toDisposable(() => { });
}
private _layout(): void {