development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix outdated targetplatforms in web

Browse source
This commit is contained in:
Sandeep Somavarapu 2022-03-14 16:12:28 +05:30
parent 3e5c7e2c57
commit bcbf1684e2
No known key found for this signature in database
GPG key ID: DD41CAAC8081CC7D
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
View file

@ -221,7 +221,11 @@ export class Extension implements IExtension {
}
get outdatedTargetPlatform(): boolean {
return !!this.local && !!this.gallery && this.local.targetPlatform !== TargetPlatform.UNDEFINED && this.local.targetPlatform !== this.gallery.properties.targetPlatform && semver.eq(this.latestVersion, this.version);
return !!this.local && !!this.gallery
&& ![TargetPlatform.UNDEFINED, TargetPlatform.WEB].includes(this.local.targetPlatform)
&& this.gallery.properties.targetPlatform !== TargetPlatform.WEB
&& this.local.targetPlatform !== this.gallery.properties.targetPlatform
&& semver.eq(this.latestVersion, this.version);
}
get telemetryData(): any {

10
src/vs/workbench/contrib/extensions/test/electron-browser/extension.test.ts
View file

@ -56,6 +56,16 @@ suite('Extension Test', () => {
assert.strictEqual(extension.outdated, true);
});
test('extension is not outdated when local and gallery are on same version and local is on web', () => {
const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, undefined, aLocalExtension('somext', {}, { targetPlatform: TargetPlatform.WEB }), aGalleryExtension('somext'));
assert.strictEqual(extension.outdated, false);
});
test('extension is not outdated when local and gallery are on same version and gallery is on web', () => {
const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, undefined, aLocalExtension('somext'), aGalleryExtension('somext', {}, { targetPlatform: TargetPlatform.WEB }));
assert.strictEqual(extension.outdated, false);
});
test('extension is not outdated when local is not pre-release but gallery is pre-release', () => {
const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, undefined, aLocalExtension('somext', { version: '1.0.0' }), aGalleryExtension('somext', { version: '1.0.1' }, { isPreReleaseVersion: true }));
assert.strictEqual(extension.outdated, false);