development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-11-05 18:29:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Strict null check cliProcessMain

Browse source
This commit is contained in:
Matt Bierner 2018-12-17 14:46:59 -08:00
parent 113733ce42
commit b7b1088bde
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/tsconfig.strictNullChecks.json
View file

@ -170,6 +170,7 @@
"./vs/code/electron-main/sharedProcess.ts",
"./vs/code/electron-main/theme.ts",
"./vs/code/node/cli.ts",
"./vs/code/node/cliProcessMain.ts",
"./vs/code/node/paths.ts",
"./vs/code/node/shellEnv.ts",
"./vs/code/node/wait.ts",
@ -670,6 +671,7 @@
"./vs/workbench/parts/terminal/node/terminalProcess.ts",
"./vs/workbench/parts/terminal/node/terminalProcessExtHostProxy.ts",
"./vs/workbench/parts/terminal/node/windowsShellHelper.ts",
"./vs/workbench/parts/terminal/test/electron-browser/terminalColorRegistry.test.ts",
"./vs/workbench/parts/terminal/test/node/terminalCommandTracker.test.ts",
"./vs/workbench/parts/url/electron-browser/url.contribution.ts",
"./vs/workbench/parts/webview/electron-browser/webviewProtocols.ts",
@ -792,8 +794,7 @@
"./vs/workbench/services/title/common/titleService.ts",
"./vs/workbench/services/workspace/common/workspaceEditing.ts",
"./vs/workbench/test/common/editor/editorOptions.test.ts",
"./vs/workbench/test/electron-browser/api/mock.ts",
"./vs/workbench/parts/terminal/test/electron-browser/terminalColorRegistry.test.ts"
"./vs/workbench/test/electron-browser/api/mock.ts"
],
"exclude": [
"./typings/require-monaco.d.ts"

4
src/vs/code/node/cliProcessMain.ts
View file

@ -53,7 +53,7 @@ function getId(manifest: IExtensionManifest, withVersion?: boolean): string {
const EXTENSION_ID_REGEX = /^([^.]+\..+)@(\d+\.\d+\.\d+(-.*)?)$/;
export function getIdAndVersion(id: string): [string, string] {
export function getIdAndVersion(id: string): [string, string | undefined] {
const matches = EXTENSION_ID_REGEX.exec(id);
if (matches && matches[1]) {
return [adoptToGalleryExtensionId(matches[1]), matches[2]];
@ -77,7 +77,7 @@ class Main {
await this.setInstallSource(argv['install-source']);
} else if (argv['list-extensions']) {
await this.listExtensions(argv['show-versions']);
await this.listExtensions(!!argv['show-versions']);
} else if (argv['install-extension']) {
const arg = argv['install-extension'];

2
src/vs/platform/telemetry/node/commonProperties.ts
View file

@ -8,7 +8,7 @@ import * as os from 'os';
import * as uuid from 'vs/base/common/uuid';
import { readFile } from 'vs/base/node/pfs';
export function resolveCommonProperties(commit: string | undefined, version: string, machineId: string, installSourcePath: string): Promise<{ [name: string]: string | undefined; }> {
export function resolveCommonProperties(commit: string | undefined, version: string, machineId: string | undefined, installSourcePath: string): Promise<{ [name: string]: string | undefined; }> {
const result: { [name: string]: string | undefined; } = Object.create(null);
// __GDPR__COMMON__ "common.machineId" : { "endPoint": "MacAddressHash", "classification": "EndUserPseudonymizedInformation", "purpose": "FeatureInsight" }
result['common.machineId'] = machineId;