development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #186504 from microsoft/merogge/listener-disp

Browse source 
on hide of accessibility help, dispose of key listener
This commit is contained in:
Megan Rogge 2023-06-28 07:01:54 -07:00 committed by GitHub
parent 12d96e8456 af32ccc284
commit b3f5ca2d44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
View file

@ -60,6 +60,7 @@ class AccessibleView extends Disposable {
private _editorWidget: CodeEditorWidget;
get editorWidget() { return this._editorWidget; }
private _editorContainer: HTMLElement;
private _keyListener: IDisposable | undefined;
constructor(
@IOpenerService private readonly _openerService: IOpenerService,
@ -98,6 +99,7 @@ class AccessibleView extends Disposable {
},
onHide: () => {
provider.onClose();
this._keyListener?.dispose();
}
};
this._contextViewService.showContextView(delegate);
@ -123,7 +125,7 @@ class AccessibleView extends Disposable {
model.setLanguage(provider.options.language);
}
container.appendChild(this._editorContainer);
this._register(this._editorWidget.onKeyUp((e) => {
this._keyListener = this._register(this._editorWidget.onKeyUp((e) => {
if (e.keyCode === KeyCode.Escape) {
this._contextViewService.hideContextView();
} else if (e.keyCode === KeyCode.KeyD && this._configurationService.getValue(settingKey)) {