development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-19 18:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

list: renames

Browse source
This commit is contained in:
Joao Moreno 2018-10-12 12:38:31 +02:00
parent 20ce983683
commit b368ea76fb
21 changed files with 76 additions and 77 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/base/browser/ui/list/list.ts
View file

@ -5,17 +5,16 @@
import { GestureEvent } from 'vs/base/browser/touch';
export interface IVirtualDelegate<T> {
export interface IListVirtualDelegate<T> {
getHeight(element: T): number;
getTemplateId(element: T): string;
}
// TODO@joao rename to IListRenderer
export interface IRenderer<TElement, TTemplateData> {
export interface IListRenderer<T, TTemplateData> {
templateId: string;
renderTemplate(container: HTMLElement): TTemplateData;
renderElement(element: TElement, index: number, templateData: TTemplateData): void;
disposeElement(element: TElement, index: number, templateData: TTemplateData): void;
renderElement(element: T, index: number, templateData: TTemplateData): void;
disposeElement(element: T, index: number, templateData: TTemplateData): void;
disposeTemplate(templateData: TTemplateData): void;
}

8
src/vs/base/browser/ui/list/listPaging.ts
View file

@ -6,13 +6,13 @@
import 'vs/css!./list';
import { IDisposable } from 'vs/base/common/lifecycle';
import { range } from 'vs/base/common/arrays';
import { IVirtualDelegate, IRenderer, IListEvent, IListContextMenuEvent } from './list';
import { IListVirtualDelegate, IListRenderer, IListEvent, IListContextMenuEvent } from './list';
import { List, IListStyles, IListOptions } from './listWidget';
import { IPagedModel } from 'vs/base/common/paging';
import { Event, mapEvent } from 'vs/base/common/event';
import { CancellationTokenSource } from 'vs/base/common/cancellation';
export interface IPagedRenderer<TElement, TTemplateData> extends IRenderer<TElement, TTemplateData> {
export interface IPagedRenderer<TElement, TTemplateData> extends IListRenderer<TElement, TTemplateData> {
renderPlaceholder(index: number, templateData: TTemplateData): void;
}
@ -21,7 +21,7 @@ export interface ITemplateData<T> {
disposable: IDisposable;
}
class PagedRenderer<TElement, TTemplateData> implements IRenderer<number, ITemplateData<TTemplateData>> {
class PagedRenderer<TElement, TTemplateData> implements IListRenderer<number, ITemplateData<TTemplateData>> {
get templateId(): string { return this.renderer.templateId; }
@ -71,7 +71,7 @@ export class PagedList<T> implements IDisposable {
constructor(
container: HTMLElement,
virtualDelegate: IVirtualDelegate<number>,
virtualDelegate: IListVirtualDelegate<number>,
renderers: IPagedRenderer<T, any>[],
options: IListOptions<any> = {}
) {

8
src/vs/base/browser/ui/list/listView.ts
View file

@ -12,7 +12,7 @@ import { domEvent } from 'vs/base/browser/event';
import { ScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement';
import { ScrollEvent, ScrollbarVisibility } from 'vs/base/common/scrollable';
import { RangeMap, shift } from './rangeMap';
import { IVirtualDelegate, IRenderer, IListMouseEvent, IListTouchEvent, IListGestureEvent } from './list';
import { IListVirtualDelegate, IListRenderer, IListMouseEvent, IListTouchEvent, IListGestureEvent } from './list';
import { RowCache, IRow } from './rowCache';
import { isWindows } from 'vs/base/common/platform';
import * as browser from 'vs/base/browser/browser';
@ -60,7 +60,7 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
private itemId: number;
private rangeMap: RangeMap;
private cache: RowCache<T>;
private renderers = new Map<string, IRenderer<T, any>>();
private renderers = new Map<string, IListRenderer<T, any>>();
private lastRenderTop: number;
private lastRenderHeight: number;
private _domNode: HTMLElement;
@ -78,8 +78,8 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
constructor(
container: HTMLElement,
private virtualDelegate: IVirtualDelegate<T>,
renderers: IRenderer<T, any>[],
private virtualDelegate: IListVirtualDelegate<T>,
renderers: IListRenderer<T, any>[],
options: IListViewOptions = DefaultOptions
) {
this.items = [];

12
src/vs/base/browser/ui/list/listWidget.ts
View file

@ -16,7 +16,7 @@ import { KeyCode } from 'vs/base/common/keyCodes';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { Event, Emitter, EventBufferer, chain, mapEvent, anyEvent } from 'vs/base/common/event';
import { domEvent } from 'vs/base/browser/event';
import { IVirtualDelegate, IRenderer, IListEvent, IListContextMenuEvent, IListMouseEvent, IListTouchEvent, IListGestureEvent } from './list';
import { IListVirtualDelegate, IListRenderer, IListEvent, IListContextMenuEvent, IListMouseEvent, IListTouchEvent, IListGestureEvent } from './list';
import { ListView, IListViewOptions } from './listView';
import { Color } from 'vs/base/common/color';
import { mixin } from 'vs/base/common/objects';
@ -41,7 +41,7 @@ interface IRenderedContainer {
index: number;
}
class TraitRenderer<T> implements IRenderer<T, ITraitTemplateData>
class TraitRenderer<T> implements IListRenderer<T, ITraitTemplateData>
{
private renderedElements: IRenderedContainer[] = [];
@ -807,11 +807,11 @@ function relativeComplement(one: number[], other: number[]): number[] {
const numericSort = (a: number, b: number) => a - b;
class PipelineRenderer<T> implements IRenderer<T, any> {
class PipelineRenderer<T> implements IListRenderer<T, any> {
constructor(
private _templateId: string,
private renderers: IRenderer<T, any>[]
private renderers: IListRenderer<T, any>[]
) { }
get templateId(): string {
@ -903,8 +903,8 @@ export class List<T> implements ISpliceable<T>, IDisposable {
constructor(
container: HTMLElement,
virtualDelegate: IVirtualDelegate<T>,
renderers: IRenderer<T, any>[],
virtualDelegate: IListVirtualDelegate<T>,
renderers: IListRenderer<T, any>[],
options: IListOptions<T> = DefaultOptions
) {
this.focus = new FocusTrait(i => this.getElementDomId(i));

4
src/vs/base/browser/ui/list/rowCache.ts
View file

@ -3,7 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { IRenderer } from './list';
import { IListRenderer } from './list';
import { IDisposable } from 'vs/base/common/lifecycle';
import { $, removeClass } from 'vs/base/browser/dom';
@ -25,7 +25,7 @@ export class RowCache<T> implements IDisposable {
private cache = new Map<string, IRow[]>();
constructor(private renderers: Map<string, IRenderer<T, any>>) { }
constructor(private renderers: Map<string, IListRenderer<T, any>>) { }
/**
* Returns a row either by creating a new one or reusing

6
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
View file

@ -14,7 +14,7 @@ import * as dom from 'vs/base/browser/dom';
import * as arrays from 'vs/base/common/arrays';
import { IContextViewProvider, AnchorPosition } from 'vs/base/browser/ui/contextview/contextview';
import { List } from 'vs/base/browser/ui/list/listWidget';
import { IVirtualDelegate, IRenderer, IListEvent } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer, IListEvent } from 'vs/base/browser/ui/list/list';
import { domEvent } from 'vs/base/browser/event';
import { ScrollbarVisibility } from 'vs/base/common/scrollable';
import { ISelectBoxDelegate, ISelectBoxOptions, ISelectBoxStyles, ISelectData } from 'vs/base/browser/ui/selectBox/selectBox';
@ -38,7 +38,7 @@ interface ISelectListTemplateData {
disposables: IDisposable[];
}
class SelectListRenderer implements IRenderer<ISelectOptionItem, ISelectListTemplateData> {
class SelectListRenderer implements IListRenderer<ISelectOptionItem, ISelectListTemplateData> {
get templateId(): string { return SELECT_OPTION_ENTRY_TEMPLATE_ID; }
@ -90,7 +90,7 @@ class SelectListRenderer implements IRenderer<ISelectOptionItem, ISelectListTemp
}
}
export class SelectBoxList implements ISelectBoxDelegate, IVirtualDelegate<ISelectOptionItem> {
export class SelectBoxList implements ISelectBoxDelegate, IListVirtualDelegate<ISelectOptionItem> {
private static readonly DEFAULT_DROPDOWN_MINIMUM_BOTTOM_MARGIN = 32;
private static readonly DEFAULT_DROPDOWN_MINIMUM_TOP_MARGIN = 2;

10
src/vs/base/browser/ui/tree/abstractTree.ts
View file

@ -6,7 +6,7 @@
import 'vs/css!./tree';
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { IListOptions, List, IIdentityProvider, IMultipleSelectionController, IListStyles } from 'vs/base/browser/ui/list/listWidget';
import { IVirtualDelegate, IRenderer, IListMouseEvent, IListEvent, IListContextMenuEvent } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer, IListMouseEvent, IListEvent, IListContextMenuEvent } from 'vs/base/browser/ui/list/list';
import { append, $ } from 'vs/base/browser/dom';
import { Event, Relay, chain } from 'vs/base/common/event';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
@ -45,9 +45,9 @@ export function createComposedTreeListOptions<T, N extends { element: T }>(optio
};
}
export class ComposedTreeDelegate<T, N extends { element: T }> implements IVirtualDelegate<N> {
export class ComposedTreeDelegate<T, N extends { element: T }> implements IListVirtualDelegate<N> {
constructor(private delegate: IVirtualDelegate<T>) { }
constructor(private delegate: IListVirtualDelegate<T>) { }
getHeight(element: N): number {
return this.delegate.getHeight(element.element);
@ -71,7 +71,7 @@ function renderDefaultTwistie<T>(node: ITreeNode<T, any>, twistie: HTMLElement):
}
}
class TreeRenderer<T, TFilterData, TTemplateData> implements IRenderer<ITreeNode<T, TFilterData>, ITreeListTemplateData<TTemplateData>> {
class TreeRenderer<T, TFilterData, TTemplateData> implements IListRenderer<ITreeNode<T, TFilterData>, ITreeListTemplateData<TTemplateData>> {
readonly templateId: string;
private renderedElements = new Map<T, ITreeNode<T, TFilterData>>();
@ -182,7 +182,7 @@ export abstract class AbstractTree<T, TFilterData, TRef> implements IDisposable
constructor(
container: HTMLElement,
delegate: IVirtualDelegate<T>,
delegate: IListVirtualDelegate<T>,
renderers: ITreeRenderer<T, TFilterData, any>[],
options?: ITreeOptions<T, TFilterData>
) {

4
src/vs/base/browser/ui/tree/dataTree.ts
View file

@ -5,7 +5,7 @@
import { ITreeOptions, ComposedTreeDelegate, createComposedTreeListOptions } from 'vs/base/browser/ui/tree/abstractTree';
import { ObjectTree } from 'vs/base/browser/ui/tree/objectTree';
import { IVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { ITreeElement, ITreeNode, ITreeRenderer } from 'vs/base/browser/ui/tree/tree';
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { Emitter, Event } from 'vs/base/common/event';
@ -107,7 +107,7 @@ export class DataTree<T extends NonNullable<any>, TFilterData = void> implements
constructor(
container: HTMLElement,
delegate: IVirtualDelegate<T>,
delegate: IListVirtualDelegate<T>,
renderers: ITreeRenderer<T, TFilterData, any>[],
private dataSource: IDataSource<T>,
options?: ITreeOptions<T, TFilterData>

4
src/vs/base/browser/ui/tree/tree.ts
View file

@ -5,7 +5,7 @@
import { Event } from 'vs/base/common/event';
import { Iterator } from 'vs/base/common/iterator';
import { IRenderer } from 'vs/base/browser/ui/list/list';
import { IListRenderer } from 'vs/base/browser/ui/list/list';
export const enum TreeVisibility {
Hidden,
@ -67,7 +67,7 @@ export interface ITreeModel<T, TFilterData, TRef> {
getLastElementAncestor(location: TRef): T | null;
}
export interface ITreeRenderer<T, TFilterData, TTemplateData> extends IRenderer<ITreeNode<T, TFilterData>, TTemplateData> {
export interface ITreeRenderer<T, TFilterData, TTemplateData> extends IListRenderer<ITreeNode<T, TFilterData>, TTemplateData> {
renderTwistie?(element: T, twistieElement: HTMLElement): boolean;
onDidChangeTwistieState?: Event<T>;
}

6
src/vs/base/test/browser/ui/list/listView.test.ts
View file

@ -5,7 +5,7 @@
import * as assert from 'assert';
import { ListView } from 'vs/base/browser/ui/list/listView';
import { IVirtualDelegate, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer } from 'vs/base/browser/ui/list/list';
import { range } from 'vs/base/common/arrays';
suite('ListView', function () {
@ -14,14 +14,14 @@ suite('ListView', function () {
element.style.height = '200px';
element.style.width = '200px';
const delegate: IVirtualDelegate<number> = {
const delegate: IListVirtualDelegate<number> = {
getHeight() { return 20; },
getTemplateId() { return 'template'; }
};
let templatesCount = 0;
const renderer: IRenderer<number, void> = {
const renderer: IListRenderer<number, void> = {
templateId: 'template',
renderTemplate() { templatesCount++; },
renderElement() { },

6
src/vs/editor/contrib/suggest/suggestWidget.ts
View file

@ -12,7 +12,7 @@ import { onUnexpectedError } from 'vs/base/common/errors';
import { IDisposable, dispose, toDisposable } from 'vs/base/common/lifecycle';
import { addClass, append, $, hide, removeClass, show, toggleClass, getDomNodePagePosition, hasClass } from 'vs/base/browser/dom';
import { HighlightedLabel } from 'vs/base/browser/ui/highlightedlabel/highlightedLabel';
import { IVirtualDelegate, IListEvent, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListEvent, IListRenderer } from 'vs/base/browser/ui/list/list';
import { List } from 'vs/base/browser/ui/list/listWidget';
import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement';
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
@ -73,7 +73,7 @@ function canExpandCompletionItem(item: ICompletionItem) {
return (suggestion.detail && suggestion.detail !== suggestion.label);
}
class Renderer implements IRenderer<ICompletionItem, ISuggestionTemplateData> {
class Renderer implements IListRenderer<ICompletionItem, ISuggestionTemplateData> {
constructor(
private widget: SuggestWidget,
@ -351,7 +351,7 @@ export interface ISelectedSuggestion {
model: CompletionModel;
}
export class SuggestWidget implements IContentWidget, IVirtualDelegate<ICompletionItem>, IDisposable {
export class SuggestWidget implements IContentWidget, IListVirtualDelegate<ICompletionItem>, IDisposable {
private static readonly ID: string = 'editor.widget.suggestWidget';

10
src/vs/platform/list/browser/listService.ts
View file

@ -6,7 +6,7 @@
import { addClass, addStandardDisposableListener, createStyleSheet, getTotalHeight, removeClass } from 'vs/base/browser/dom';
import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { IInputOptions, InputBox } from 'vs/base/browser/ui/inputbox/inputBox';
import { IListMouseEvent, IListTouchEvent, IRenderer, IVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IListMouseEvent, IListTouchEvent, IListRenderer, IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IPagedRenderer, PagedList } from 'vs/base/browser/ui/list/listPaging';
import { DefaultStyleController, IListOptions, IMultipleSelectionController, IOpenController, isSelectionRangeChangeEvent, isSelectionSingleChangeEvent, List } from 'vs/base/browser/ui/list/listWidget';
import { canceled, onUnexpectedError } from 'vs/base/common/errors';
@ -213,8 +213,8 @@ export class WorkbenchList<T> extends List<T> {
constructor(
container: HTMLElement,
delegate: IVirtualDelegate<T>,
renderers: IRenderer<T, any>[],
delegate: IListVirtualDelegate<T>,
renderers: IListRenderer<T, any>[],
options: IListOptions<T>,
@IContextKeyService contextKeyService: IContextKeyService,
@IListService listService: IListService,
@ -288,7 +288,7 @@ export class WorkbenchPagedList<T> extends PagedList<T> {
constructor(
container: HTMLElement,
delegate: IVirtualDelegate<number>,
delegate: IListVirtualDelegate<number>,
renderers: IPagedRenderer<T, any>[],
options: IListOptions<T>,
@IContextKeyService contextKeyService: IContextKeyService,
@ -893,7 +893,7 @@ export class WorkbenchObjectTree<T extends NonNullable<any>, TFilterData = void>
constructor(
container: HTMLElement,
delegate: IVirtualDelegate<T>,
delegate: IListVirtualDelegate<T>,
renderers: ITreeRenderer<T, TFilterData, any>[],
options: ITreeOptions2<T, TFilterData>,
@IContextKeyService contextKeyService: IContextKeyService,

6
src/vs/workbench/browser/parts/notifications/notificationsViewer.ts
View file

@ -3,7 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { IVirtualDelegate, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer } from 'vs/base/browser/ui/list/list';
import { clearNode, addClass, removeClass, toggleClass, addDisposableListener, EventType, EventHelper } from 'vs/base/browser/dom';
import { IOpenerService } from 'vs/platform/opener/common/opener';
import { URI } from 'vs/base/common/uri';
@ -24,7 +24,7 @@ import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { ProgressBar } from 'vs/base/browser/ui/progressbar/progressbar';
import { Severity } from 'vs/platform/notification/common/notification';
export class NotificationsListDelegate implements IVirtualDelegate<INotificationViewItem> {
export class NotificationsListDelegate implements IListVirtualDelegate<INotificationViewItem> {
private static readonly ROW_HEIGHT = 42;
private static readonly LINE_HEIGHT = 22;
@ -177,7 +177,7 @@ class NotificationMessageRenderer {
}
}
export class NotificationRenderer implements IRenderer<INotificationViewItem, INotificationTemplateData> {
export class NotificationRenderer implements IListRenderer<INotificationViewItem, INotificationTemplateData> {
static readonly TEMPLATE_ID = 'notification';

6
src/vs/workbench/browser/parts/quickinput/quickInputList.ts
View file

@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import 'vs/css!./quickInput';
import { IVirtualDelegate, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer } from 'vs/base/browser/ui/list/list';
import * as dom from 'vs/base/browser/dom';
import { dispose, IDisposable } from 'vs/base/common/lifecycle';
import { WorkbenchList } from 'vs/platform/list/browser/listService';
@ -83,7 +83,7 @@ interface IListElementTemplateData {
toDisposeTemplate: IDisposable[];
}
class ListElementRenderer implements IRenderer<ListElement, IListElementTemplateData> {
class ListElementRenderer implements IListRenderer<ListElement, IListElementTemplateData> {
static readonly ID = 'listelement';
@ -198,7 +198,7 @@ class ListElementRenderer implements IRenderer<ListElement, IListElementTemplate
}
}
class ListElementDelegate implements IVirtualDelegate<ListElement> {
class ListElementDelegate implements IListVirtualDelegate<ListElement> {
getHeight(element: ListElement): number {
return element.saneDetail ? 44 : 22;

12
src/vs/workbench/parts/debug/browser/breakpointsView.ts
View file

@ -18,7 +18,7 @@ import { Constants } from 'vs/editor/common/core/uint';
import { dispose, IDisposable } from 'vs/base/common/lifecycle';
import { TPromise } from 'vs/base/common/winjs.base';
import { Separator } from 'vs/base/browser/ui/actionbar/actionbar';
import { IVirtualDelegate, IListContextMenuEvent, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListContextMenuEvent, IListRenderer } from 'vs/base/browser/ui/list/list';
import { IEditor } from 'vs/workbench/common/editor';
import { InputBox } from 'vs/base/browser/ui/inputbox/inputBox';
import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent';
@ -236,7 +236,7 @@ export class BreakpointsView extends ViewletPanel {
}
}
class BreakpointsDelegate implements IVirtualDelegate<IEnablement> {
class BreakpointsDelegate implements IListVirtualDelegate<IEnablement> {
constructor(private debugService: IDebugService) {
// noop
@ -292,7 +292,7 @@ interface IInputTemplateData {
toDispose: IDisposable[];
}
class BreakpointsRenderer implements IRenderer<IBreakpoint, IBreakpointTemplateData> {
class BreakpointsRenderer implements IListRenderer<IBreakpoint, IBreakpointTemplateData> {
constructor(
@IDebugService private debugService: IDebugService,
@ -361,7 +361,7 @@ class BreakpointsRenderer implements IRenderer<IBreakpoint, IBreakpointTemplateD
}
}
class ExceptionBreakpointsRenderer implements IRenderer<IExceptionBreakpoint, IBaseBreakpointTemplateData> {
class ExceptionBreakpointsRenderer implements IListRenderer<IExceptionBreakpoint, IBaseBreakpointTemplateData> {
constructor(
private debugService: IDebugService
@ -409,7 +409,7 @@ class ExceptionBreakpointsRenderer implements IRenderer<IExceptionBreakpoint, IB
}
}
class FunctionBreakpointsRenderer implements IRenderer<FunctionBreakpoint, IBaseBreakpointWithIconTemplateData> {
class FunctionBreakpointsRenderer implements IListRenderer<FunctionBreakpoint, IBaseBreakpointWithIconTemplateData> {
constructor(
@IDebugService private debugService: IDebugService
@ -468,7 +468,7 @@ class FunctionBreakpointsRenderer implements IRenderer<FunctionBreakpoint, IBase
}
}
class FunctionBreakpointInputRenderer implements IRenderer<IFunctionBreakpoint, IInputTemplateData> {
class FunctionBreakpointInputRenderer implements IListRenderer<IFunctionBreakpoint, IInputTemplateData> {
constructor(
private debugService: IDebugService,

4
src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts
View file

@ -9,7 +9,7 @@ import { IDisposable, dispose } from 'vs/base/common/lifecycle';
import { Action } from 'vs/base/common/actions';
import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { IVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IPagedRenderer } from 'vs/base/browser/ui/list/listPaging';
import { once } from 'vs/base/common/event';
import { domEvent } from 'vs/base/browser/event';
@ -36,7 +36,7 @@ export interface ITemplateData {
extensionDisposables: IDisposable[];
}
export class Delegate implements IVirtualDelegate<IExtension> {
export class Delegate implements IListVirtualDelegate<IExtension> {
getHeight() { return 62; }
getTemplateId() { return 'extension'; }
}

6
src/vs/workbench/parts/extensions/electron-browser/runtimeExtensionsEditor.ts
View file

@ -16,7 +16,7 @@ import { IExtensionsWorkbenchService, IExtension } from 'vs/workbench/parts/exte
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
import { IExtensionService, IExtensionDescription, IExtensionsStatus, IExtensionHostProfile } from 'vs/workbench/services/extensions/common/extensions';
import { IVirtualDelegate, IRenderer } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer } from 'vs/base/browser/ui/list/list';
import { WorkbenchList } from 'vs/platform/list/browser/listService';
import { append, $, addClass, toggleClass, Dimension } from 'vs/base/browser/dom';
import { ActionBar, Separator } from 'vs/base/browser/ui/actionbar/actionbar';
@ -230,7 +230,7 @@ export class RuntimeExtensionsEditor extends BaseEditor {
const TEMPLATE_ID = 'runtimeExtensionElementTemplate';
const delegate = new class implements IVirtualDelegate<IRuntimeExtension>{
const delegate = new class implements IListVirtualDelegate<IRuntimeExtension>{
getHeight(element: IRuntimeExtension): number {
return 62;
}
@ -257,7 +257,7 @@ export class RuntimeExtensionsEditor extends BaseEditor {
elementDisposables: IDisposable[];
}
const renderer: IRenderer<IRuntimeExtension, IRuntimeExtensionTemplateData> = {
const renderer: IListRenderer<IRuntimeExtension, IRuntimeExtensionTemplateData> = {
templateId: TEMPLATE_ID,
renderTemplate: (root: HTMLElement): IRuntimeExtensionTemplateData => {
const element = append(root, $('.extension'));

8
src/vs/workbench/parts/files/electron-browser/views/openEditorsView.ts
View file

@ -25,7 +25,7 @@ import { attachStylerCallback } from 'vs/platform/theme/common/styler';
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { badgeBackground, badgeForeground, contrastBorder } from 'vs/platform/theme/common/colorRegistry';
import { WorkbenchList } from 'vs/platform/list/browser/listService';
import { IVirtualDelegate, IRenderer, IListContextMenuEvent } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer, IListContextMenuEvent } from 'vs/base/browser/ui/list/list';
import { EditorLabel } from 'vs/workbench/browser/labels';
import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar';
import { TPromise } from 'vs/base/common/winjs.base';
@ -499,7 +499,7 @@ class OpenEditorActionRunner extends ActionRunner {
}
}
class OpenEditorsDelegate implements IVirtualDelegate<OpenEditor | IEditorGroup> {
class OpenEditorsDelegate implements IListVirtualDelegate<OpenEditor | IEditorGroup> {
public static readonly ITEM_HEIGHT = 22;
@ -542,7 +542,7 @@ function dropOnEditorSupported(e: DragEvent): boolean {
}
}
class EditorGroupRenderer implements IRenderer<IEditorGroup, IEditorGroupTemplateData> {
class EditorGroupRenderer implements IListRenderer<IEditorGroup, IEditorGroupTemplateData> {
static readonly ID = 'editorgroup';
private transfer = LocalSelectionTransfer.getInstance<OpenEditor>();
@ -615,7 +615,7 @@ class EditorGroupRenderer implements IRenderer<IEditorGroup, IEditorGroupTemplat
}
}
class OpenEditorRenderer implements IRenderer<OpenEditor, IOpenEditorTemplateData> {
class OpenEditorRenderer implements IListRenderer<OpenEditor, IOpenEditorTemplateData> {
static readonly ID = 'openeditor';
private transfer = LocalSelectionTransfer.getInstance<OpenEditor>();

4
src/vs/workbench/parts/markers/electron-browser/markersTreeViewer.ts
View file

@ -21,7 +21,7 @@ import { ActionBar, IActionItemProvider } from 'vs/base/browser/ui/actionbar/act
import { QuickFixAction } from 'vs/workbench/parts/markers/electron-browser/markersPanelActions';
import { ILabelService } from 'vs/platform/label/common/label';
import { dirname } from 'vs/base/common/resources';
import { IVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
import { ITreeFilter, TreeVisibility, TreeFilterResult, ITreeRenderer, ITreeNode } from 'vs/base/browser/ui/tree/tree';
import { FilterOptions } from 'vs/workbench/parts/markers/electron-browser/markersFilterOptions';
import { IMatch } from 'vs/base/common/filters';
@ -78,7 +78,7 @@ const enum TemplateId {
RelatedInformation = 'ri'
}
export class VirtualDelegate implements IVirtualDelegate<ResourceMarkers | Marker | RelatedInformation> {
export class VirtualDelegate implements IListVirtualDelegate<ResourceMarkers | Marker | RelatedInformation> {
getHeight(): number {
return 22;

8
src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts
View file

@ -31,7 +31,7 @@ import {
import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
import { IKeybindingEditingService } from 'vs/workbench/services/keybinding/common/keybindingEditing';
import { List } from 'vs/base/browser/ui/list/listWidget';
import { IVirtualDelegate, IRenderer, IListContextMenuEvent, IListEvent } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer, IListContextMenuEvent, IListEvent } from 'vs/base/browser/ui/list/list';
import { IThemeService, registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService';
import { IContextKeyService, IContextKey } from 'vs/platform/contextkey/common/contextkey';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
@ -653,7 +653,7 @@ export class KeybindingsEditor extends BaseEditor implements IKeybindingsEditor
}
}
class Delegate implements IVirtualDelegate<IListEntry> {
class Delegate implements IListVirtualDelegate<IListEntry> {
getHeight(element: IListEntry) {
if (element.templateId === KEYBINDING_ENTRY_TEMPLATE_ID) {
@ -686,7 +686,7 @@ interface KeybindingItemTemplate {
when: WhenColumn;
}
class KeybindingHeaderRenderer implements IRenderer<IListEntry, any> {
class KeybindingHeaderRenderer implements IListRenderer<IListEntry, any> {
get templateId(): string { return KEYBINDING_HEADER_TEMPLATE_ID; }
@ -713,7 +713,7 @@ class KeybindingHeaderRenderer implements IRenderer<IListEntry, any> {
}
}
class KeybindingItemRenderer implements IRenderer<IKeybindingItemEntry, KeybindingItemTemplate> {
class KeybindingItemRenderer implements IListRenderer<IKeybindingItemEntry, KeybindingItemTemplate> {
get templateId(): string { return KEYBINDING_ENTRY_TEMPLATE_ID; }

12
src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts
View file

@ -14,7 +14,7 @@ import { PanelViewlet, ViewletPanel, IViewletPanelOptions } from 'vs/workbench/b
import { append, $, addClass, toggleClass, trackFocus, Dimension, addDisposableListener } from 'vs/base/browser/dom';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { List } from 'vs/base/browser/ui/list/listWidget';
import { IVirtualDelegate, IRenderer, IListContextMenuEvent, IListEvent } from 'vs/base/browser/ui/list/list';
import { IListVirtualDelegate, IListRenderer, IListContextMenuEvent, IListEvent } from 'vs/base/browser/ui/list/list';
import { VIEWLET_ID, VIEW_CONTAINER } from 'vs/workbench/parts/scm/common/scm';
import { FileLabel } from 'vs/workbench/browser/labels';
import { CountBadge } from 'vs/base/browser/ui/countBadge/countBadge';
@ -70,7 +70,7 @@ export interface IViewModel {
hide(repository: ISCMRepository): void;
}
class ProvidersListDelegate implements IVirtualDelegate<ISCMRepository> {
class ProvidersListDelegate implements IListVirtualDelegate<ISCMRepository> {
getHeight(element: ISCMRepository): number {
return 22;
@ -119,7 +119,7 @@ interface RepositoryTemplateData {
templateDisposable: IDisposable;
}
class ProviderRenderer implements IRenderer<ISCMRepository, RepositoryTemplateData> {
class ProviderRenderer implements IListRenderer<ISCMRepository, RepositoryTemplateData> {
readonly templateId = 'provider';
@ -368,7 +368,7 @@ interface ResourceGroupTemplate {
dispose: () => void;
}
class ResourceGroupRenderer implements IRenderer<ISCMResourceGroup, ResourceGroupTemplate> {
class ResourceGroupRenderer implements IListRenderer<ISCMResourceGroup, ResourceGroupTemplate> {
static TEMPLATE_ID = 'resource group';
get templateId(): string { return ResourceGroupRenderer.TEMPLATE_ID; }
@ -477,7 +477,7 @@ class MultipleSelectionActionRunner extends ActionRunner {
}
}
class ResourceRenderer implements IRenderer<ISCMResource, ResourceTemplate> {
class ResourceRenderer implements IListRenderer<ISCMResource, ResourceTemplate> {
static TEMPLATE_ID = 'resource';
get templateId(): string { return ResourceRenderer.TEMPLATE_ID; }
@ -570,7 +570,7 @@ class ResourceRenderer implements IRenderer<ISCMResource, ResourceTemplate> {
}
}
class ProviderListDelegate implements IVirtualDelegate<ISCMResourceGroup | ISCMResource> {
class ProviderListDelegate implements IListVirtualDelegate<ISCMResourceGroup | ISCMResource> {
getHeight() { return 22; }