development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-01 08:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use shell for spawning node (#213960)

Browse source 
Fixes #204678
This commit is contained in:
Matt Bierner 2024-05-30 17:08:47 -07:00 committed by GitHub
parent ca688da9fb
commit b1ecfe96b5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
extensions/typescript-language-features/src/tsServer/serverProcess.electron.ts
View file

@ -278,8 +278,7 @@ export class ElectronServiceProcessFactory implements TsServerProcessFactory {
}
const childProcess = execPath ?
child_process.spawn(JSON.stringify(execPath), [...execArgv, tsServerPath, ...runtimeArgs], {
shell: true,
child_process.spawn(execPath, [...execArgv, tsServerPath, ...runtimeArgs], {
windowsHide: true,
cwd: undefined,
env,

2
extensions/typescript-language-features/src/tsServer/spawner.ts
View file

@ -234,7 +234,7 @@ export class TypeScriptServerSpawner {
tsServerLog = { type: 'file', uri: logFilePath };
args.push('--logVerbosity', TsServerLogLevel.toString(configuration.tsServerLogLevel));
args.push('--logFile', `"${logFilePath.fsPath}"`);
args.push('--logFile', logFilePath.fsPath);
}
}
}